Skip to content

Commit 9522ed8

Browse files
committed
[Dns] improved error message
1 parent 1037fc3 commit 9522ed8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Query/Executor.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public function query($nameserver, Query $query, $callback, $errorback)
3232
$queryData = $this->dumper->toBinary($request);
3333
$transport = strlen($queryData) > 512 ? 'tcp' : 'udp';
3434

35-
$this->doQuery($nameserver, $transport, $queryData, $callback, $errorback);
35+
$this->doQuery($nameserver, $transport, $queryData, $query->name, $callback, $errorback);
3636
}
3737

3838
public function prepareRequest(Query $query)
@@ -46,21 +46,21 @@ public function prepareRequest(Query $query)
4646
return $request;
4747
}
4848

49-
public function doQuery($nameserver, $transport, $queryData, $callback, $errorback)
49+
public function doQuery($nameserver, $transport, $queryData, $name, $callback, $errorback)
5050
{
5151
$that = $this;
5252
$parser = $this->parser;
5353
$loop = $this->loop;
5454

5555
$response = new Message();
5656

57-
$retryWithTcp = function () use ($that, $nameserver, $queryData, $callback, $errorback) {
58-
$that->doQuery($nameserver, 'tcp', $queryData, $callback, $errorback);
57+
$retryWithTcp = function () use ($that, $nameserver, $queryData, $name, $callback, $errorback) {
58+
$that->doQuery($nameserver, 'tcp', $queryData, $name, $callback, $errorback);
5959
};
6060

61-
$timer = $this->loop->addTimer($this->timeout, function () use (&$conn, $errorback) {
61+
$timer = $this->loop->addTimer($this->timeout, function () use (&$conn, $name, $errorback) {
6262
$conn->close();
63-
$errorback(new TimeoutException("query timed out"));
63+
$errorback(new TimeoutException(sprintf("DNS query for %s timed out", $name)));
6464
});
6565

6666
$conn = $this->createConnection($nameserver, $transport);

0 commit comments

Comments
 (0)