[dns] Add todos for more robust resolver

igorw · igorw · commit 11feadff5e7d · 2012-08-31T06:02:57.000+02:00
diff --git a/Resolver/Resolver.php b/Resolver/Resolver.php
@@ -51,6 +51,9 @@ public function extractAddress(Message $response, $type, $callback)
 
     public function pickRandomAnswerOfType(Message $response, $type)
     {
+        // TODO: filter by name to make sure domain matches
+        // TODO: resolve CNAME aliases
+
         $filteredAnswers = array_filter($response->answers, function ($answer) use ($type) {
             return $type === $answer->type;
         });

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ public function extractAddress(Message $response, $type, $callback)`
`51`	`51`
`52`	`52`	`public function pickRandomAnswerOfType(Message $response, $type)`
`53`	`53`	`{`
	`54`	`+ // TODO: filter by name to make sure domain matches`
	`55`	`+ // TODO: resolve CNAME aliases`
	`56`	`+`
`54`	`57`	`$filteredAnswers = array_filter($response->answers, function ($answer) use ($type) {`
`55`	`58`	`return $type === $answer->type;`
`56`	`59`	`});`