Skip to content

Commit b4de700

Browse files
authored
[Beta] Add ARIA labels (#4335)
* Add ARIA labels * Remove unnecessary ARIA label * Add Facebook and Twitter ARIA labels
1 parent b10ae60 commit b4de700

3 files changed

Lines changed: 4 additions & 0 deletions

File tree

beta/src/components/Layout/Footer.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,13 @@ export function Footer() {
126126
</FooterLink>
127127
<div className="flex flex-row mt-8 gap-x-2">
128128
<ExternalLink
129+
aria-label="React on Facebook"
129130
href="https://www.facebook.com/react"
130131
className={socialLinkClasses}>
131132
<IconFacebookCircle />
132133
</ExternalLink>
133134
<ExternalLink
135+
aria-label="React on Twitter"
134136
href="https://twitter.com/reactjs"
135137
className={socialLinkClasses}>
136138
<IconTwitter />

beta/src/components/Layout/Nav/Nav.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ export default function Nav() {
173173
<div className="flex my-4 h-10 mx-0 w-full lg:hidden justify-end slg:max-w-sm">
174174
<Search />
175175
<button
176+
aria-label="Give feedback"
176177
type="button"
177178
className="inline-flex lg:hidden items-center p-1 ml-4 lg:ml-6 relative top-px"
178179
onClick={handleFeedback}>

beta/src/components/Search.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export const Search: React.FC<SearchProps> = ({
9595
</Head>
9696

9797
<button
98+
aria-label="Search"
9899
type="button"
99100
className="inline-flex md:hidden items-center text-lg p-1 ml-4 lg:ml-6"
100101
onClick={onOpen}>

0 commit comments

Comments
 (0)