From 532e86f6307425340efb2ae6ea09c8405e5e4cf0 Mon Sep 17 00:00:00 2001 From: xThreeh Date: Fri, 9 Oct 2026 03:16:26 -0300 Subject: [PATCH] Make the HelloWorld dynamic-frameworks CI lane use dynamic frameworks #54482 switched the test_ios_helloworld matrix to use_frameworks: [false, true] but left the test-ios-helloworld action comparing the input to "DynamicFrameworks", so the true lane builds with static libraries and the Debug exclude (StaticLibraries) matches nothing. Compare against "true" like test-ios-rntester does and exclude use_frameworks: false. --- .github/actions/test-ios-helloworld/action.yml | 6 +++--- .github/workflows/test-all.yml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/actions/test-ios-helloworld/action.yml b/.github/actions/test-ios-helloworld/action.yml index b325a061d929..9417842af58e 100644 --- a/.github/actions/test-ios-helloworld/action.yml +++ b/.github/actions/test-ios-helloworld/action.yml @@ -2,8 +2,8 @@ name: test-ios-helloworld description: Test iOS Hello World inputs: use-frameworks: - description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks" - default: StaticLibraries + description: Whether to build with dynamic frameworks. + default: false ruby-version: description: The version of ruby that must be used default: 2.6.10 @@ -51,7 +51,7 @@ runs: cd private/helloworld args=() - if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then + if [[ "${{ inputs.use-frameworks }}" == "true" ]]; then args+=(--frameworks dynamic) fi diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index afa299e09a1c..fe4f2a56633b 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -534,7 +534,7 @@ jobs: exclude: # This config is tested with Ruby 3.2.0. Let's not double test it. - flavor: Debug - use_frameworks: StaticLibraries + use_frameworks: false env: PROJECT_NAME: iOSTemplateProject YARN_ENABLE_IMMUTABLE_INSTALLS: false