Skip to content

Commit fecef73

Browse files
j-piaseckimeta-codesync[bot]
j-piasecki
authored and
meta-codesync[bot]
committed
Cover react/nativemodule/viewtransition with Stable API guards (#59058)
Summary: Pull Request resolved: #59058 Marks `react/nativemodule/viewtransition` as a private target under the C++ Stable API: `NativeViewTransition.h` includes `<react/cxxstableapi/PrivateGuard.h>`, and BUCK, CMake, and the podspec depend on `cxxstableapi`. The guard is inert unless `RN_STRICT_API` is defined, so there is no behavior change. Changelog: [Internal] ___ landed-with-radar-review Reviewed By: cortinico Differential Revision: D125183881 fbshipit-source-id: fbe83db4ef27ae09aa0e0e6cf542734931f59081
1 parent cb5ea03 commit fecef73

15 files changed

Lines changed: 4 additions & 96 deletions

‎packages/react-native/ReactCommon/react/nativemodule/viewtransition/CMakeLists.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ target_include_directories(react_nativemodule_viewtransition PUBLIC ${REACT_COMM
1616
target_link_libraries(react_nativemodule_viewtransition
1717
react_codegen_rncore
1818
react_cxxreact
19+
react_cxxstableapi
1920
react_renderer_bridging
2021
react_renderer_core
2122
react_renderer_uimanager

‎packages/react-native/ReactCommon/react/nativemodule/viewtransition/NativeViewTransition.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <optional>
1113
#include <string>
1214

‎packages/react-native/ReactCommon/react/nativemodule/viewtransition/React-viewtransitionnativemodule.podspec‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ Pod::Spec.new do |s|
5353
s.dependency "ReactCommon/turbomodule/core"
5454
add_dependency(s, "React-Fabric")
5555
s.dependency "React-Fabric/bridging"
56+
s.dependency "React-cxxstableapi"
5657
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
5758
add_dependency(s, "React-RCTFBReactNativeSpec")
5859

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2077,14 +2077,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
20772077
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
20782078
}
20792079

2080-
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
2081-
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2082-
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
2083-
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
2084-
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
2085-
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
2086-
}
2087-
20882080
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
20892081
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
20902082
}

‎scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3126,14 +3126,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
31263126
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
31273127
}
31283128

3129-
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
3130-
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
3131-
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
3132-
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
3133-
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
3134-
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
3135-
}
3136-
31373129
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
31383130
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
31393131
}

‎scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2076,14 +2076,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
20762076
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
20772077
}
20782078

2079-
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
2080-
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2081-
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
2082-
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
2083-
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
2084-
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
2085-
}
2086-
20872079
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
20882080
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
20892081
}

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2076,14 +2076,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::JavaTurb
20762076
public NativeVibrationSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
20772077
}
20782078

2079-
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
2080-
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
2081-
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
2082-
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
2083-
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
2084-
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
2085-
}
2086-
20872079
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::JavaTurboModule {
20882080
public NativeWebSocketModuleSpecJSI(const facebook::react::JavaTurboModule::InitParams& params);
20892081
}

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4320,14 +4320,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
43204320
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
43214321
}
43224322

4323-
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
4324-
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
4325-
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
4326-
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
4327-
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
4328-
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
4329-
}
4330-
43314323
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
43324324
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
43334325
}

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5298,14 +5298,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
52985298
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
52995299
}
53005300

5301-
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
5302-
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
5303-
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
5304-
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
5305-
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
5306-
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
5307-
}
5308-
53095301
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
53105302
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
53115303
}

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4311,14 +4311,6 @@ class facebook::react::NativeVibrationSpecJSI : public facebook::react::ObjCTurb
43114311
public NativeVibrationSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
43124312
}
43134313

4314-
class facebook::react::NativeViewTransition : public facebook::react::NativeViewTransitionCxxSpec<facebook::react::NativeViewTransition> {
4315-
public NativeViewTransition(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);
4316-
public facebook::jsi::Value findPseudoElementShadowNodeByTag(facebook::jsi::Runtime& rt, double reactTag);
4317-
public std::optional<facebook::jsi::Object> getViewTransitionInstance(facebook::jsi::Runtime& rt, const std::string& name, const std::string& pseudo);
4318-
public void transitionAnimationFinished(facebook::jsi::Runtime& rt, double animationId);
4319-
public void waitForTransitionAnimation(facebook::jsi::Runtime& rt, double animationId);
4320-
}
4321-
43224314
class facebook::react::NativeWebSocketModuleSpecJSI : public facebook::react::ObjCTurboModule {
43234315
public NativeWebSocketModuleSpecJSI(const facebook::react::ObjCTurboModule::InitParams& params);
43244316
}

0 commit comments

Comments
 (0)