You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d88231e
Browse filesBrowse the repository at this point in the historyBrowse files
[0.83] Pick WebSocket queue size fix for Android inspector (#56807)
* Limit WebSocket queue size for packager connection (#54300)
Summary:
Pull Request resolved: #54300
Establishes a queue mechanism on top of the OkHttp's WebSocket implementation. This mechanism will control the queue size and guarantee that we don't have more than 16MB scheduled.
This prevents the scenario of when OkHttp forces WS disconnection because of this threshold.
Reviewed By: motiz88, alanleedev
Differential Revision: D85581509
fbshipit-source-id: ac3e830c935c1301b674739c96fcbe18446eaa71
* Bump chunk size for android (#54301)
Summary:
Pull Request resolved: #54301
# Changelog: [Internal]
Previously, we would read every single kilobyte and do Java -> C++ call with `jni`.
For big objects, like source maps, this means that we were doing at least 1024 calls for a single megabyte of incoming data. From my observations, some source maps on Twilight could reach 30Mb+.
There is a trade-off between how much of memory we want to allocate while reading a stream and a runtime. I didn't notice any differences while changing the chunk size from 8Kb to 1Mb and some values in between; in the end it purely depends on the OkHttp's or Okio's implementation of the stream, looks like it uses 8Kb as a chunk size by default:
{F1983042734}
Reviewed By: huntie
Differential Revision: D85652217
fbshipit-source-id: 68474f0b7eece13a0a1c8ea9e617b99a26d81ff9
* Increase the size of the chunk of ProfileChunk events (#54352)
Summary:
Pull Request resolved: #54352
# Changelog: [Internal]
Since we can now avoid disconnections, it should be safe to increase the chunk size.
This should improve the trace loading time.
Reviewed By: huntie
Differential Revision: D85937959
fbshipit-source-id: 4f0ef023a4d756217de0c756dbc1decbd99698d4
---------
Co-authored-by: Ruslan Lesiutin <hoxy@meta.com>
Copy file name to clipboardExpand all lines: packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/CxxInspectorPackagerConnection.kt
Copy file name to clipboardExpand all lines: packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/inspector/InspectorNetworkHelper.kt
Copy file name to clipboardExpand all lines: packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JCxxInspectorPackagerConnectionWebSocket.cpp
+29-2Lines changed: 29 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -5,17 +5,44 @@
5
5
* LICENSE file in the root directory of this source tree.
0 commit comments