Skip to content

Commit d6d816c

Browse files
coadometa-codesync[bot]
authored andcommitted
Classify componentNameByReactViewName.h as for-frameworks (#59031)
Summary: Pull Request resolved: #59031 Move `componentNameByReactViewName.h` from the private tier back to the for-frameworks tier. The function maps legacy view names to Fabric component names. React Native itself only uses it inside the component registry and the iOS component view factory, and it is transitional, but libraries that integrate with the renderer call it directly; for example, an animation library uses it to resolve the component name for a view in its native module. Under `RN_STRICT_API` a private header is a hard error with no opt-out, so those libraries could not build at all. As for-frameworks, they get a warning that `RN_ALLOW_FRAMEWORKS` silences, and the function stays out of the public API. Changelog: [Internal] Differential Revision: D124970095 fbshipit-source-id: 9a510590ce88614603530f5de6f9fdd1760c21d4
1 parent fc4e706 commit d6d816c

4 files changed

Lines changed: 4 additions & 1 deletion

File tree

‎packages/react-native/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/PrivateGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <string>
1313

‎scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -783,6 +783,7 @@ std::optional<facebook::react::FilterType> facebook::react::filterTypeFromString
783783
std::optional<facebook::react::Float> facebook::react::optionalFloatFromYogaValue(const facebook::yoga::Style::Length& length, std::optional<facebook::react::Float> base = {});
784784
std::optional<facebook::react::FontVariant> facebook::react::fontVariantFromCSSFontVariant(facebook::react::CSSFontVariant cssVariant);
785785
std::optional<facebook::react::Isolation> facebook::react::isolationFromString(std::string_view isolationSetting);
786+
std::string facebook::react::componentNameByReactViewName(std::string viewName);
786787
std::string facebook::react::toString(const double& value);
787788
std::string facebook::react::toString(const facebook::react::AccessibilityRole& accessibilityRole);
788789
std::string facebook::react::toString(const facebook::react::AttributedString::Range& range);

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3568,6 +3568,7 @@ std::optional<facebook::react::FilterType> facebook::react::filterTypeFromString
35683568
std::optional<facebook::react::Float> facebook::react::optionalFloatFromYogaValue(const facebook::yoga::Style::Length& length, std::optional<facebook::react::Float> base = {});
35693569
std::optional<facebook::react::FontVariant> facebook::react::fontVariantFromCSSFontVariant(facebook::react::CSSFontVariant cssVariant);
35703570
std::optional<facebook::react::Isolation> facebook::react::isolationFromString(std::string_view isolationSetting);
3571+
std::string facebook::react::componentNameByReactViewName(std::string viewName);
35713572
std::string facebook::react::toString(const double& value);
35723573
std::string facebook::react::toString(const facebook::react::AccessibilityRole& accessibilityRole);
35733574
std::string facebook::react::toString(const facebook::react::AttributedString::Range& range);

‎scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,7 @@ std::optional<facebook::react::BlendMode> facebook::react::blendModeFromString(s
358358
std::optional<facebook::react::FilterType> facebook::react::filterTypeFromString(std::string_view filterName);
359359
std::optional<facebook::react::FontVariant> facebook::react::fontVariantFromCSSFontVariant(facebook::react::CSSFontVariant cssVariant);
360360
std::optional<facebook::react::Isolation> facebook::react::isolationFromString(std::string_view isolationSetting);
361+
std::string facebook::react::componentNameByReactViewName(std::string viewName);
361362
std::string facebook::react::toString(const double& value);
362363
std::string facebook::react::toString(const facebook::react::AccessibilityRole& accessibilityRole);
363364
std::string facebook::react::toString(const facebook::react::AttributedString::Range& range);

0 commit comments

Comments
 (0)