Only set stateDescription for the unchecked state of non-switch roles

TalkBack already announces the checked state of a checkable node in the
device language. React Native's state strings are translated by Meta's
internal pipeline after import, so a new string would be English-only
for a while. Keep the switch on/off strings, which are already translated
in every locale, and only fill the case TalkBack is silent on: unchecked
checkboxes and radios. Drop the unused state_checked_description.

Author: BilalWalker

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.kt

@@ -643,8 +643,11 @@ public open class ReactAccessibilityDelegate( // The View this delegate is attac
           info.isChecked = boolValue
           // TalkBack only speaks the unchecked state of a checkable node, and only avoids
           // announcing "checked" and "on" together for a switch, when the node carries a
-          // stateDescription (API 30+). Native CompoundButton always sets it, so do the same.
-          info.stateDescription = getCheckedStateDescription(boolValue, role, context)
+          // stateDescription (API 30+), as native CompoundButton sets.
+          val stateDescription = getCheckedStateDescription(boolValue, role, context)
+          if (stateDescription != null) {
+            info.stateDescription = stateDescription
+          }
         }
       }
     }
@@ -653,16 +656,17 @@ public open class ReactAccessibilityDelegate( // The View this delegate is attac
         checked: Boolean,
         role: AccessibilityRole?,
         context: Context,
-    ): String =
+    ): String? =
         if (role == AccessibilityRole.SWITCH) {
           context.getString(
               if (checked) R.string.state_on_description else R.string.state_off_description
           )
+        } else if (!checked) {
+          context.getString(R.string.state_unchecked_description)
         } else {
-          context.getString(
-              if (checked) R.string.state_checked_description
-              else R.string.state_unchecked_description
-          )
+          // Leave the checked state to TalkBack, which already announces it in the device
+          // language.
+          null
         }
 
     // TODO: Eventually support for other languages on talkback

packages/react-native/ReactAndroid/src/main/res/views/uimanager/values/strings.xml

@@ -96,10 +96,6 @@
     name="state_off_description"
     description="a switch in its disabled state"
     >off</string>
-  <string
-    name="state_checked_description"
-    description="a checkbox, radio button, or other checkable widget which is checked"
-    >checked</string>
   <string
     name="state_unchecked_description"
     description="a checkbox, radio button, or other checkable widget which is not checked"

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactAccessibilityDelegateTest.kt

@@ -395,13 +395,12 @@ class ReactAccessibilityDelegateTest {
   }
 
   @Test
-  fun testOnInitializeAccessibilityNodeInfo_checkedCheckbox_setsStateDescription() {
+  fun testOnInitializeAccessibilityNodeInfo_checkedCheckbox_leavesStateDescriptionUnset() {
     val info = initializeNodeInfoWithCheckedState(AccessibilityRole.CHECKBOX, checked = true)
 
     assertThat(info.isCheckable).isTrue()
     assertThat(info.isChecked).isTrue()
-    assertThat(info.stateDescription)
-        .isEqualTo(view.context.getString(R.string.state_checked_description))
+    assertThat(info.stateDescription).isNull()
   }
 
   @Test