Repository navigation
Commit 752034d
committed
Fix typo in VirtualizedSectionList._setUpdateHighlightFor deleting from method instead of map
The else branch of _setUpdateHighlightFor was calling:
delete this._updateHighlightFor[cellKey]
which targeted the arrow-function method itself rather than the
_updateHighlightMap backing store. This meant item highlight
callbacks were never cleaned up on unmount, causing a memory leak
and stale callbacks.
Fix: replace with delete this._updateHighlightMap[cellKey] to
match the symmetric _setUpdatePropsFor implementation. The
// \[prop-missing] suppression comment is also removed
since the correct target no longer triggers a Flow error.1 parent 800f350 commit 752034d
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
431 | 431 | | |
432 | 432 | | |
433 | 433 | | |
434 | | - | |
435 | | - | |
| 434 | + | |
436 | 435 | | |
437 | 436 | | |
438 | 437 | | |
| |||
0 commit comments