Skip to content

Commit 3d41699

Browse files
Keep ellipsizeMode when adjustsFontSizeToFit is set on Android
1 parent a6c6fe9 commit 3d41699

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -585,9 +585,7 @@ public void setEllipsizeLocation(@Nullable TextUtils.TruncateAt ellipsizeLocatio
585585
public void updateView() {
586586
@Nullable
587587
TextUtils.TruncateAt ellipsizeLocation =
588-
mNumberOfLines == ViewDefaults.NUMBER_OF_LINES || mAdjustsFontSizeToFit
589-
? null
590-
: mEllipsizeLocation;
588+
mNumberOfLines == ViewDefaults.NUMBER_OF_LINES ? null : mEllipsizeLocation;
591589
setEllipsize(ellipsizeLocation);
592590
}
593591

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/text/ReactTextViewTest.kt‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import android.graphics.Color
1414
import android.graphics.Paint
1515
import android.text.SpannableString
1616
import android.text.Spanned
17+
import android.text.TextUtils
1718
import android.text.style.ReplacementSpan
1819
import android.util.TypedValue
1920
import android.view.Gravity
@@ -109,6 +110,18 @@ class ReactTextViewTest {
109110
assertThat(view.useBoundsForWidth).isFalse()
110111
}
111112

113+
@Test
114+
fun adjustsFontSizeToFitKeepsEllipsizeLocation() {
115+
val view = TestReactTextView(RuntimeEnvironment.getApplication())
116+
view.setNumberOfLines(1)
117+
view.setEllipsizeLocation(TextUtils.TruncateAt.END)
118+
view.setAdjustFontSizeToFit(true)
119+
120+
view.updateView()
121+
122+
assertThat(view.ellipsize).isEqualTo(TextUtils.TruncateAt.END)
123+
}
124+
112125
private fun layoutAndDraw(view: TestReactTextView, width: Int, height: Int) {
113126
view.measure(
114127
View.MeasureSpec.makeMeasureSpec(width, View.MeasureSpec.EXACTLY),

0 commit comments

Comments
 (0)