Skip to content

Commit 302113f

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Make RuntimeExecutorSyncUIThreadUtils.h private (#58839)
Summary: Make `RuntimeExecutorSyncUIThreadUtils.h` private: switch it to `PrivateGuard.h` and drop it from the `<React/RuntimeExecutor.h>` umbrella. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123376642
1 parent 8d658f4 commit 302113f

7 files changed

Lines changed: 2 additions & 11 deletions

File tree

‎packages/react-native/ReactCommon/runtimeexecutor/React/RuntimeExecutor.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
#define RN_UMBRELLA_CONTEXT 1
3232

3333
#include <ReactCommon/RuntimeExecutor.h>
34-
#include <ReactCommon/RuntimeExecutorSyncUIThreadUtils.h>
3534

3635
#undef RN_UMBRELLA_CONTEXT
3736
#pragma pop_macro("RN_UMBRELLA_CONTEXT")

‎packages/react-native/ReactCommon/runtimeexecutor/platform/cxx/ReactCommon/RuntimeExecutorSyncUIThreadUtils.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <ReactCommon/RuntimeExecutor.h>
1313

‎packages/react-native/ReactCommon/runtimeexecutor/platform/ios/ReactCommon/RuntimeExecutorSyncUIThreadUtils.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <ReactCommon/RuntimeExecutor.h>
1313

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3383,7 +3383,6 @@ uint8_t facebook::react::blueFromColor(facebook::react::SharedColor color) noexc
33833383
uint8_t facebook::react::greenFromColor(facebook::react::SharedColor color) noexcept;
33843384
uint8_t facebook::react::redFromColor(facebook::react::SharedColor color) noexcept;
33853385
void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(std::shared_ptr<const facebook::react::ComponentDescriptorProviderRegistry> registry);
3386-
void facebook::react::executeSynchronouslyOnSameThread_CAN_DEADLOCK(const facebook::react::RuntimeExecutor& runtimeExecutor, std::function<void(facebook::jsi::Runtime&)>&& runtimeWork);
33873386
void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);
33883387
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, YGValue& result);
33893388
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::AccessibilityAction& result);
@@ -3437,7 +3436,6 @@ void facebook::react::serializeTransformAxis(const facebook::react::TransformOpe
34373436
void facebook::react::serializeTransformOperationValue(const std::string& operationName, const facebook::react::ValueUnit& valueUnit, folly::dynamic& resultArray);
34383437
void facebook::react::setDefaultColorSpace(facebook::react::ColorSpace newColorSpace);
34393438
void facebook::react::setTouchPayloadOnObject(facebook::jsi::Object& object, facebook::jsi::Runtime& runtime, const facebook::react::BaseTouch& touch);
3440-
void facebook::react::unsafeExecuteOnMainThreadSync(std::function<void()> work);
34413439
void facebook::react::updateTransformProps(const facebook::react::Transform& transform, const facebook::react::TransformOperation& operation, folly::dynamic& resultTranslateArray);
34423440
bool facebook::react::operator==(const facebook::react::LayoutConstraints& lhs, const facebook::react::LayoutConstraints& rhs);
34433441
bool facebook::react::operator==(const facebook::react::LayoutContext& lhs, const facebook::react::LayoutContext& rhs);

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3674,7 +3674,6 @@ void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(
36743674
void facebook::react::bindNativeLogger(facebook::jsi::Runtime& runtime, facebook::react::Logger logger);
36753675
void facebook::react::bindNativePerformanceNow(facebook::jsi::Runtime& runtime);
36763676
void facebook::react::cloneProp(facebook::react::BaseViewProps& viewProps, const facebook::react::AnimatedPropBase& animatedProp);
3677-
void facebook::react::executeSynchronouslyOnSameThread_CAN_DEADLOCK(const facebook::react::RuntimeExecutor& runtimeExecutor, std::function<void(facebook::jsi::Runtime&)>&& runtimeWork);
36783677
void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);
36793678
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, YGValue& result);
36803679
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::AccessibilityAction& result);
@@ -3763,7 +3762,6 @@ void facebook::react::serializeTransformAxis(const facebook::react::TransformOpe
37633762
void facebook::react::serializeTransformOperationValue(const std::string& operationName, const facebook::react::ValueUnit& valueUnit, folly::dynamic& resultArray);
37643763
void facebook::react::setDefaultColorSpace(facebook::react::ColorSpace newColorSpace);
37653764
void facebook::react::setTouchPayloadOnObject(facebook::jsi::Object& object, facebook::jsi::Runtime& runtime, const facebook::react::BaseTouch& touch);
3766-
void facebook::react::unsafeExecuteOnMainThreadSync(std::function<void()> work);
37673765
void facebook::react::updateTransformProps(const facebook::react::Transform& transform, const facebook::react::TransformOperation& operation, folly::dynamic& resultTranslateArray);
37683766
bool facebook::react::operator==(const facebook::react::AttributedStringBox& lhs, const facebook::react::AttributedStringBox& rhs);
37693767
bool facebook::react::operator==(const facebook::react::LayoutConstraints& lhs, const facebook::react::LayoutConstraints& rhs);

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3375,7 +3375,6 @@ uint8_t facebook::react::blueFromColor(facebook::react::SharedColor color) noexc
33753375
uint8_t facebook::react::greenFromColor(facebook::react::SharedColor color) noexcept;
33763376
uint8_t facebook::react::redFromColor(facebook::react::SharedColor color) noexcept;
33773377
void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(std::shared_ptr<const facebook::react::ComponentDescriptorProviderRegistry> registry);
3378-
void facebook::react::executeSynchronouslyOnSameThread_CAN_DEADLOCK(const facebook::react::RuntimeExecutor& runtimeExecutor, std::function<void(facebook::jsi::Runtime&)>&& runtimeWork);
33793378
void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);
33803379
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, YGValue& result);
33813380
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::AccessibilityAction& result);
@@ -3429,7 +3428,6 @@ void facebook::react::serializeTransformAxis(const facebook::react::TransformOpe
34293428
void facebook::react::serializeTransformOperationValue(const std::string& operationName, const facebook::react::ValueUnit& valueUnit, folly::dynamic& resultArray);
34303429
void facebook::react::setDefaultColorSpace(facebook::react::ColorSpace newColorSpace);
34313430
void facebook::react::setTouchPayloadOnObject(facebook::jsi::Object& object, facebook::jsi::Runtime& runtime, const facebook::react::BaseTouch& touch);
3432-
void facebook::react::unsafeExecuteOnMainThreadSync(std::function<void()> work);
34333431
void facebook::react::updateTransformProps(const facebook::react::Transform& transform, const facebook::react::TransformOperation& operation, folly::dynamic& resultTranslateArray);
34343432
bool facebook::react::operator==(const facebook::react::LayoutConstraints& lhs, const facebook::react::LayoutConstraints& rhs);
34353433
bool facebook::react::operator==(const facebook::react::LayoutContext& lhs, const facebook::react::LayoutContext& rhs);

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3383,7 +3383,6 @@ uint8_t facebook::react::blueFromColor(facebook::react::SharedColor color) noexc
33833383
uint8_t facebook::react::greenFromColor(facebook::react::SharedColor color) noexcept;
33843384
uint8_t facebook::react::redFromColor(facebook::react::SharedColor color) noexcept;
33853385
void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(std::shared_ptr<const facebook::react::ComponentDescriptorProviderRegistry> registry);
3386-
void facebook::react::executeSynchronouslyOnSameThread_CAN_DEADLOCK(const facebook::react::RuntimeExecutor& runtimeExecutor, std::function<void(facebook::jsi::Runtime&)>&& runtimeWork);
33873386
void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);
33883387
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, YGValue& result);
33893388
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::AccessibilityAction& result);
@@ -3437,7 +3436,6 @@ void facebook::react::serializeTransformAxis(const facebook::react::TransformOpe
34373436
void facebook::react::serializeTransformOperationValue(const std::string& operationName, const facebook::react::ValueUnit& valueUnit, folly::dynamic& resultArray);
34383437
void facebook::react::setDefaultColorSpace(facebook::react::ColorSpace newColorSpace);
34393438
void facebook::react::setTouchPayloadOnObject(facebook::jsi::Object& object, facebook::jsi::Runtime& runtime, const facebook::react::BaseTouch& touch);
3440-
void facebook::react::unsafeExecuteOnMainThreadSync(std::function<void()> work);
34413439
void facebook::react::updateTransformProps(const facebook::react::Transform& transform, const facebook::react::TransformOperation& operation, folly::dynamic& resultTranslateArray);
34423440
bool facebook::react::operator==(const facebook::react::LayoutConstraints& lhs, const facebook::react::LayoutConstraints& rhs);
34433441
bool facebook::react::operator==(const facebook::react::LayoutContext& lhs, const facebook::react::LayoutContext& rhs);

0 commit comments

Comments
 (0)