Skip to content

Commit 097e083

Browse files
Update LogBox snapshots for the C++ Image resizeMode default (#58923)
Summary: `Image` `resizeMode` now defaults to `cover` in C++, so Fantom no longer renders `resizeMode="cover"` on `<rn-image>`. The `Image` integration tests were updated for this, but the LogBox UI snapshots still expected the prop, so 6 LogBox Fantom tests fail on main. Changelog: [Internal] Reviewed By: rickhanlonii Differential Revision: D123876368
1 parent 278e7f9 commit 097e083

4 files changed

Lines changed: 0 additions & 9 deletions

File tree

‎packages/react-native/Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxInspector-itest.js.snap‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ exports[`LogBoxInspector should render fatal with selectedIndex 2 1`] = `
2424
<rn-image
2525
height="14"
2626
overflow="hidden"
27-
resizeMode="cover"
2827
source-scale="1"
2928
source-size="{16, 28}"
3029
source-type="local"
@@ -63,7 +62,6 @@ exports[`LogBoxInspector should render fatal with selectedIndex 2 1`] = `
6362
<rn-image
6463
height="14"
6564
overflow="hidden"
66-
resizeMode="cover"
6765
source-scale="1"
6866
source-size="{16, 28}"
6967
source-type="local"
@@ -215,7 +213,6 @@ exports[`LogBoxInspector should render warning with selectedIndex 0 1`] = `
215213
<rn-image
216214
height="14"
217215
overflow="hidden"
218-
resizeMode="cover"
219216
source-scale="1"
220217
source-size="{16, 28}"
221218
source-type="local"
@@ -254,7 +251,6 @@ exports[`LogBoxInspector should render warning with selectedIndex 0 1`] = `
254251
<rn-image
255252
height="14"
256253
overflow="hidden"
257-
resizeMode="cover"
258254
source-scale="1"
259255
source-size="{16, 28}"
260256
source-type="local"

‎packages/react-native/Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxInspectorHeader-itest.js.snap‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ exports[`LogBoxInspectorHeader should render both buttons for two total 1`] = `
2020
<rn-image
2121
height="14"
2222
overflow="hidden"
23-
resizeMode="cover"
2423
source-scale="1"
2524
source-size="{16, 28}"
2625
source-type="local"
@@ -59,7 +58,6 @@ exports[`LogBoxInspectorHeader should render both buttons for two total 1`] = `
5958
<rn-image
6059
height="14"
6160
overflow="hidden"
62-
resizeMode="cover"
6361
source-scale="1"
6462
source-size="{16, 28}"
6563
source-type="local"

‎packages/react-native/Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxInspectorSourceMapStatus-itest.js.snap‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ exports[`LogBoxInspectorSourceMapStatus should render for failed 1`] = `
1313
height="14"
1414
marginEnd="4"
1515
overflow="hidden"
16-
resizeMode="cover"
1716
source-scale="1"
1817
source-size="{48, 42}"
1918
source-type="local"
@@ -50,7 +49,6 @@ exports[`LogBoxInspectorSourceMapStatus should render for pending 1`] = `
5049
height="14"
5150
marginEnd="4"
5251
overflow="hidden"
53-
resizeMode="cover"
5452
source-scale="1"
5553
source-size="{44, 44}"
5654
source-type="local"

‎packages/react-native/Libraries/LogBox/UI/__tests__/__snapshots__/LogBoxNotification-itest.js.snap‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ exports[`LogBoxNotification should render log 1`] = `
9191
<rn-image
9292
height="8"
9393
overflow="hidden"
94-
resizeMode="cover"
9594
source-scale="1"
9695
source-size="{28, 28}"
9796
source-type="local"

0 commit comments

Comments
 (0)