From 5bc7583aa18730adfbb64ffee90c8e9174c82ac2 Mon Sep 17 00:00:00 2001 From: rdkdevpilot Date: Mon, 14 Sep 2026 07:52:22 +0530 Subject: [PATCH 1/7] Fix COPY_INSTEAD_OF_MOVE in NetworkManagerGnomeUtils.cpp Defect ID: 4c509ab1-5c48-4af5-af00-78f481c18969 --- plugin/gnome/NetworkManagerGnomeUtils.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/plugin/gnome/NetworkManagerGnomeUtils.cpp b/plugin/gnome/NetworkManagerGnomeUtils.cpp index fa2b28690..51973c5b4 100644 --- a/plugin/gnome/NetworkManagerGnomeUtils.cpp +++ b/plugin/gnome/NetworkManagerGnomeUtils.cpp @@ -274,9 +274,9 @@ namespace WPEFramework } file.close(); - m_wlanifname = wifiIfname; - m_ethifname = ethIfname; - m_deviceHostname = deviceHostname; + m_wlanifname = std::move(wifiIfname); + m_ethifname = std::move(ethIfname); + m_deviceHostname = std::move(deviceHostname); NMLOG_INFO("/etc/device.properties eth: %s, wlan: %s, default hostname: %s", m_ethifname.c_str(), m_wlanifname.c_str(), m_deviceHostname.c_str()); return true; } @@ -392,7 +392,7 @@ namespace WPEFramework // Remove any whitespace, newlines, etc. line.erase(line.find_last_not_of("\r\n\t") + 1); line.erase(0, line.find_first_not_of("\r\n\t")); - hostname = line; + hostname = std::move(line); file.close(); NMLOG_INFO("Read persistent hostname: '%s'", hostname.c_str()); @@ -426,7 +426,7 @@ namespace WPEFramework if (iss >> ip >> hwType >> flags >> hwAddr) { if (ip == gatewayIp && hwAddr != "00:00:00:00:00:00") { - mac = hwAddr; + mac = std::move(hwAddr); NMLOG_INFO("Resolved gateway IP %s to MAC %s", gatewayIp.c_str(), mac.c_str()); break; } From 7cc44f3da6fee3ed993929802bea17566a9a26ce Mon Sep 17 00:00:00 2001 From: rdkdevpilot Date: Mon, 14 Sep 2026 07:52:23 +0530 Subject: [PATCH 2/7] Fix COPY_INSTEAD_OF_MOVE in NetworkManagerConnectivity.cpp Defect ID: 47644ad7-d7a1-49ae-a9fa-e7923c7c535b --- plugin/NetworkManagerConnectivity.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugin/NetworkManagerConnectivity.cpp b/plugin/NetworkManagerConnectivity.cpp index 57243aaef..0cd99af23 100644 --- a/plugin/NetworkManagerConnectivity.cpp +++ b/plugin/NetworkManagerConnectivity.cpp @@ -278,7 +278,7 @@ namespace WPEFramework return; } - internetSate = checkCurlResponse(endpoints, timeout_ms, headReq, ipversion, interface); + internetSate = checkCurlResponse(endpoints, timeout_ms, headReq, ipversion, std::move(interface)); } static bool curlVerboseEnabled() { @@ -655,7 +655,7 @@ namespace WPEFramework NMLOG_INFO("notifying internet state %s", getInternetStateString(newInternetState)); Exchange::INetworkManager::InternetStatus newState = newInternetState; string defaultIface = _instance->getDefaultInterface(); - _instance->ReportInternetStatusChange(oldState, newState, defaultIface); + _instance->ReportInternetStatusChange(oldState, newState, std::move(defaultIface)); m_InternetState = newInternetState; oldState = newState; // 'm_InternetState' not exactly previous state, it may change to unknow when interface changed } @@ -745,7 +745,7 @@ namespace WPEFramework if(m_InternetState != INTERNET_FULLY_CONNECTED) { TestConnectivity testInternet(m_endpoint(), NMCONNECTIVITY_CURL_REQUEST_TIMEOUT_MS, - NMCONNECTIVITY_CURL_HEAD_REQUEST, 2, defaultIface); // check both IP versions + NMCONNECTIVITY_CURL_HEAD_REQUEST, 2, std::move(defaultIface)); // check both IP versions currentInternetState = testInternet.getInternetState(); if (currentInternetState == INTERNET_CAPTIVE_PORTAL) // if captive portal found copy the URL From 924ec6a3f61ce718c4f9f10709225429e7af3e02 Mon Sep 17 00:00:00 2001 From: rdkdevpilot Date: Mon, 14 Sep 2026 07:52:25 +0530 Subject: [PATCH 3/7] Fix COPY_INSTEAD_OF_MOVE in NetworkManagerGnomeProxy.cpp Defect ID: 1e106169-87f4-4203-af75-934ba8a7968e --- plugin/gnome/NetworkManagerGnomeProxy.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plugin/gnome/NetworkManagerGnomeProxy.cpp b/plugin/gnome/NetworkManagerGnomeProxy.cpp index 7c877f5fe..f27ea0ce2 100644 --- a/plugin/gnome/NetworkManagerGnomeProxy.cpp +++ b/plugin/gnome/NetworkManagerGnomeProxy.cpp @@ -367,7 +367,7 @@ namespace WPEFramework interface.enabled = GnomeNetworkManagerEvents::isInterfaceStateEnabled(info.state); interface.connected = GnomeNetworkManagerEvents::isInterfaceStateConnected(info.state); - interfaceList.push_back(interface); + interfaceList.push_back(std::move(interface)); } using Implementation = RPC::IteratorType; @@ -592,7 +592,7 @@ namespace WPEFramework sleep(1); // wait for 1 sec to change the device state const string lastConnectedSSID = getLastConnectedSSID(); NMLOG_INFO("Activating connection '%s' ...", lastConnectedSSID.c_str()); - wifi->activateKnownConnection(nmUtils::wlanIface(), lastConnectedSSID); + wifi->activateKnownConnection(nmUtils::wlanIface(), std::move(lastConnectedSSID)); } } @@ -666,7 +666,7 @@ namespace WPEFramework { NMLOG_DEBUG("no %s address on %s", family.c_str(), interface.c_str()); } - result.ipversion = family; + result.ipversion = std::move(family); return Core::ERROR_NONE; } @@ -741,7 +741,7 @@ namespace WPEFramework m_filterSsidslist.clear(); m_filterFrequencies.clear(); m_filterSsidslist = filteredSsids; - m_filterFrequencies = filteredFrequencies; + m_filterFrequencies = std::move(filteredFrequencies); m_filterVectorsLock.Unlock(); nmEvent->setwifiScanOptions(true); From 5665a15a2c9779668bd47f9a7bbc6d55244d9133 Mon Sep 17 00:00:00 2001 From: rdkdevpilot Date: Mon, 14 Sep 2026 07:52:26 +0530 Subject: [PATCH 4/7] Fix COPY_INSTEAD_OF_MOVE in NetworkManagerGdbusUtils.cpp Defect ID: 109513fb-c379-45ab-bf2a-7836ca582019 --- plugin/gnome/gdbus/NetworkManagerGdbusUtils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin/gnome/gdbus/NetworkManagerGdbusUtils.cpp b/plugin/gnome/gdbus/NetworkManagerGdbusUtils.cpp index ad1659a96..106b1fc3d 100644 --- a/plugin/gnome/gdbus/NetworkManagerGdbusUtils.cpp +++ b/plugin/gnome/gdbus/NetworkManagerGdbusUtils.cpp @@ -752,7 +752,7 @@ namespace WPEFramework // Remove any whitespace, newlines, etc. line.erase(line.find_last_not_of("\r\n\t") + 1); line.erase(0, line.find_first_not_of("\r\n\t")); - hostname = line; + hostname = std::move(line); file.close(); NMLOG_INFO("Read persistent hostname: '%s'", hostname.c_str()); From 586fbf8aa2c58943e6d6e990f4a5d63772a237b4 Mon Sep 17 00:00:00 2001 From: rdkdevpilot Date: Mon, 14 Sep 2026 07:52:28 +0530 Subject: [PATCH 5/7] Fix COPY_INSTEAD_OF_MOVE in NetworkManagerGnomeEvents.cpp Defect ID: ef93233f-dbb8-4a26-a5ef-a8f453fbedce --- plugin/gnome/NetworkManagerGnomeEvents.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/plugin/gnome/NetworkManagerGnomeEvents.cpp b/plugin/gnome/NetworkManagerGnomeEvents.cpp index e2918b9c9..6beba49f2 100644 --- a/plugin/gnome/NetworkManagerGnomeEvents.cpp +++ b/plugin/gnome/NetworkManagerGnomeEvents.cpp @@ -111,7 +111,7 @@ namespace WPEFramework return; // if not good don't report the evnet } - GnomeNetworkManagerEvents::onActiveInterfaceChangeCb(newIface); + GnomeNetworkManagerEvents::onActiveInterfaceChangeCb(std::move(newIface)); } else { @@ -187,7 +187,7 @@ namespace WPEFramework uint32_t prefix = nm_ip_address_get_prefix(addr); if (isIPv6) { if (isIPv6LinkLocal(addrString)) { - newCache.linkLocalAddresses.insert(addrString); + newCache.linkLocalAddresses.insert(std::move(addrString)); } else if (isIPv6ULA(addrString)) { newCache.uniqueLocalAddresses.insert(addrString); } else { @@ -406,7 +406,7 @@ namespace WPEFramework case NM_DEVICE_STATE_UNAVAILABLE: case NM_DEVICE_STATE_DISCONNECTED: wifiState = "WIFI_STATE_DISCONNECTED"; - GnomeNetworkManagerEvents::onWIFIStateChanged(Exchange::INetworkManager::WIFI_STATE_DISCONNECTED, attemptingSSID); + GnomeNetworkManagerEvents::onWIFIStateChanged(Exchange::INetworkManager::WIFI_STATE_DISCONNECTED, std::move(attemptingSSID)); refreshIpFamilyCache(device, false); refreshIpFamilyCache(device, true); GnomeNetworkManagerEvents::onInterfaceStateChangeCb(Exchange::INetworkManager::INTERFACE_LINK_DOWN, nmUtils::wlanIface()); @@ -646,7 +646,7 @@ namespace WPEFramework if (_instance) { for (const char* family : {"IPv4", "IPv6"}) { IpFamilyCache empty; - std::set oldKeys = _instance->swapIpCache(ifname, family, empty); + std::set oldKeys = _instance->swapIpCache(ifname, family, std::move(empty)); for (const auto& key : oldKeys) { _instance->ReportIPAddressChange(ifname, family, key, Exchange::INetworkManager::IP_LOST); } @@ -967,14 +967,14 @@ namespace WPEFramework NMLOG_DEBUG("%s interface state changed - %s", iface.c_str(), state.c_str()); if(_instance != nullptr && (iface == nmUtils::wlanIface() || iface == nmUtils::ethIface())) - _instance->ReportInterfaceStateChange(static_cast(newState), iface); + _instance->ReportInterfaceStateChange(static_cast(newState), std::move(iface)); } void GnomeNetworkManagerEvents::onWIFIStateChanged(uint8_t state, std::string ssid) { if(_instance != nullptr) { - _instance->ReportWiFiStateChange(static_cast(state), ssid); + _instance->ReportWiFiStateChange(static_cast(state), std::move(ssid)); #ifdef ENABLE_MIGRATION_MFRMGR_SUPPORT // Handle WiFi state changes for MfrMgr integration NetworkManagerMfrManager* mfrManager = NetworkManagerMfrManager::getInstance(); From bd73a161777e53944348f4a032a77fd68fa0de8f Mon Sep 17 00:00:00 2001 From: rdkdevpilot Date: Mon, 14 Sep 2026 07:52:30 +0530 Subject: [PATCH 6/7] Fix COPY_INSTEAD_OF_MOVE in NetworkManagerStunClient.cpp Defect ID: fc25794f-feee-47cf-b831-6ec1415d2181 --- plugin/NetworkManagerStunClient.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin/NetworkManagerStunClient.cpp b/plugin/NetworkManagerStunClient.cpp index 65eaa8c12..1bba9462a 100644 --- a/plugin/NetworkManagerStunClient.cpp +++ b/plugin/NetworkManagerStunClient.cpp @@ -214,7 +214,7 @@ namespace details { if (addr->ai_family != protocol_family) continue; - std::string const s = sockaddr_to_string2(addr->ai_addr, addr->ai_family); + std::string s = sockaddr_to_string2(addr->ai_addr, addr->ai_family); if (already_seen.find(s) == std::end(already_seen)) { struct sockaddr_storage temp = {}; @@ -230,7 +230,7 @@ namespace details { } addrs.push_back(temp); - already_seen.insert(s); + already_seen.insert(std::move(s)); } } From 2338935e376334d03bf189ee65fed5fa5d1a5eb5 Mon Sep 17 00:00:00 2001 From: gururaajar Date: Mon, 26 Oct 2026 13:03:27 -0400 Subject: [PATCH 7/7] Addressed review comments --- plugin/gnome/NetworkManagerGnomeProxy.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin/gnome/NetworkManagerGnomeProxy.cpp b/plugin/gnome/NetworkManagerGnomeProxy.cpp index f27ea0ce2..461502c5c 100644 --- a/plugin/gnome/NetworkManagerGnomeProxy.cpp +++ b/plugin/gnome/NetworkManagerGnomeProxy.cpp @@ -590,7 +590,7 @@ namespace WPEFramework if(enabled && interface == nmUtils::wlanIface() && _instance != NULL) { sleep(1); // wait for 1 sec to change the device state - const string lastConnectedSSID = getLastConnectedSSID(); + string lastConnectedSSID = getLastConnectedSSID(); NMLOG_INFO("Activating connection '%s' ...", lastConnectedSSID.c_str()); wifi->activateKnownConnection(nmUtils::wlanIface(), std::move(lastConnectedSSID)); }