diff --git a/.github/workflows/native-build.yml b/.github/workflows/native-build.yml index 0a7b37787..2c3396558 100644 --- a/.github/workflows/native-build.yml +++ b/.github/workflows/native-build.yml @@ -32,5 +32,3 @@ jobs: # Build component chmod +x build_tools_workflows/cov_docker_script/build_native.sh ./build_tools_workflows/cov_docker_script/build_native.sh ./cov_docker_script/component_config.json "$(pwd)" - env: - GITHUB_TOKEN: ${{ secrets.RDKCM_RDKE }} diff --git a/CHANGELOG.md b/CHANGELOG.md index 5cb9be4a6..087e6b082 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,85 +4,25 @@ All notable changes to this project will be documented in this file. Dates are d Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). -#### [2.8.0](https://github.com/rdkcentral/common-library/compare/2.7.0...2.8.0) - -- Merge tag '2.7.0' into develop [`e107982`](https://github.com/rdkcentral/common-library/commit/e10798212e7e8a46406301d333c5641b99356550) - -#### [2.7.0](https://github.com/rdkcentral/common-library/compare/2.6.1...2.7.0) - -> 21 August 2026 +#### 2.9.0 +- RDKB-67262: Remove Github token from Native build [`#136`](https://github.com/rdkcentral/common-library/pull/136) +- RDKB-67047: Apply null pointer safeguards in is_ValidIpAddressv6_port() [`#135`](https://github.com/rdkcentral/common-library/pull/135) - RDKB-63950 : update aker.service to support chronyd [`#128`](https://github.com/rdkcentral/common-library/pull/128) - RDKCOM-5595: RDKBDEV-3450 The CM is not updated with DNS Name (Option15), instead utopia.net is displayed in LAN side provisioning. [`#117`](https://github.com/rdkcentral/common-library/pull/117) - RDKB-64747: CcspPandM component is crashing on Device.Time.Status subscription [`#126`](https://github.com/rdkcentral/common-library/pull/126) -- Add changelog for release 2.7.0 [`cd643ed`](https://github.com/rdkcentral/common-library/commit/cd643ede29741566696f3c85b6388ae75ed90eb4) -- Merge tag '2.6.1' into develop [`262fd12`](https://github.com/rdkcentral/common-library/commit/262fd12cd8bbef46fcd472c734a79d5597bb94a4) - -#### [2.6.1](https://github.com/rdkcentral/common-library/compare/2.6.0...2.6.1) - -> 22 July 2026 - - RDKCOM-5604: RDKBDEV-3456, RDKBACCL-1777 Set systemd 'SyslogIdentifier' parameter [`#65`](https://github.com/rdkcentral/common-library/pull/65) - RDKB-66032 : Add PR Format Check workflow [`#121`](https://github.com/rdkcentral/common-library/pull/121) -- Add changelog for release 2.6.1 [`ece37d6`](https://github.com/rdkcentral/common-library/commit/ece37d60894a25c9320ea473a2306ad27898808f) -- Merge tag '2.6.0' into develop [`3505a0d`](https://github.com/rdkcentral/common-library/commit/3505a0d848d2d18e43693c9fc026ede5657b8f16) - -#### [2.6.0](https://github.com/rdkcentral/common-library/compare/2.5.0...2.6.0) - -> 8 July 2026 - - RDKB-65870: Fix memory leak in dmcli get call [`#118`](https://github.com/rdkcentral/common-library/pull/118) - RDKCOM-5547: RDKBNETWOR-84 DSLite feature integration with WanManager (Wg network… [`#52`](https://github.com/rdkcentral/common-library/pull/52) -- Add changelog for release 2.6.0 [`3ac512b`](https://github.com/rdkcentral/common-library/commit/3ac512bd9ca7443485143936c0e8b0123fa2cfde) -- Merge tag '2.5.0' into develop [`897530c`](https://github.com/rdkcentral/common-library/commit/897530c6208ee0f931ffc08c8c1d589bdd015bc2) - -#### [2.5.0](https://github.com/rdkcentral/common-library/compare/2.4.0...2.5.0) - -> 3 June 2026 - - RDKB-62884 : Reduce Repetitive Logging in Notify Component [`#113`](https://github.com/rdkcentral/common-library/pull/113) -- Add changelog for release 2.5.0 [`0a1639e`](https://github.com/rdkcentral/common-library/commit/0a1639e769b4bb355318076242f6b9348c1c8739) -- Merge tag '2.4.0' into develop [`9b5a002`](https://github.com/rdkcentral/common-library/commit/9b5a002eebbc088c8ad7fd83a7aa346f37e2e930) - -#### [2.4.0](https://github.com/rdkcentral/common-library/compare/2.3.0...2.4.0) - -> 7 May 2026 - - RDKCOM-5549: RDKBDEV-3393: CDRouter-TR69 HTTP GetParameterValues for the whole datamodel list Device. leads to TR69 crash in CM. [`#97`](https://github.com/rdkcentral/common-library/pull/97) - RDKB-64592: Coverity issues in ccsp-common-library component [`#109`](https://github.com/rdkcentral/common-library/pull/109) - RDKB-64593 : Coverity issues in ccsp-common-library phase 2 [`#110`](https://github.com/rdkcentral/common-library/pull/110) -- Add changelog for release 2.4.0 [`2426189`](https://github.com/rdkcentral/common-library/commit/242618966d742117d5e0dbdabfba5c666f92bb12) -- Merge tag '2.3.0' into develop [`84f2d8f`](https://github.com/rdkcentral/common-library/commit/84f2d8fef9dc5c4edde5301120e1c1d2c9394207) - -#### [2.3.0](https://github.com/rdkcentral/common-library/compare/2.2.1...2.3.0) - -> 1 April 2026 - - RDKCOM-5505: RDKBDEV-3354 IPQ: Bug fixes for QCOM Platform [`#58`](https://github.com/rdkcentral/common-library/pull/58) -- Add changelog for release 2.3.0 [`7dc7437`](https://github.com/rdkcentral/common-library/commit/7dc7437b2d07393f84490e689efed075096f8928) -- Merge tag '2.2.1' into develop [`447f4f5`](https://github.com/rdkcentral/common-library/commit/447f4f565f70ff8202acaca69280439d51d4569a) - -#### [2.2.1](https://github.com/rdkcentral/common-library/compare/2.2.0...2.2.1) - -> 23 March 2026 - - RDKB-63303, RDKB-63414 : Move RdkLogger Scripts to Cron [`#95`](https://github.com/rdkcentral/common-library/pull/95) -- Add changelog for release 2.2.1 [`45833f2`](https://github.com/rdkcentral/common-library/commit/45833f20e749b35d87c07800f78f2d0a82a25e8c) -- Merge tag '2.2.0' into develop [`f806cff`](https://github.com/rdkcentral/common-library/commit/f806cff729c54afdbc31d6e357edf249a04cda17) - -#### [2.2.0](https://github.com/rdkcentral/common-library/compare/2.1.1...2.2.0) - -> 4 March 2026 - - RDKB-63270 Test migration from non dhcp-manager to dhcp manager scena… [`#87`](https://github.com/rdkcentral/common-library/pull/87) - RDKBNETWOR-74: Implement MAPE Support in DHCP Manager [`#18`](https://github.com/rdkcentral/common-library/pull/18) -- Add changelog for release 2.2.0 [`8d1cc69`](https://github.com/rdkcentral/common-library/commit/8d1cc694e85412217861d42171c5c80027c8cd23) -- Merge tag '2.1.1' into develop [`1410e7e`](https://github.com/rdkcentral/common-library/commit/1410e7e958a4ac638a9ce07e82b0b2c8366d0f6c) - -#### [2.1.1](https://github.com/rdkcentral/common-library/compare/2.1.0...2.1.1) - -> 18 February 2026 - - RDKCOM-5499: RDKBDEV-3341 Fix sometimes PAM crash when set some DMs in provision [`#70`](https://github.com/rdkcentral/common-library/pull/70) - RDKB-62812:initialize DHCP for Voice interface [`#88`](https://github.com/rdkcentral/common-library/pull/88) - RDKCOM-5513: RDKBDEV-3344 Fix sometimes PAM crash when do TR069 get full tree calling DslhCpecoRegisterDataModelInternal [`#79`](https://github.com/rdkcentral/common-library/pull/79) @@ -90,104 +30,37 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog). - RDKCOM-5500: RDKBDEV-3348 Fix TR069 crash during reboot longrun [`#73`](https://github.com/rdkcentral/common-library/pull/73) - RDKB-62974 RDKB-62976: Native build for Coverity - Use Git Submodule [`#85`](https://github.com/rdkcentral/common-library/pull/85) - RDKCOM-5512: RDKBDEV-3362 Fix sometimes PAM crash when TR069 get full tree calling DslhCwmpCleanParamValue [`#80`](https://github.com/rdkcentral/common-library/pull/80) -- Add changelog for release 2.1.1 [`f78167d`](https://github.com/rdkcentral/common-library/commit/f78167de7dbad92b4e34ad98f7cad9f460a9c72f) -- Merge tag '2.1.0' into develop [`8f91e9e`](https://github.com/rdkcentral/common-library/commit/8f91e9e52c9bec3a15be016d6115e0c6af217e18) - -#### [2.1.0](https://github.com/rdkcentral/common-library/compare/2.0.0...2.1.0) - -> 4 February 2026 - - RDKCOM-5493: RDKBDEV-3340 Fix sometimes TR069 crash when do tr069 fw upgrade longrun [`#69`](https://github.com/rdkcentral/common-library/pull/69) - RDKB-62974 RDKB-62976: Native build for Coverity - Updating Code [`#78`](https://github.com/rdkcentral/common-library/pull/78) - RDKB-62974 RDKB-62976: Native build for Coverity - Updating code [`#76`](https://github.com/rdkcentral/common-library/pull/76) - RDKB-62974 RDKB-62976: Native build for Coverity - Updating code [`#75`](https://github.com/rdkcentral/common-library/pull/75) - RDKCOM-5498: RDKBDEV-3347 Fix sometimes processes will crash when getting dynamic nodes [`#72`](https://github.com/rdkcentral/common-library/pull/72) - RDKB-62974 RDKB-62976: Native build for Coverity [`#61`](https://github.com/rdkcentral/common-library/pull/61) -- Add changelog for release 2.1.0 [`8dec472`](https://github.com/rdkcentral/common-library/commit/8dec4722ee0749bf8f5cfe5c57010bc8baa05113) -- Merge tag '2.0.0' into develop [`d87bcc6`](https://github.com/rdkcentral/common-library/commit/d87bcc6dd396bb0210924d0e244644561c23cc91) - -### [2.0.0](https://github.com/rdkcentral/common-library/compare/1.4.1...2.0.0) - -> 7 January 2026 - - RDKB-62701, RDKB-62102: Medium impact Coverity bugs - ccsp-common-library [`#57`](https://github.com/rdkcentral/common-library/pull/57) - RDKB-62102, RDKB-62700: Coverity issues for the ccsp-common-library [Medium 1] [`#56`](https://github.com/rdkcentral/common-library/pull/56) - RDKB-62102, RDKB-61923: High impact Coverity bugs - ccsp-common-library-1 [`#48`](https://github.com/rdkcentral/common-library/pull/48) - RDKCOM-5474: RDKBDEV-3316 Add CcspCommonLibrary Documentation [`#47`](https://github.com/rdkcentral/common-library/pull/47) -- Add changelog for release 2.0.0 [`255d234`](https://github.com/rdkcentral/common-library/commit/255d2341b7d2c9517232aec1ac66974dfae29283) -- Merge tag '1.4.1' into develop [`ed63ca2`](https://github.com/rdkcentral/common-library/commit/ed63ca272577036e5fa8e59703878731512c7068) - -#### [1.4.1](https://github.com/rdkcentral/common-library/compare/1.4.0...1.4.1) - -> 17 December 2025 - - RDKCOM-5471: RDKBDEV-3302 Bringup of IPQ Platforms [`#25`](https://github.com/rdkcentral/common-library/pull/25) - RDKB-62302, RDKB-62690, RDKB-62687, RDKB-62732: Dibbler server and GUI issues [`#55`](https://github.com/rdkcentral/common-library/pull/55) - RDKB-62527: [XB9][8.3p1s1] - CcspPandMSsp core files are seen. [`#49`](https://github.com/rdkcentral/common-library/pull/49) -- Add changelog for release 1.4.1 [`9905018`](https://github.com/rdkcentral/common-library/commit/9905018654982ad3e3244252727d348e0db9b38a) -- Merge tag '1.4.0' into develop [`57dc583`](https://github.com/rdkcentral/common-library/commit/57dc5832ef288bcf1bf2234d395a3ad5fee44d7d) - -#### [1.4.0](https://github.com/rdkcentral/common-library/compare/1.3.1...1.4.0) - -> 4 December 2025 - - RDKB-62302, RDKB-62102: [Coverity] High impact Coverity bugs - ccsp-common-library [`#39`](https://github.com/rdkcentral/common-library/pull/39) - Coverity cleanup - LOCK_EVASION and MISSING LOCK [`#28`](https://github.com/rdkcentral/common-library/pull/28) - RDKB-60436 : PSM Migration Handling for Project Ignite Use Cases. [`#31`](https://github.com/rdkcentral/common-library/pull/31) -- Add changelog for release 1.4.0 [`b738574`](https://github.com/rdkcentral/common-library/commit/b7385746401a906fb42a48e377a2b73ed98718b9) -- Merge tag '1.3.1' into develop [`d048884`](https://github.com/rdkcentral/common-library/commit/d0488842bc96f4176dd628515382f792d3c710ea) -- Update systemd_units/scripts/migration_for_psm.sh [`a5251ce`](https://github.com/rdkcentral/common-library/commit/a5251ce26a544aaf9748a909fd960da5ac26b98f) - -#### [1.3.1](https://github.com/rdkcentral/common-library/compare/1.3.0...1.3.1) - -> 20 November 2025 - - XB9-668 : Upstream xb9 specific changes to github repo [`#40`](https://github.com/rdkcentral/common-library/pull/40) -- Add changelog for release [`1af9afa`](https://github.com/rdkcentral/common-library/commit/1af9afa4ddc9882880a6881e2c5f7a3568918ed1) -- Merge tag '1.3.0' into develop [`d88b3f5`](https://github.com/rdkcentral/common-library/commit/d88b3f54fd1b2895134d39373d97a957bbe2ba5d) - -#### [1.3.0](https://github.com/rdkcentral/common-library/compare/1.2.0...1.3.0) - -> 6 November 2025 - - Integrating AppArmor and profiles [`#38`](https://github.com/rdkcentral/common-library/pull/38) - LTE-2696 : Fix the warning treated as error [`#32`](https://github.com/rdkcentral/common-library/pull/32) -- Add changelog for release [`908d8d8`](https://github.com/rdkcentral/common-library/commit/908d8d8bd057a6a8b13bc9454b6447ed712cfe4a) -- Modify ExecStart and ExecStopPost commands [`c13a9ef`](https://github.com/rdkcentral/common-library/commit/c13a9efdbcbc88e510162500539ff8cbdc08157d) -- Update ExecStopPost log message format [`8353e93`](https://github.com/rdkcentral/common-library/commit/8353e93c9d16c03c3f4020fd19a18d12174c77e3) - -#### [1.2.0](https://github.com/rdkcentral/common-library/compare/1.1.0...1.2.0) - -> 23 October 2025 - - RDKB-61594: [ccsp-common-library] Code development to remove macro [`#29`](https://github.com/rdkcentral/common-library/pull/29) - RDKB-61711: Limit threads stack sizes to 4M [`#19`](https://github.com/rdkcentral/common-library/pull/19) - Update CODEOWNERS [`#27`](https://github.com/rdkcentral/common-library/pull/27) - Deploy fossid_integration_stateless_diffscan_target_repo action [`#24`](https://github.com/rdkcentral/common-library/pull/24) - Deploy cla action [`#21`](https://github.com/rdkcentral/common-library/pull/21) - Update CODEOWNERS [`#20`](https://github.com/rdkcentral/common-library/pull/20) -- Add changelog for release [`5287016`](https://github.com/rdkcentral/common-library/commit/5287016eec24e1b909ab83734c23a7d0f8c367b1) -- RDKB-61711: OneWiFi: Limit stacks sizes to 4M [`4e76a76`](https://github.com/rdkcentral/common-library/commit/4e76a769ecc878c08c4e4d3f2f069b6fb48912dc) -- Merge tag '1.1.0' into develop [`9ce1fa8`](https://github.com/rdkcentral/common-library/commit/9ce1fa85d0d575d62317947953b27ff71f870d62) - -#### [1.1.0](https://github.com/rdkcentral/common-library/compare/1.0.0...1.1.0) - -> 26 August 2025 - - RDKB-58648 TCXB7-6946: Observing snmp_subagent crash with fingerprin… [`#14`](https://github.com/rdkcentral/common-library/pull/14) - RDKB-58521 : WAN Manager Telemetry Markers 2.0 - Phase 1 [`#12`](https://github.com/rdkcentral/common-library/pull/12) - RDKCOM-5360: RDKBNETWOR-3 DHCPManager implementation [`#10`](https://github.com/rdkcentral/common-library/pull/10) - RDKCOM-5324: RDKBDEV-3179: fix build for older toolchains [`#8`](https://github.com/rdkcentral/common-library/pull/8) - RDKB-60486: Fix the dmcli crash when returned parameterName or Value is NULL [`#6`](https://github.com/rdkcentral/common-library/pull/6) -- RDKB-58648 TCXB7-6946: Observing snmp_subagent crash with fingerprint:[66870222] [`2dbaa72`](https://github.com/rdkcentral/common-library/commit/2dbaa72cf89038603789fe46e580f12b4471b3ff) -- Update ccsp_base_api.c [`3c5416a`](https://github.com/rdkcentral/common-library/commit/3c5416a1505876fdb5cce2efd42bddbacbe41417) -- Update CHANGELOG.md [`0e0cfdc`](https://github.com/rdkcentral/common-library/commit/0e0cfdca8f231204ff79599deda5e7f2eb58200a) - -#### 1.0.0 - -> 31 July 2025 - - Deploy L1-tests action [`#1`](https://github.com/rdkcentral/common-library/pull/1) - Import of source (stable2) [`1376928`](https://github.com/rdkcentral/common-library/commit/1376928df974e9dc8eb2a311371ddda794f124f4) -- Deploy cla action [`f52ee28`](https://github.com/rdkcentral/common-library/commit/f52ee2865225f9b691d19dc1eda0f6b1e047d3ff) -- Update CHANGELOG.md [`9bf2ce2`](https://github.com/rdkcentral/common-library/commit/9bf2ce2e4c9092403abc74d7337fa66554daf1b7) +- Update systemd_units/scripts/migration_for_psm.sh [`a5251ce`](https://github.com/rdkcentral/common-library/commit/a5251ce26a544aaf9748a909fd960da5ac26b98f) +- RDKB-58648 TCXB7-6946: Observing snmp_subagent crash with fingerprint:[66870222] [`2dbaa72`](https://github.com/rdkcentral/common-library/commit/2dbaa72cf89038603789fe46e580f12b4471b3ff) diff --git a/source/util_api/ansc/AnscStringUtil/ansc_string_util.c b/source/util_api/ansc/AnscStringUtil/ansc_string_util.c index 5f36ef98f..907c918bc 100644 --- a/source/util_api/ansc/AnscStringUtil/ansc_string_util.c +++ b/source/util_api/ansc/AnscStringUtil/ansc_string_util.c @@ -498,9 +498,29 @@ BOOL is_ValidIpAddressv6_port(PUCHAR pString) return FALSE; char *hostcpy = strdup((const char*)pString); char *hostdup = strdup((const char*)pString); + if ((!hostcpy) || (!hostdup)) + { + free(hostcpy); + free(hostdup); + return FALSE; + } char* ipv6 = strtok(hostcpy,"]"); ipv6 = strtok(ipv6,"["); + /* ipv6 can be NULL if hostcpy did not contain a valid "[...]" token */ + if (!ipv6) + { + free(hostcpy); + free(hostdup); + return FALSE; + } char *port_ptr = strchr(hostdup,']'); + /* port_ptr can be NULL if hostdup does not contain ']' */ + if (!port_ptr) + { + free(hostcpy); + free(hostdup); + return FALSE; + } if(port_ptr[1]) { if((port_ptr[1]==':') && (isdigit(port_ptr[2]))) @@ -509,16 +529,16 @@ BOOL is_ValidIpAddressv6_port(PUCHAR pString) port_ptr = strtok(NULL,":"); } else - { - /* CID 252351, 252353 fix */ - free(hostcpy); - free(hostdup); + { + /* CID 252351, 252353 fix */ + free(hostcpy); + free(hostdup); return FALSE; - } + } } if(is_Ipv6_address((PUCHAR)ipv6)) { - if(port_ptr[1]) + if(port_ptr && port_ptr[1]) { if(is_ValidPort((PUCHAR)port_ptr)) ret = TRUE;