Merge pull request #670 from rajbos/rajbos/fix-chat-leakage

Stabilize VS Code extension npm test runs

Author: rajbos

scripts/prepare-test-output.js

@@ -0,0 +1,12 @@
+const fs = require('fs');
+const path = require('path');
+
+const repoRoot = path.resolve(__dirname, '..');
+const extensionRoot = path.join(repoRoot, 'vscode-extension');
+const outDir = path.join(extensionRoot, 'out');
+const outTestDir = path.join(outDir, 'test');
+const packageJsonPath = path.join(extensionRoot, 'package.json');
+
+fs.mkdirSync(outTestDir, { recursive: true });
+fs.cpSync(packageJsonPath, path.join(outDir, 'package.json'), { force: true });
+fs.cpSync(packageJsonPath, path.join(outTestDir, 'package.json'), { force: true });

scripts/run-node-unit-tests.js

@@ -0,0 +1,42 @@
+const fs = require('fs');
+const path = require('path');
+const { spawnSync } = require('child_process');
+
+const repoRoot = path.resolve(__dirname, '..');
+const extensionRoot = path.join(repoRoot, 'vscode-extension');
+const outUnitDir = path.join(extensionRoot, 'out', 'test', 'unit');
+const shimPath = path.join(outUnitDir, 'vscode-shim-register.js');
+
+const testFiles = fs.readdirSync(outUnitDir)
+	.filter((name) => name.endsWith('.test.js'))
+	.sort((a, b) => a.localeCompare(b));
+
+for (const fileName of testFiles) {
+	const testFilePath = path.join(outUnitDir, fileName);
+	const result = spawnSync(
+		process.execPath,
+		['--require', shimPath, '--test', '--test-force-exit', testFilePath],
+		{
+			cwd: extensionRoot,
+			encoding: 'utf8',
+		},
+	);
+
+	if (result.status !== 0) {
+		if (result.stdout) {
+			process.stdout.write(result.stdout);
+		}
+
+		if (result.stderr) {
+			process.stderr.write(result.stderr);
+		}
+
+		process.exit(result.status ?? 1);
+	}
+
+	if (result.error) {
+		throw result.error;
+	}
+
+	process.stdout.write(`PASS ${fileName}\n`);
+}

vscode-extension/.npmrc

@@ -17,3 +17,7 @@ legacy-peer-deps=false
 # Save exact versions (no ^ or ~ prefixes) when adding new dependencies
 # This ensures maximum reproducibility
 save-exact=true
+
+# Disable npm progress UI/funding prompts for more stable non-interactive runs
+progress=false
+fund=false

vscode-extension/package.json

@@ -504,21 +504,22 @@
   },
   "scripts": {
     "vscode:prepublish": "npm run package",
-    "compile": "npm run check-types && npm run lint && node esbuild.js",
+    "compile": "tsc --noEmit && eslint src && node esbuild.js",
     "watch": "npm-run-all -p watch:*",
     "watch:esbuild": "node esbuild.js --watch",
     "watch:tsc": "tsc --noEmit --watch --project tsconfig.json",
-    "package": "npm run check-types && npm run lint && node esbuild.js --production",
-    "compile-tests": "node -e \"const fs = require('fs'); fs.mkdirSync('out/test', { recursive: true }); fs.cpSync('package.json', 'out/package.json', { force: true }); fs.cpSync('package.json', 'out/test/package.json', { force: true });\" && tsc -p tsconfig.tests.json",
+    "package": "tsc --noEmit && eslint src && node esbuild.js --production",
+    "prepare-test-output": "node ../scripts/prepare-test-output.js",
+    "compile-tests": "node ../scripts/prepare-test-output.js && tsc -p tsconfig.tests.json",
     "watch-tests": "tsc -p tsconfig.tests.json -w",
-    "pretest": "npm run compile && npm run compile-tests && npm run lint",
+    "pretest": "tsc --noEmit && eslint src && node esbuild.js && node ../scripts/prepare-test-output.js && tsc -p tsconfig.tests.json",
     "check-types": "tsc --noEmit",
     "lint": "eslint src",
     "lint:css": "stylelint \"src/webview/**/*.css\"",
     "lint:json": "node ../scripts/validate-json.js",
     "test": "vscode-test",
-    "test:node": "npm run compile-tests && node --require ./out/test/unit/vscode-shim-register.js --test --test-force-exit out/test/unit/*.test.js",
-    "test:coverage": "npm run compile-tests && node --require ./out/test/unit/vscode-shim-register.js --experimental-test-coverage --test --test-force-exit --test-coverage-lines=65 --test-coverage-functions=70 --test-coverage-branches=60 --test-coverage-include=out/src/backend/**/*.js --test-coverage-include=out/src/utils/**/*.js --test-coverage-include=out/src/usageAnalysis.js --test-coverage-include=out/src/tokenEstimation.js --test-coverage-include=out/src/maturityScoring.js out/test/unit/*.test.js",
+    "test:node": "node ../scripts/prepare-test-output.js && tsc -p tsconfig.tests.json && node ../scripts/run-node-unit-tests.js",
+    "test:coverage": "node ../scripts/prepare-test-output.js && tsc -p tsconfig.tests.json && node --require ./out/test/unit/vscode-shim-register.js --experimental-test-coverage --test --test-force-exit --test-coverage-lines=65 --test-coverage-functions=70 --test-coverage-branches=60 --test-coverage-include=out/src/backend/**/*.js --test-coverage-include=out/src/utils/**/*.js --test-coverage-include=out/src/usageAnalysis.js --test-coverage-include=out/src/tokenEstimation.js --test-coverage-include=out/src/maturityScoring.js out/test/unit/*.test.js",
     "test:coverage:ci": "node --require ./out/test/unit/vscode-shim-register.js --experimental-test-coverage --test --test-force-exit --test-coverage-include=out/src/backend/**/*.js --test-coverage-include=out/src/utils/**/*.js --test-coverage-include=out/src/usageAnalysis.js --test-coverage-include=out/src/tokenEstimation.js --test-coverage-include=out/src/maturityScoring.js out/test/unit/*.test.js",
     "test:mutation": "npm run compile-tests && npx stryker run",
     "pre-release": "node ../scripts/pre-release.js",