rework(lib): use camino_tempfile instead of tempfile

Author: radhermit

Cargo.lock

@@ -36,6 +36,7 @@ async-stream = "0.3.6"
 base64 = "0.22.1"
 byte-unit = { version = "5.2.5", features = ["serde"] }
 camino = { version = "1.2.5", features = ["serde1"] }
+camino-tempfile = "1.4.1"
 chrono = { version = "0.4.45", features = ["serde"] }
 chronoutil = "0.2.7"
 config = { version = "0.15.25", default-features = false, features = ["toml", "convert-case", "async"] }
@@ -53,7 +54,6 @@ serde_repr = "0.1.21"
 serde_with = { version = "3.22.0", default-features = false, features = ["alloc", "macros"] }
 strum = { version = "0.28.0", features = ["derive"] }
 tar = "0.4.46"
-tempfile = "3.27.0"
 thiserror = "2.0.20"
 tokio = { version = "1.53.1", features = ["full"] }
 toml = "1.1.4"

crates/lib/Cargo.toml

@@ -180,7 +180,7 @@ impl Config {
 mod tests {
     use std::{env, fs};
 
-    use tempfile::tempdir;
+    use camino_tempfile::tempdir;
 
     use crate::service::bugzilla::Bugzilla;
 
@@ -203,8 +203,7 @@ mod tests {
         assert!(service.config().auth.user.is_none());
 
         let dir = tempdir().unwrap();
-        let dir_path = dir.path().to_str().unwrap();
-        env::set_current_dir(dir_path).unwrap();
+        env::set_current_dir(dir.path()).unwrap();
 
         // create service files
         let service1 = indoc::indoc! {r#"
@@ -232,7 +231,7 @@ mod tests {
         assert!(config.services.len() == len + 1);
 
         // add new services from dir
-        config.load(dir_path).unwrap();
+        config.load(dir.path()).unwrap();
         assert!(config.services.len() == len + 2);
 
         // verify gentoo connection was overridden

crates/lib/src/config.rs

@@ -4,6 +4,7 @@ use std::{fmt, io, str};
 
 use byte_unit::Byte;
 use camino::{Utf8Path, Utf8PathBuf};
+use camino_tempfile::tempdir;
 use itertools::Itertools;
 use serde::Serialize;
 use serde_with::skip_serializing_none;
@@ -404,14 +405,12 @@ impl RequestSend for Request {
         };
 
         // create temporary directory used for creating transient attachment files
-        let temp_dir = tempfile::tempdir()
+        let temp_dir = tempdir()
             .map_err(|e| Error::InvalidValue(format!("failed acquiring temporary dir: {e}")))?;
-        let temp_dir_path = Utf8Path::from_path(temp_dir.path())
-            .ok_or_else(|| Error::InvalidValue("non-unicode temporary dir path".to_string()))?;
 
         let mut futures = vec![];
         for attachment in &self.attachments {
-            let attachment = attachment.build(&self.ids, temp_dir_path)?;
+            let attachment = attachment.build(&self.ids, temp_dir.path())?;
             futures.push(
                 self.service
                     .client()

crates/lib/src/service/bugzilla/attachment/create.rs

@@ -221,7 +221,7 @@ pub trait WebClient {
 mod tests {
     use std::env;
 
-    use tempfile::tempdir;
+    use camino_tempfile::tempdir;
 
     use crate::service::bugzilla::Bugzilla;
     use crate::test::*;
@@ -251,19 +251,18 @@ mod tests {
         let dir = tempdir().unwrap();
         env::set_current_dir(dir.path()).unwrap();
         let path = dir.path().join("dir/template");
-        let path_str = path.to_str().unwrap();
 
         let time = "1d".parse().unwrap();
         request1.created(time);
 
         // save to specific path
-        request1.save_template(path_str).unwrap();
+        request1.save_template(path.as_str()).unwrap();
         assert_eq!(
             fs::read_to_string(&path).unwrap().trim(),
             r#"created = "1d""#
         );
         assert_ne!(request1, request2);
-        request2.load_template(path_str).unwrap();
+        request2.load_template(path.as_str()).unwrap();
         assert_eq!(request1, request2);
 
         // unnamed services save to current working directory