rework(tests): allow ? usage in integration tests so errors are output

Author: radhermit

crates/cli/tests/bugzilla/attachment/create.rs

@@ -9,19 +9,18 @@ use crate::command::cmd;
 use super::SERVICE;
 
 #[tokio::test]
-async fn single_attachment_to_single_bug() {
+async fn single_attachment_to_single_bug() -> anyhow::Result<()> {
     let id = SERVICE
         .create()
         .summary("summary")
         .component("TestComponent")
         .product("TestProduct")
         .description("description")
         .send()
-        .await
-        .unwrap();
+        .await?;
 
-    let file = NamedUtf8TempFile::new().unwrap();
-    fs::write(&file, "test").unwrap();
+    let file = NamedUtf8TempFile::new()?;
+    fs::write(&file, "test")?;
     let path = file.path();
 
     cmd!("bite bugzilla attachment create {id} -v")
@@ -32,4 +31,6 @@ async fn single_attachment_to_single_bug() {
         )))
         .stderr("")
         .success();
+
+    Ok(())
 }

crates/cli/tests/bugzilla/create.rs

@@ -6,35 +6,35 @@ use crate::command::cmd;
 use super::SERVICE;
 
 #[tokio::test]
-async fn from_bug() {
+async fn from_bug() -> anyhow::Result<()> {
     let id = SERVICE
         .create()
         .summary("summary")
         .component("TestComponent")
         .product("TestProduct")
         .description("description")
         .send()
-        .await
-        .unwrap();
+        .await?;
 
     cmd!("bite bugzilla create --from-bug {id} -S summary -D description")
         .assert()
         .success();
+
+    Ok(())
 }
 
 #[tokio::test]
-async fn from_template() {
+async fn from_template() -> anyhow::Result<()> {
     let id = SERVICE
         .create()
         .summary("summary")
         .component("TestComponent")
         .product("TestProduct")
         .description("description")
         .send()
-        .await
-        .unwrap();
+        .await?;
 
-    let dir = tempdir().unwrap();
+    let dir = tempdir()?;
     let path = dir.path().join("template");
 
     // create template from bug
@@ -48,4 +48,6 @@ async fn from_template() {
     cmd!("bite bugzilla create --from {path} -S summary -D description")
         .assert()
         .success();
+
+    Ok(())
 }

crates/cli/tests/bugzilla/search.rs

@@ -6,20 +6,21 @@ use crate::command::cmd;
 use super::SERVICE;
 
 #[tokio::test]
-async fn id() {
+async fn id() -> anyhow::Result<()> {
     let id = SERVICE
         .create()
         .summary("summary")
         .component("TestComponent")
         .product("TestProduct")
         .description("description")
         .send()
-        .await
-        .unwrap();
+        .await?;
 
     cmd!("bite bugzilla search --id {id} --fields id")
         .assert()
         .stdout(predicate::eq(id.to_string()).trim())
         .stderr("")
         .success();
+
+    Ok(())
 }

crates/cli/tests/bugzilla/update.rs

@@ -7,16 +7,15 @@ use crate::command::cmd;
 use super::SERVICE;
 
 #[tokio::test]
-async fn from_template() {
+async fn from_template() -> anyhow::Result<()> {
     let id = SERVICE
         .create()
         .summary("summary")
         .component("TestComponent")
         .product("TestProduct")
         .description("description")
         .send()
-        .await
-        .unwrap();
+        .await?;
 
     let dir = tempdir().unwrap();
     let path = dir.path().join("template");
@@ -33,29 +32,23 @@ async fn from_template() {
         .assert()
         .success();
 
-    let bug = SERVICE
-        .get([id])
-        .send()
-        .await
-        .unwrap()
-        .into_iter()
-        .next()
-        .unwrap();
+    let bug = SERVICE.get([id]).send().await?.into_iter().next().unwrap();
 
     assert_eq!(bug.summary.unwrap(), "new-summary");
+
+    Ok(())
 }
 
 #[tokio::test]
-async fn multiple_bugs() {
+async fn multiple_bugs() -> anyhow::Result<()> {
     let id1 = SERVICE
         .create()
         .summary("summary")
         .component("TestComponent")
         .product("TestProduct")
         .description("description")
         .send()
-        .await
-        .unwrap();
+        .await?;
 
     let id2 = SERVICE
         .create()
@@ -64,8 +57,7 @@ async fn multiple_bugs() {
         .product("TestProduct")
         .description("description")
         .send()
-        .await
-        .unwrap();
+        .await?;
 
     cmd!("bite bugzilla update {id1} {id2} -S new-summary")
         .assert()
@@ -74,12 +66,13 @@ async fn multiple_bugs() {
     let (bug1, bug2) = SERVICE
         .get([id1, id2])
         .send()
-        .await
-        .unwrap()
+        .await?
         .into_iter()
         .collect_tuple()
         .unwrap();
 
     assert_eq!(bug1.summary.unwrap(), "new-summary");
     assert_eq!(bug2.summary.unwrap(), "new-summary");
+
+    Ok(())
 }