gh-145651: Add __repr__ to http.client.HTTPConnection and HTTPResponse

Author: JackDanger

Lib/http/client.py

@@ -294,6 +294,11 @@ def __init__(self, sock, debuglevel=0, method=None, url=None):
         self.length = _UNKNOWN          # number of bytes left in response
         self.will_close = _UNKNOWN      # conn will close at end of response
 
+    def __repr__(self):
+        if self.status is _UNKNOWN:
+            return '<%s>' % (self.__class__.__name__,)
+        return '<%s [%s %s]>' % (self.__class__.__name__, self.status, self.reason)
+
     def _read_status(self):
         line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
         if len(line) > _MAXLINE:
@@ -911,6 +916,9 @@ def __init__(self, host, port=None, timeout=socket._GLOBAL_DEFAULT_TIMEOUT,
         # tests to replace it with a suitable mockup
         self._create_connection = socket.create_connection
 
+    def __repr__(self):
+        return '<%s %s:%s>' % (self.__class__.__name__, self.host, self.port if self.port is not None else self.default_port)
+
     def set_tunnel(self, host, port=None, headers=None):
         """Set up host and port for HTTP CONNECT tunnelling.
 

Lib/test/test_httplib.py

@@ -2363,6 +2363,48 @@ def test_getting_header_defaultint(self):
         header = self.resp.getheader('No-Such-Header',default=42)
         self.assertEqual(header, 42)
 
+class ReprTest(TestCase):
+
+    def test_http_connection_repr_default_port(self):
+        conn = client.HTTPConnection('example.com')
+        self.assertEqual(repr(conn), '<HTTPConnection example.com:80>')
+
+    def test_http_connection_repr_explicit_port(self):
+        conn = client.HTTPConnection('example.com', 8080)
+        self.assertEqual(repr(conn), '<HTTPConnection example.com:8080>')
+
+    def test_https_connection_repr(self):
+        if not hasattr(client, 'HTTPSConnection'):
+            self.skipTest('ssl support required')
+        conn = client.HTTPSConnection('example.com')
+        self.assertEqual(repr(conn), '<HTTPSConnection example.com:443>')
+
+    def test_https_connection_repr_explicit_port(self):
+        if not hasattr(client, 'HTTPSConnection'):
+            self.skipTest('ssl support required')
+        conn = client.HTTPSConnection('example.com', 8443)
+        self.assertEqual(repr(conn), '<HTTPSConnection example.com:8443>')
+
+    def test_http_response_repr_before_read(self):
+        sock = FakeSocket(b'HTTP/1.1 200 OK\r\n\r\n')
+        resp = client.HTTPResponse(sock)
+        self.assertEqual(repr(resp), '<HTTPResponse>')
+
+    def test_http_response_repr_after_read(self):
+        body = b'HTTP/1.1 200 OK\r\nContent-Length: 0\r\n\r\n'
+        sock = FakeSocket(body)
+        resp = client.HTTPResponse(sock)
+        resp.begin()
+        self.assertEqual(repr(resp), '<HTTPResponse [200 OK]>')
+
+    def test_http_response_repr_not_found(self):
+        body = b'HTTP/1.1 404 Not Found\r\nContent-Length: 0\r\n\r\n'
+        sock = FakeSocket(body)
+        resp = client.HTTPResponse(sock)
+        resp.begin()
+        self.assertEqual(repr(resp), '<HTTPResponse [404 Not Found]>')
+
+
 class TunnelTests(TestCase):
     def setUp(self):
         response_text = (