address review: fix for format

skirpichev · skirpichev · commit c81588290489 · 2026-02-25T13:35:30.000+03:00
diff --git a/Modules/_struct.c b/Modules/_struct.c
@@ -1778,11 +1778,11 @@ s_init(PyStructObject *self, PyObject *format)
         Py_INCREF(format);
     }
     if (!PyBytes_Check(format)) {
-        Py_DECREF(format);
         PyErr_Format(PyExc_TypeError,
                      "Struct() argument 1 must be a str or bytes object, "
                      "not %T",
                      format);
+        Py_DECREF(format);
         return -1;
     }
     Py_SETREF(self->s_format, format);

Original file line number	Diff line number	Diff line change
`@@ -1778,11 +1778,11 @@ s_init(PyStructObject self, PyObject format)`
`1778`	`1778`	`Py_INCREF(format);`
`1779`	`1779`	`}`
`1780`	`1780`	`if (!PyBytes_Check(format)) {`
`1781`		`- Py_DECREF(format);`
`1782`	`1781`	`PyErr_Format(PyExc_TypeError,`
`1783`	`1782`	`"Struct() argument 1 must be a str or bytes object, "`
`1784`	`1783`	`"not %T",`
`1785`	`1784`	`format);`
	`1785`	`+ Py_DECREF(format);`
`1786`	`1786`	`return -1;`
`1787`	`1787`	`}`
`1788`	`1788`	`Py_SETREF(self->s_format, format);`