review comment

eendebakpt · eendebakpt · commit a2bcfdb409a5 · 2026-01-27T19:37:04.000+01:00
diff --git a/Objects/setobject.c b/Objects/setobject.c
@@ -3040,7 +3040,7 @@ PySet_Add(PyObject *anyset, PyObject *key)
         // this can be done without a lock.
         // Since another key is added to the set, we must track the frozenset
         // if needed.
-        if (PyFrozenSet_CheckExact(anyset) && PyObject_GC_IsTracked(key) && !PyObject_GC_IsTracked(anyset)) {
+        if (PyFrozenSet_CheckExact(anyset) && !PyObject_GC_IsTracked(anyset) && PyObject_GC_IsTracked(key)) {
             _PyObject_GC_TRACK(anyset);
         }
         return set_add_key((PySetObject *)anyset, key);

Original file line number	Diff line number	Diff line change
`@@ -3040,7 +3040,7 @@ PySet_Add(PyObject anyset, PyObject key)`
`3040`	`3040`	`// this can be done without a lock.`
`3041`	`3041`	`// Since another key is added to the set, we must track the frozenset`
`3042`	`3042`	`// if needed.`
`3043`		`- if (PyFrozenSet_CheckExact(anyset) && PyObject_GC_IsTracked(key) && !PyObject_GC_IsTracked(anyset)) {`
	`3043`	`+ if (PyFrozenSet_CheckExact(anyset) && !PyObject_GC_IsTracked(anyset) && PyObject_GC_IsTracked(key)) {`
`3044`	`3044`	`_PyObject_GC_TRACK(anyset);`
`3045`	`3045`	`}`
`3046`	`3046`	`return set_add_key((PySetObject *)anyset, key);`