Change create_only to exist_ok in OpenKeyEx

Author: aisk

Doc/library/winreg.rst

@@ -89,7 +89,7 @@ This module offers the following functions:
       See :ref:`above <exception-changed>`.
 
 
-.. function:: CreateKeyEx(key, sub_key, reserved=0, access=KEY_WRITE, *, options=0, create_only=False)
+.. function:: CreateKeyEx(key, sub_key, reserved=0, access=KEY_WRITE, *, options=0, exist_ok=True)
 
    Creates or opens the specified key, returning a
    :ref:`handle object <handle-object>`.
@@ -108,9 +108,9 @@ This module offers the following functions:
    *options* is an interger and can be zero or one of the predefined
    :ref:`REG_OPTION_* constants <hkey-constants>`.
 
-   *create_only* is a boolean.
-   When set to True, a :exc:`FileExistsError` will be raised
-   if the key is already exists.  Default is ``False``.
+   *exist_ok* is a boolean.
+   When set to False, a :exc:`FileExistsError` will be raised
+   if the key already exists.  Default is ``True``.
 
    If *key* is one of the predefined keys, *sub_key* may be ``None``. In that
    case, the handle returned is the same key handle passed in to the function.
@@ -130,7 +130,7 @@ This module offers the following functions:
       See :ref:`above <exception-changed>`.
 
    .. versionchanged:: 3.15
-      Added *options* and *create_only* parameters.
+      Added *options* and *exist_ok* parameters.
 
 
 .. function:: DeleteKey(key, sub_key)

Doc/whatsnew/3.15.rst

@@ -943,7 +943,7 @@ warnings
 winreg
 ------
 
-* Add *options* and *create_only* parameters to :func:`winreg.CreateKeyEx`.
+* Add *options* and *exist_ok* parameters to :func:`winreg.CreateKeyEx`.
   (Contributed by AN Long in :gh:`129903`.)
 
 * Add *options* parameter to :func:`winreg.OpenKeyEx`.

Include/internal/pycore_global_objects_fini_generated.h

@@ -392,7 +392,6 @@ struct _Py_global_strings {
         STRUCT_FOR_ID(coro)
         STRUCT_FOR_ID(count)
         STRUCT_FOR_ID(covariant)
-        STRUCT_FOR_ID(create_only)
         STRUCT_FOR_ID(ctx)
         STRUCT_FOR_ID(cwd)
         STRUCT_FOR_ID(d_parameter_type)
@@ -450,6 +449,7 @@ struct _Py_global_strings {
         STRUCT_FOR_ID(exc_value)
         STRUCT_FOR_ID(excepthook)
         STRUCT_FOR_ID(exception)
+        STRUCT_FOR_ID(exist_ok)
         STRUCT_FOR_ID(existing_file_name)
         STRUCT_FOR_ID(exit)
         STRUCT_FOR_ID(exp)

Include/internal/pycore_global_strings.h

@@ -289,7 +289,7 @@ def test_registry_works_with_options(self):
     def test_create_only(self):
         CreateKeyEx(HKEY_CURRENT_USER, test_key_name)
         with self.assertRaises(FileExistsError):
-            CreateKeyEx(HKEY_CURRENT_USER, test_key_name, create_only=True)
+            CreateKeyEx(HKEY_CURRENT_USER, test_key_name, exist_ok=False)
         DeleteKey(HKEY_CURRENT_USER, test_key_name)
 
     def test_named_arguments(self):

Include/internal/pycore_runtime_init_generated.h

@@ -1,2 +1,2 @@
-Add *options* and *create_only* parameters to :meth:`winreg.CreateKeyEx`.
+Add *options* and *exist_ok* parameters to :meth:`winreg.CreateKeyEx`.
 Add *options* parameter to :meth:`winreg.OpenKeyEx`.

Include/internal/pycore_unicodeobject_generated.h

@@ -923,9 +923,9 @@ winreg.CreateKeyEx -> HKEY
     *
     options: int = 0
         Can be one of the REG_OPTION_* constants.
-    create_only: bool = False
-        When set to True, raise FileExistsError if the key is already exists.
-        Default is False.
+    exist_ok: bool = True
+        When set to False, raise FileExistsError if the key already exists.
+        Default is True.
 
 Creates or opens the specified key.
 
@@ -941,8 +941,8 @@ If the function fails, an OSError exception is raised.
 static HKEY
 winreg_CreateKeyEx_impl(PyObject *module, HKEY key, const wchar_t *sub_key,
                         int reserved, REGSAM access, int options,
-                        int create_only)
-/*[clinic end generated code: output=10c0a5f7beea07e3 input=434f3dbac49bf638]*/
+                        int exist_ok)
+/*[clinic end generated code: output=e4f53b9dfdf9b0a8 input=98c63d6efec6fa3c]*/
 {
     HKEY retKey;
     long rc;
@@ -961,7 +961,7 @@ winreg_CreateKeyEx_impl(PyObject *module, HKEY key, const wchar_t *sub_key,
         PyErr_SetFromWindowsErrWithFunction(rc, "CreateKeyEx");
         return NULL;
     }
-    if (create_only) {
+    if (!exist_ok) {
         if (disposition == REG_OPENED_EXISTING_KEY) {
             PyErr_SetFromWindowsErrWithFunction(ERROR_ALREADY_EXISTS, "CreateKeyEx");
             if (retKey != key) {