Skip to content

Commit 4103816

Browse files
address review
1 parent 48ec270 commit 4103816

2 files changed

Lines changed: 2 additions & 11 deletions

File tree

Lib/test/test_opcache.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2060,21 +2060,12 @@ class Color(enum.IntEnum):
20602060
def load_enum_member():
20612061
for _ in range(_testinternalcapi.SPECIALIZATION_THRESHOLD):
20622062
x = Color.RED
2063-
self.assertEqual(x, 1)
2063+
assert x == 1
20642064

20652065
load_enum_member()
20662066
self.assert_specialized(load_enum_member,
20672067
"LOAD_ATTR_CLASS_WITH_METACLASS_CHECK")
20682068

2069-
def load_enum_value():
2070-
for _ in range(_testinternalcapi.SPECIALIZATION_THRESHOLD):
2071-
x = Color.RED.value + Color.GREEN.value
2072-
self.assertEqual(x, 3)
2073-
2074-
load_enum_value()
2075-
self.assert_specialized(load_enum_value,
2076-
"LOAD_ATTR_CLASS_WITH_METACLASS_CHECK")
2077-
20782069

20792070
if __name__ == "__main__":
20802071
unittest.main()

Python/specialize.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,7 @@ specialize_class_load_attr(PyObject *owner, _Py_CODEUNIT *instr,
12101210
return -1;
12111211
}
12121212
if (Py_TYPE(descr)->tp_descr_get || Py_TYPE(descr)->tp_descr_set) {
1213-
SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_MUTABLE_CLASS);
1213+
SPECIALIZATION_FAIL(LOAD_ATTR, SPEC_FAIL_ATTR_OVERRIDING_DESCRIPTOR);
12141214
Py_XDECREF(descr);
12151215
return -1;
12161216
}

0 commit comments

Comments
 (0)