Apply suggestions from code review

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>

Author: 3 people

Include/internal/pycore_tuple.h

@@ -26,8 +26,8 @@ extern PyStatus _PyTuple_InitGlobalObjects(PyInterpreterState *);
 PyAPI_FUNC(PyObject *)_PyTuple_FromStackRefStealOnSuccess(const union _PyStackRef *, Py_ssize_t);
 PyAPI_FUNC(PyObject *)_PyTuple_FromArraySteal(PyObject *const *, Py_ssize_t);
 
-PyAPI_FUNC(PyObject *)_PyTuple_FromPair(PyObject *, PyObject *);
-PyAPI_FUNC(PyObject *)_PyTuple_FromPairSteal(PyObject *, PyObject *);
+PyAPI_FUNC(PyObject *) _PyTuple_FromPair(PyObject *, PyObject *);
+PyAPI_FUNC(PyObject *) _PyTuple_FromPairSteal(PyObject *, PyObject *);
 
 typedef struct {
     PyObject_HEAD

Lib/test/test_capi/test_tuple.py

@@ -128,7 +128,7 @@ def test_tuple_from_pair(self):
         for name, ctor in ctors:
             with self.subTest(name):
                 self.assertEqual(type(ctor(1, 2)), tuple)
-                self.assertEqual(ctor(1, 2), (1, 2))
+                self.assertEqual(ctor(1, 145325), (1, 145325))
                 self.assertEqual(ctor(None, None), (None, None))
                 self.assertEqual(ctor(True, False), (True, False))
 

Modules/_testinternalcapi/tuple.c

@@ -35,9 +35,5 @@ static PyMethodDef test_methods[] = {
 int
 _PyTestInternalCapi_Init_Tuple(PyObject *m)
 {
-    if (PyModule_AddFunctions(m, test_methods) < 0) {
-        return -1;
-    }
-
-    return 0;
+    return PyModule_AddFunctions(m, test_methods);
 }

Objects/tupleobject.c

@@ -210,10 +210,11 @@ tuple_alloc_2(void)
     PyTupleObject *result = _Py_FREELIST_POP(PyTupleObject, tuples[index]);
     if (result == NULL) {
         result = PyObject_GC_NewVar(PyTupleObject, &PyTuple_Type, size);
+        if (result == NULL) {
+            return NULL;
+        }
     }
-    if (result != NULL) {
-        _PyTuple_RESET_HASH_CACHE(result);
-    }
+    _PyTuple_RESET_HASH_CACHE(result);
     return result;
 }