Merge pull request #1261 from rd4398/issue-1246

cleanup(bootstrapper): expose `DEFAULT_BG_THREADS` as public class constant

Author: LalatenduMohanty

src/fromager/bootstrapper/__init__.py

@@ -1,4 +1,3 @@
 from ._bootstrapper import Bootstrapper
-from ._types import _DEFAULT_BG_THREADS
 
-__all__ = ["_DEFAULT_BG_THREADS", "Bootstrapper"]
+__all__ = ["Bootstrapper"]

src/fromager/bootstrapper/_bootstrapper.py

@@ -20,6 +20,7 @@
     bootstrap_requirement_resolver,
     progress,
     sources,
+    threading_utils,
 )
 from ..dependency_graph import DependencyGraph
 from ..log import req_ctxvar_context, requirement_ctxvar
@@ -32,7 +33,6 @@
 from ._process_install_deps import ProcessInstallDeps
 from ._resolve import Resolve
 from ._types import (
-    _DEFAULT_BG_THREADS,
     FailureRecord,
     FailureType,
     SeenKey,
@@ -53,6 +53,8 @@ class Bootstrapper:
     the dependency tree, then ``finalize()`` for cleanup and exit code.
     """
 
+    DEFAULT_BG_THREADS: int = max(1, threading_utils.get_cpu_count() // 2)
+
     def __init__(
         self,
         ctx: context.WorkContext,
@@ -62,7 +64,7 @@ def __init__(
         sdist_only: bool = False,
         test_mode: bool = False,
         multiple_versions: bool = False,
-        num_bg_threads: int = _DEFAULT_BG_THREADS,
+        num_bg_threads: int = DEFAULT_BG_THREADS,
     ) -> None:
         if test_mode and sdist_only:
             raise ValueError(

src/fromager/bootstrapper/_types.py

@@ -8,16 +8,14 @@
 
 from packaging.utils import NormalizedName
 
-from .. import build_environment, threading_utils
+from .. import build_environment
 from ..requirements_file import SourceType
 
 logger = logging.getLogger(__name__)
 
 # package name, extras, version, sdist/wheel
 SeenKey = tuple[NormalizedName, tuple[str, ...], str, typing.Literal["sdist", "wheel"]]
 
-_DEFAULT_BG_THREADS: int = max(1, threading_utils.get_cpu_count() // 2)
-
 
 @dataclasses.dataclass
 class SourceBuildResult:

src/fromager/commands/bootstrap.py

@@ -20,6 +20,7 @@
     resolver,
     server,
 )
+from ..bootstrapper import Bootstrapper
 from .build import build_parallel
 from .graph import find_why, show_explain_duplicates
 
@@ -120,7 +121,7 @@ def _get_requirements_from_args(
     "--bg-threads",
     "num_bg_threads",
     type=click.IntRange(min=1),
-    default=bootstrapper._DEFAULT_BG_THREADS,
+    default=Bootstrapper.DEFAULT_BG_THREADS,
     show_default=True,
     help="Number of background threads for parallel I/O pre-fetching (min 1).",
 )
@@ -511,7 +512,7 @@ def write_constraints_file(
     "--bg-threads",
     "num_bg_threads",
     type=click.IntRange(min=1),
-    default=bootstrapper._DEFAULT_BG_THREADS,
+    default=Bootstrapper.DEFAULT_BG_THREADS,
     show_default=True,
     help="Number of background threads for parallel I/O pre-fetching (min 1).",
 )