Selenium notebook tests (#1311)

Author: Conengmo

.appveyor.yml

@@ -27,4 +27,4 @@ install:
 
 test_script:
   - pip install -e . --no-deps --force-reinstall
-  - pytest -n 2 -rxXs tests
+  - pytest -n 2 -rxXs tests --ignore=tests/selenium

.github/CONTRIBUTING.md

@@ -71,13 +71,13 @@ The basic workflow for contributing is:
    pip install -r requirements.txt
    pip install -r requirements-dev.txt
    ```
-6. Install Firefox, download [geckodriver](https://github.com/mozilla/geckodriver/releases) 
-   and put it in the PATH.
+6. Install Chrome, download [chromedriver](https://sites.google.com/a/chromium.org/chromedriver/) and put it in the PATH.
 7. Make changes to your local copy of the folium repository
 8. Make sure the tests pass:
    * in the repository folder do `pip install -e . --no-deps`  (needed for notebook tests)
-   * run `python -m pytest tests`
    * run `flake8 folium --max-line-length=120`
+   * run `python -m pytest tests --ignore=tests/selenium`
+   * run `python -m pytest tests/selenium`
    * resolve all errors
 9. Commit those changes
    ```

.gitignore

@@ -14,6 +14,11 @@ examples/results/*
 /_mac/*.xml
 /inspection/*.xml
 geckodriver.log
+geckodriver.exe
 geckodriver.tar.gz
 geckodriver/
+chromedriver.exe
+chromedriver/
 miniconda.sh
+latest_logs/
+*.nbconvert.ipynb

.travis.yml

@@ -7,6 +7,7 @@ env:
 
 addons:
   firefox: latest
+  # chrome addon fails to install
 
 env:
   global:
@@ -21,6 +22,8 @@ matrix:
     env: PY=3.7
   - name: notebooks-code
     env: PY=3.7
+  - name: selenium
+    env: PY=3.7
   - name: latest-branca
     env: PY=3.7
   - name: docs
@@ -54,7 +57,18 @@ before_install:
     mkdir geckodriver
     tar -xzf geckodriver.tar.gz -C geckodriver
     export PATH=$PATH:$PWD/geckodriver
-
+  # Install Chrome
+  - |
+    wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+    sudo dpkg -i google-chrome-stable_current_amd64.deb
+    sudo apt-get install -y -f
+    # sudo dpkg -i google-chrome-stable_current_amd64.deb
+  # Install chromedriver
+  - |
+    wget https://chromedriver.storage.googleapis.com/$(curl https://chromedriver.storage.googleapis.com/LATEST_RELEASE)/chromedriver_linux64.zip -O chromedriver.zip
+    mkdir chromedriver
+    unzip chromedriver.zip -d chromedriver
+    export PATH=$PATH:$PWD/chromedriver
 
 # Test source distribution.
 install:
@@ -72,13 +86,13 @@ script:
     fi
 
   - if [[ $TRAVIS_JOB_NAME == 'default' ]]; then
-      pytest /tmp -vv --ignore=tests/notebooks/test_notebooks.py ;
+      pytest /tmp -vv --ignore=/tmp/tests/selenium ;
     fi
 
   - if [[ $TRAVIS_JOB_NAME == 'latest-branca' ]]; then
       conda uninstall branca ;
       pip install git+https://github.com/python-visualization/branca.git ;
-      pytest /tmp -vv --ignore=tests/notebooks/test_notebooks.py ;
+      pytest /tmp -vv --ignore=/tmp/tests/selenium ;
     fi
 
   - if [[ $TRAVIS_JOB_NAME == 'notebooks-conding-standard' ]]; then
@@ -91,6 +105,10 @@ script:
       pytest --nbval-lax /tmp/examples ;
     fi
 
+  - if [[ $TRAVIS_JOB_NAME == 'selenium' ]]; then
+      pytest /tmp/tests/selenium -vv ;
+    fi
+
 # Docs
   - |
     if [[ $TRAVIS_JOB_NAME == 'docs' ]]; then