test_notebooks only for py=3.4

Author: Martin Journois

.travis.yml

@@ -16,11 +16,11 @@ before_install:
     - conda update --yes --all
     - travis_retry conda create --yes -n test python=$PYTHON --file requirements.txt
     - source activate test
-    - if [[ "$PYTHON" != "3.3" ]]; then
-        conda install --yes --file requirements-dev.txt;
+    - conda install --yes --file requirements-dev.txt;
+    - if [[ "$PYTHON" == "3.4" ]]; then
+        travis_retry conda install --yes nbconvert jupyter_client ipykernel;
         conda install --yes -c ioos geopandas;
       fi
-    - conda install --yes pandas numpy
     - if [[ "$PYTHON" != "3.5" ]]; then
         travis_retry conda install --yes mock ;
       fi

requirements-dev.txt

@@ -1,7 +1,5 @@
 flake8
 pandas
+numpy
 pytest
 vincent
-nbconvert
-jupyter_client
-ipykernel

tests/test_notebooks.py

@@ -7,35 +7,38 @@
 """
 
 import os
+import sys
 import folium
-import nbconvert
 
-rootpath = os.path.abspath(os.path.dirname(__file__))
+if sys.version_info[:2]==(3,4):
+    import nbconvert
 
+    rootpath = os.path.abspath(os.path.dirname(__file__))
 
-class NotebookTester(object):
-    def __init__(self, filename):
-        self.filename = filename
 
-    def __call__(self, exporter=None, filename=None):
-        raw_nb = nbconvert.exporters.Exporter().from_filename(self.filename)
-        raw_nb[0].metadata.setdefault('kernelspec', {})['name'] = 'python'
-        exec_nb = nbconvert.preprocessors.ExecutePreprocessor().preprocess(*raw_nb)
+    class NotebookTester(object):
+        def __init__(self, filename):
+            self.filename = filename
 
-        if exporter is not None:
-            out_nb = nbconvert.exporters.MarkdownExporter().from_notebook_node(*exec_nb)
-            if filename is None:
-                assert self.filename.endswith('.ipynb')
-                filename = self.filename[:-6] + exporter.file_extension
-            open(filename, 'w').write(out_nb[0].encode('utf-8'))
+        def __call__(self, exporter=None, filename=None):
+            raw_nb = nbconvert.exporters.Exporter().from_filename(self.filename)
+            raw_nb[0].metadata.setdefault('kernelspec', {})['name'] = 'python'
+            exec_nb = nbconvert.preprocessors.ExecutePreprocessor().preprocess(*raw_nb)
 
+            if exporter is not None:
+                out_nb = nbconvert.exporters.MarkdownExporter().from_notebook_node(*exec_nb)
+                if filename is None:
+                    assert self.filename.endswith('.ipynb')
+                    filename = self.filename[:-6] + exporter.file_extension
+                open(filename, 'w').write(out_nb[0].encode('utf-8'))
 
-class TestNotebooks(object):
-    _filepath = rootpath.rstrip('/')+'/../examples/'
-    _nblist = [x for x in os.listdir(_filepath) if x.endswith('.ipynb')]
 
-for fn in TestNotebooks._nblist:
-            setattr(TestNotebooks,
-                    'test_'+folium.utilities._camelify(fn[:-6]),
-                    NotebookTester(TestNotebooks._filepath+fn).__call__
-                    )
+    class TestNotebooks(object):
+        _filepath = rootpath.rstrip('/')+'/../examples/'
+        _nblist = [x for x in os.listdir(_filepath) if x.endswith('.ipynb')]
+
+    for fn in TestNotebooks._nblist:
+                setattr(TestNotebooks,
+                        'test_'+folium.utilities._camelify(fn[:-6]),
+                        NotebookTester(TestNotebooks._filepath+fn).__call__
+                        )