Skip to content

Commit 161852d

Browse files
pmainsocefpaf
authored andcommitted
Fixing flake8 warnings, except unused folium.features.GeoJsonPopup import and _version.py newline error
1 parent ec5c08b commit 161852d

14 files changed

Lines changed: 27 additions & 26 deletions

folium/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
CustomIcon,
2323
DivIcon,
2424
GeoJson,
25-
GeoJsonTooltip,
2625
GeoJsonPopup,
26+
GeoJsonTooltip,
2727
LatLngPopup,
2828
RegularPolygonMarker,
2929
TopoJson,

folium/elements.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from branca.element import Figure, Element, JavascriptLink, CssLink
1+
from branca.element import CssLink, Element, Figure, JavascriptLink
22

33

44
class JSCSSMixin(Element):

folium/features.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,28 @@
33
44
"""
55

6-
import json
7-
import warnings
86
import functools
7+
import json
98
import operator
9+
import warnings
1010

1111
from branca.colormap import LinearColormap, StepColormap
1212
from branca.element import (Element, Figure, JavascriptLink, MacroElement)
1313
from branca.utilities import color_brewer
1414

1515
from folium.elements import JSCSSMixin
1616
from folium.folium import Map
17-
from folium.map import (FeatureGroup, Icon, Layer, Marker, Tooltip, Popup)
17+
from folium.map import (FeatureGroup, Icon, Layer, Marker, Popup, Tooltip)
1818
from folium.utilities import (
19-
validate_locations,
2019
_parse_size,
20+
camelize,
2121
get_bounds,
22+
get_obj_in_upper_tree,
2223
image_to_url,
2324
none_max,
2425
none_min,
25-
get_obj_in_upper_tree,
2626
parse_options,
27-
camelize
27+
validate_locations,
2828
)
2929
from folium.vector_layers import Circle, CircleMarker, PolyLine, path_options
3030

@@ -583,16 +583,16 @@ def find_identifier(self):
583583
"""
584584
feats = self.data['features']
585585
# Each feature has an 'id' field with a unique value.
586-
unique_ids = set(feat.get('id', None) for feat in feats)
586+
unique_ids = {feat.get('id', None) for feat in feats}
587587
if None not in unique_ids and len(unique_ids) == len(feats):
588588
return 'feature.id'
589589
# Each feature has a unique string or int property.
590590
if all(isinstance(feat.get('properties', None), dict) for feat in feats):
591591
for key in feats[0]['properties']:
592-
unique_values = set(
592+
unique_values = {
593593
feat['properties'].get(key, None) for feat in feats
594594
if isinstance(feat['properties'].get(key, None), (str, int))
595-
)
595+
}
596596
if len(unique_values) == len(feats):
597597
return 'feature.properties.{}'.format(key)
598598
# We add an 'id' field with a unique value to the data.

folium/folium.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
from folium.raster_layers import TileLayer
1414
from folium.utilities import (
1515
_parse_size,
16+
parse_options,
1617
temp_html_filepath,
1718
validate_location,
18-
parse_options,
1919
)
2020

2121
from jinja2 import Environment, PackageLoader, Template

folium/map.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@
33
44
"""
55

6-
from collections import OrderedDict
7-
86
import warnings
7+
from collections import OrderedDict
98

109
from branca.element import Element, Figure, Html, MacroElement
1110

12-
from folium.utilities import validate_location, camelize, parse_options
11+
from folium.utilities import camelize, parse_options, validate_location
1312

1413
from jinja2 import Template
1514

@@ -305,6 +304,7 @@ def render(self):
305304
raise ValueError("{} location must be assigned when added directly to map.".format(self._name))
306305
super(Marker, self).render()
307306

307+
308308
class Popup(Element):
309309
"""Create a Popup instance that can be linked to a Layer.
310310

folium/plugins/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"""
88

99
from folium.plugins.antpath import AntPath
10-
from folium.plugins.polyline_offset import PolyLineOffset
1110
from folium.plugins.beautify_icon import BeautifyIcon
1211
from folium.plugins.boat_marker import BoatMarker
1312
from folium.plugins.draw import Draw
@@ -25,6 +24,7 @@
2524
from folium.plugins.minimap import MiniMap
2625
from folium.plugins.mouse_position import MousePosition
2726
from folium.plugins.pattern import CirclePattern, StripePattern
27+
from folium.plugins.polyline_offset import PolyLineOffset
2828
from folium.plugins.polyline_text_path import PolyLineTextPath
2929
from folium.plugins.scroll_zoom_toggler import ScrollZoomToggler
3030
from folium.plugins.search import Search

folium/plugins/antpath.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from folium.elements import JSCSSMixin
2-
from folium.vector_layers import path_options, BaseMultiLocation
2+
from folium.vector_layers import BaseMultiLocation, path_options
33

44
from jinja2 import Template
55

folium/plugins/dual_map.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from branca.element import MacroElement, Figure
1+
from branca.element import Figure, MacroElement
22

33
from folium.elements import JSCSSMixin
44
from folium.folium import Map

folium/plugins/heat_map.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
from folium.elements import JSCSSMixin
44
from folium.map import Layer
55
from folium.utilities import (
6+
if_pandas_df_convert_to_numpy,
67
none_max,
78
none_min,
89
parse_options,
9-
if_pandas_df_convert_to_numpy,
1010
validate_location,
1111
)
1212

folium/plugins/marker_cluster.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from folium.elements import JSCSSMixin
22
from folium.map import Layer, Marker
3-
from folium.utilities import validate_locations, parse_options
3+
from folium.utilities import parse_options, validate_locations
44

55
from jinja2 import Template
66

0 commit comments

Comments
 (0)