Fix selenium tests, use nbconvert 5.6 (#1408)

* Try to fix missing template file

* Fix data-html being percent-encoded

* Simplify, remove parameter

* Use absolute path of nbconvert template

* Revert "Use absolute path of nbconvert template"

This reverts commit e625b30.

* Use previous nbconvert version

* Revert "Try to fix missing template file"

This reverts commit 7eb1eca.

* Revert "Fix data-html being percent-encoded"

This reverts commit 6974bd6.

Author: Conengmo

requirements-dev.txt

@@ -15,7 +15,7 @@ ipykernel
 jupyter_client
 matplotlib
 mplleaflet
-nbconvert
+nbconvert==5.6.*
 nbsphinx
 nbval
 owslib

tests/selenium/test_selenium.py

@@ -40,13 +40,13 @@ def test_notebook(filepath, driver):
         driver.verify_js_logs()
 
 
-def get_notebook_html(filepath_notebook, execute=True):
+def get_notebook_html(filepath_notebook):
     """Store iframes from a notebook in html files, remove them when done."""
-    if execute:
-        subprocess.run([
-            'jupyter', 'nbconvert', '--to', 'notebook', '--execute', filepath_notebook,
-        ])
-        filepath_notebook = filepath_notebook.replace('.ipynb', '.nbconvert.ipynb')
+    # run the notebook to make sure the output is up-to-date
+    subprocess.run([
+        'jupyter', 'nbconvert', '--to', 'notebook', '--execute', filepath_notebook,
+    ])
+    filepath_notebook = filepath_notebook.replace('.ipynb', '.nbconvert.ipynb')
 
     html_exporter = nbconvert.HTMLExporter()
     html_exporter.template_file = 'basic'