Skip to content

Commit 6bb67ca

Browse files
committed
Add type annotation to get_changes() in move.py
1 parent 4ca7a98 commit 6bb67ca

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

rope/refactor/move.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ def __init__(self, project, resource, offset):
8282

8383
def get_changes(
8484
self,
85-
dest_attr,
86-
new_name=None,
87-
resources=None,
85+
dest_attr: str,
86+
new_name: Optional[str] = None,
87+
resources: Optional[List[resources.File]] = None,
8888
task_handle=taskhandle.DEFAULT_TASK_HANDLE, # FIXME: this is unused
8989
):
9090
"""Return the changes needed for this refactoring
@@ -519,7 +519,10 @@ def __init__(self, project, resource):
519519
self.import_tools = self.tools.import_tools
520520

521521
def get_changes(
522-
self, dest, resources=None, task_handle=taskhandle.DEFAULT_TASK_HANDLE
522+
self,
523+
dest: resources.Resource,
524+
resources: Optional[List[resources.File]] = None,
525+
task_handle=taskhandle.DEFAULT_TASK_HANDLE,
523526
):
524527
if resources is None:
525528
resources = self.project.get_python_files()

ropetest/refactor/movetest.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,12 @@ def _move_to_attr(
5959
self,
6060
resource: Union[resources.File, resources.Folder],
6161
offset: Union[int, None],
62-
dest_attr: Union[str, resources.File, resources.Folder],
62+
dest_attr: str,
6363
*,
6464
new_name: str,
6565
):
6666
mover = move.create_move(self.project, resource, offset)
67+
assert isinstance(mover, move.MoveMethod)
6768
changes = mover.get_changes(dest_attr, new_name=new_name)
6869
self.project.do(changes)
6970

0 commit comments

Comments
 (0)