Implement config setting imports.preferred_import_style

Author: lieryan

docs/default_config.py

@@ -107,10 +107,13 @@ def set_prefs(prefs):
     #
     #     prefs["ignore_bad_imports"] = False
 
-    # If `True`, rope will insert new module imports as
-    # `from <package> import <module>` by default.
+    # Controls how rope inserts new import statements. Must be one of:
+    # 
+    # - "normal-import" will insert `import <package>`
+    # - "from-module" will insert `from <package> import <module>`
+    # - "from-global" insert insert `from <package>.<module> import <object>`
     #
-    #     prefs["prefer_module_from_imports"] = False
+    #     prefs.imports.preferred_import_style = "normal-import"
 
     # If `True`, rope will transform a comma list of imports into
     # multiple separate import statements when organizing

rope/base/prefs.py

@@ -1,4 +1,5 @@
 """Rope preferences."""
+from enum import Enum
 from dataclasses import asdict, dataclass
 from textwrap import dedent
 from typing import Any, Callable, Dict, List, Optional, Tuple
@@ -34,6 +35,20 @@ class AutoimportPrefs:
     )
 
 
+@dataclass
+class ImportPrefs:
+    preferred_import_style: str = field(
+        default="default",
+        description=dedent("""
+            Controls how rope inserts new import statements. If set to
+            ``"normal-import"`` (default) will insert ``import <package>``; if
+            set to ``"from-module"`` will insert ``from <package> import
+            <module>``; if set to ``"from-global"`` rope will insert ``from
+            <package>.<module> import <object>``.
+        """),
+    )
+
+
 @dataclass
 class Prefs:
     """Class to store rope preferences."""
@@ -149,7 +164,7 @@ class Prefs:
         default=False,
         description=dedent("""
             If ``True`` modules with syntax errors are considered to be empty.
-            The default value is ``False``; When ``False`` syntax errors raise
+            The default value is ``False``; when ``False`` syntax errors raise
             ``rope.base.exceptions.ModuleSyntaxError`` exception.
         """),
     )
@@ -164,8 +179,8 @@ class Prefs:
     prefer_module_from_imports: bool = field(
         default=False,
         description=dedent("""
-            If ``True``, rope will insert new module imports as ``from
-            <package> import <module>`` by default.
+            **Deprecated**. ``imports.preferred_import_style`` takes
+            precedence over ``prefer_module_from_imports``.
         """),
     )
 
@@ -232,7 +247,13 @@ class Prefs:
         """),
     )
     autoimport: AutoimportPrefs = field(
-        default_factory=AutoimportPrefs, description="Preferences for Autoimport")
+        default_factory=AutoimportPrefs,
+        description="Preferences for Autoimport",
+    )
+    imports: ImportPrefs = field(
+        default_factory=ImportPrefs,
+        description="Preferences for Import Organiser",
+    )
 
     def set(self, key: str, value: Any):
         """Set the value of `key` preference to `value`."""
@@ -320,3 +341,21 @@ def get_config(root: Folder, ropefolder: Folder) -> PyToolConfig:
         global_config=True,
     )
     return config
+
+
+class ImportStyle(Enum):  # FIXME: Use StrEnum once we're on minimum Python 3.11
+    normal_import = "normal-import"
+    from_module = "from-module"
+    from_global = "from-global"
+
+
+DEFAULT_IMPORT_STYLE = ImportStyle.normal_import
+
+
+def get_preferred_import_style(prefs: Prefs) -> ImportStyle:
+    try:
+        return ImportStyle(prefs.imports.preferred_import_style)
+    except ValueError:
+        if prefs.imports.preferred_import_style == "default" and prefs.prefer_module_from_imports:
+            return ImportStyle.from_module
+        return DEFAULT_IMPORT_STYLE

ropetest/refactor/importutilstest.py

@@ -1,10 +1,68 @@
 import unittest
 from textwrap import dedent
 
+from rope.base.prefs import get_preferred_import_style, ImportStyle, Prefs, ImportPrefs
+from rope.base.prefs import DEFAULT_IMPORT_STYLE
 from rope.refactor.importutils import ImportTools, add_import, importinfo
 from ropetest import testutils
 
 
+class TestImportPrefs:
+    def test_preferred_import_style_is_normal_import(self, project):
+        pref = Prefs(imports=ImportPrefs(preferred_import_style="normal-import"))
+        assert pref.imports.preferred_import_style == "normal-import"
+        assert get_preferred_import_style(pref) == ImportStyle.normal_import
+
+    def test_preferred_import_style_is_from_module(self, project):
+        pref = Prefs(imports=ImportPrefs(preferred_import_style="from-module"))
+        assert pref.imports.preferred_import_style == "from-module"
+        assert get_preferred_import_style(pref) == ImportStyle.from_module
+
+    def test_preferred_import_style_is_from_global(self, project):
+        pref = Prefs(imports=ImportPrefs(preferred_import_style="from-global"))
+        assert pref.imports.preferred_import_style == "from-global"
+        assert get_preferred_import_style(pref) == ImportStyle.from_global
+
+    def test_invalid_preferred_import_style_is_default(self, project):
+        pref = Prefs(imports=ImportPrefs(preferred_import_style="invalid-value"))
+        assert pref.imports.preferred_import_style == "invalid-value"
+        assert get_preferred_import_style(pref) == DEFAULT_IMPORT_STYLE
+        assert get_preferred_import_style(pref) == ImportStyle.normal_import
+
+    def test_default_preferred_import_style_default_is_normal_imports(self, project):
+        pref = Prefs()
+        assert pref.imports.preferred_import_style == "default"
+        assert get_preferred_import_style(pref) == ImportStyle.normal_import
+
+    def test_default_preferred_import_style_default_and_prefer_module_from_imports(self, project):
+        pref = Prefs(
+            prefer_module_from_imports=True,
+            imports=ImportPrefs(preferred_import_style="default"),
+        )
+        assert get_preferred_import_style(pref) == ImportStyle.from_module
+
+    def test_preferred_import_style_is_normal_import_takes_precedence_over_prefer_module_from_imports(self, project):
+        pref = Prefs(
+            prefer_module_from_imports=True,
+            imports=ImportPrefs(preferred_import_style="normal_import"),
+        )
+        assert get_preferred_import_style(pref) == ImportStyle.normal_import
+
+    def test_preferred_import_style_is_from_module_takes_precedence_over_prefer_module_from_imports(self, project):
+        pref = Prefs(
+            prefer_module_from_imports=True,
+            imports=ImportPrefs(preferred_import_style="from-module"),
+        )
+        assert get_preferred_import_style(pref) == ImportStyle.from_module
+
+    def test_preferred_import_style_is_from_global_takes_precedence_over_prefer_module_from_imports(self, project):
+        pref = Prefs(
+            prefer_module_from_imports=True,
+            imports=ImportPrefs(preferred_import_style="from-global"),
+        )
+        assert get_preferred_import_style(pref) == ImportStyle.from_global
+
+
 class ImportUtilsTest(unittest.TestCase):
     def setUp(self):
         super().setUp()