set autocommit to None

None passing to aiomysql means it'll respect the server setup for
autocommit.

Author: wwwjfy

mysql_tests/conftest.py

@@ -23,8 +23,7 @@ def sa_engine():
 @pytest.fixture
 @async_generator
 async def engine(sa_engine):
-    e = await gino.create_engine(MYSQL_URL, echo=ECHO, minsize=10,
-                                 autocommit=True)
+    e = await gino.create_engine(MYSQL_URL, echo=ECHO, minsize=10)
     await yield_(e)
     await e.close()
     sa_engine.execute("DELETE FROM gino_user_settings")
@@ -35,9 +34,7 @@ async def engine(sa_engine):
 @pytest.fixture
 @async_generator
 async def bind(sa_engine):
-    async with db.with_bind(
-        MYSQL_URL, echo=ECHO, minsize=10, autocommit=True,
-    ) as e:
+    async with db.with_bind(MYSQL_URL, echo=ECHO, minsize=10) as e:
         await yield_(e)
     sa_engine.execute("DELETE FROM gino_user_settings")
     sa_engine.execute("DELETE FROM gino_users")

mysql_tests/test_bakery.py

@@ -152,7 +152,7 @@ class BakeOnClass(db.Model):
         def getter(cls):
             return cls.query.where(cls.name == db.bindparam("name"))
 
-    async with db.with_bind(MYSQL_URL, prebake=False, autocommit=True):
+    async with db.with_bind(MYSQL_URL, prebake=False):
         await db.gino.create_all()
         try:
             await BakeOnClass.create(name="exist")

mysql_tests/test_core.py

@@ -29,7 +29,7 @@ async def test_engine_only():
         Column("email_address", String(255), nullable=False),
     )
 
-    engine = await gino.create_engine(MYSQL_URL, autocommit=True)
+    engine = await gino.create_engine(MYSQL_URL)
     await GinoSchemaVisitor(metadata).create_all(engine)
     try:
         ins = users.insert().values(name="jack", fullname="Jack Jones")
@@ -62,7 +62,7 @@ async def test_core():
         db.Column("email_address", db.String(255), nullable=False),
     )
 
-    async with db.with_bind(MYSQL_URL, autocommit=True):
+    async with db.with_bind(MYSQL_URL):
         await db.gino.create_all()
         try:
             await users.insert().values(
@@ -93,7 +93,7 @@ class Address(db.Model):
         user_id = db.Column(None, db.ForeignKey("users.id"))
         email_address = db.Column(db.String(255), nullable=False)
 
-    async with db.with_bind(MYSQL_URL, autocommit=True):
+    async with db.with_bind(MYSQL_URL):
         await db.gino.create_all()
         try:
             await User.create(name="jack", fullname="Jack Jones")

mysql_tests/test_crud.py

@@ -122,7 +122,7 @@ async def test_multiple_primary_key_order():
     import gino
 
     db1 = gino.Gino()
-    await db1.set_bind(MYSQL_URL, autocommit=True)
+    await db1.set_bind(MYSQL_URL)
 
     class NameCard(db1.Model):
         __tablename__ = "name_cards"
@@ -152,7 +152,7 @@ class NameCard(db1.Model):
         await db1.pop_bind().close()
 
     db2 = gino.Gino(MYSQL_URL)
-    await db2.set_bind(MYSQL_URL, autocommit=True)
+    await db2.set_bind(MYSQL_URL)
 
     class NameCard(db2.Model):
         __tablename__ = "name_cards"

src/gino/dialects/aiomysql.py

@@ -228,6 +228,9 @@ async def _init(self):
             db=self._url.database,
             password=self._url.password,
         )
+        # aiomysql sets autocommit as False by default, which opposes the MySQL
+        # default, therefore it's set to None to respect the MySQL configuration
+        args.setdefault("autocommit", None)
         self._pool = await aiomysql.create_pool(**args)
         return self