Skip to content

Commit b12dd24

Browse files
philippeitisJoseph Weston
authored andcommitted
Fixed int -> float for functions that return floats.
Corrected documentation, optimized a boundary check.
1 parent b766803 commit b12dd24

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

adaptive/learner/triangulation.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ def fast_2d_point_in_simplex(point, simplex, eps=1e-8):
5757

5858

5959
def point_in_simplex(point, simplex, eps=1e-8):
60-
# simplex is list
6160
if len(point) == 2:
6261
return fast_2d_point_in_simplex(point, simplex, eps)
6362

@@ -79,7 +78,7 @@ def fast_2d_circumcircle(points):
7978
Returns
8079
-------
8180
tuple
82-
(center point : tuple(int), radius: int)
81+
(center point : tuple(float), radius: float)
8382
"""
8483
points = array(points)
8584
# transform to relative coordinates
@@ -115,7 +114,7 @@ def fast_3d_circumcircle(points):
115114
Returns
116115
-------
117116
tuple
118-
(center point : tuple(int), radius: int)
117+
(center point : tuple(float), radius: float)
119118
"""
120119
points = array(points)
121120
pts = points[1:] - points[0]
@@ -258,7 +257,7 @@ def simplex_volume_in_embedding(vertices) -> float:
258257
vol_square = fast_det(sq_dists_mat) / coeff
259258

260259
if vol_square < 0:
261-
if abs(vol_square) < 1e-15:
260+
if -1e-15 < vol_square < 1e-15:
262261
return 0
263262
raise ValueError("Provided vertices do not form a simplex")
264263

0 commit comments

Comments
 (0)