no longer skip ipyparallel tests on Python 3.8

Author: basnijholt

adaptive/runner.py

@@ -5,7 +5,6 @@
 import inspect
 import itertools
 import pickle
-import sys
 import time
 import traceback
 import warnings
@@ -14,13 +13,9 @@
 from adaptive.notebook_integration import in_ipynb, live_info, live_plot
 
 try:
-    if sys.version_info < (3, 8):
-        # XXX: remove when ipyparallel 6.2.5 is released
-        import ipyparallel
+    import ipyparallel
 
-        with_ipyparallel = True
-    else:
-        with_ipyparallel = False
+    with_ipyparallel = True
 except ModuleNotFoundError:
     with_ipyparallel = False
 

adaptive/tests/test_runner.py

@@ -74,10 +74,6 @@ async def f(x):
 
 @pytest.fixture(scope="session")
 def ipyparallel_executor():
-    if sys.version_info[:2] == (3, 8):
-        # ipyparallel is broken on Python 3.8
-        # https://github.com/ipython/ipyparallel/issues/404
-        pytest.skip()
     from ipyparallel import Client
 
     if os.name == "nt":
@@ -121,9 +117,7 @@ def test_stop_after_goal():
     assert stop_time - start_time > seconds_to_wait
 
 
-# https://github.com/ipython/ipyparallel/issues/404
 @pytest.mark.skipif(not with_ipyparallel, reason="IPyparallel is not installed")
-@pytest.mark.skipif(sys.version_info[:2] == (3, 8), reason="ipyparallel broken on 3.8")
 def test_ipyparallel_executor(ipyparallel_executor):
     learner = Learner1D(linear, (-1, 1))
     BlockingRunner(learner, trivial_goal, executor=ipyparallel_executor)