make baserunner abstract with some abstract methods

Author: jhoofwijk

adaptive/runner.py

@@ -8,6 +8,7 @@
 import time
 import traceback
 import warnings
+import abc
 
 from .notebook_integration import live_plot, live_info, in_ipynb
 from .utils import timed
@@ -53,8 +54,8 @@ def _default_executor(*args, **kwargs):
     _default_executor_kwargs = {}
 
 
-class BaseRunner:
-    """Base class for runners that use `concurrent.futures.Executors`.
+class BaseRunner(metaclass=abc.ABCMeta):
+    """Base class for runners that use concurrent.futures.Executors.
 
     Parameters
     ----------
@@ -241,6 +242,16 @@ def _cleanup(self):
     def failed(self):
         """Set of points that failed ``runner.retries`` times."""
         return set(self.tracebacks) - set(self.to_retry)
+    
+    @abc.abstractmethod
+    def elapsed_time(self):
+        """Is called in 'overhead'."""
+        pass
+    
+    @abc.abstractmethod
+    def _submit(self, x):
+        """Is called in '_get_futures'."""
+        pass
 
 
 class BlockingRunner(BaseRunner):
@@ -444,9 +455,9 @@ def goal(_):
                 raise RuntimeError('Cannot use an executor when learning an '
                                    'async function.')
             self.executor.shutdown()  # Make sure we don't shoot ourselves later
-            self._submit = lambda x: self.ioloop.create_task(self.function(x))
+            self.__submit = lambda x: self.ioloop.create_task(self.function(x))
         else:
-            self._submit = functools.partial(self.ioloop.run_in_executor,
+            self.__submit = functools.partial(self.ioloop.run_in_executor,
                                              self.executor,
                                              self.function)
 
@@ -458,6 +469,9 @@ def goal(_):
                           "in a Jupyter notebook, remember to run "
                           "'adaptive.notebook_extension()'")
 
+    def _submit(self, x):
+        return self.__submit(x)
+
     def status(self):
         """Return the runner status as a string.