Skip to content

Postal code elements in alma_xml_person should be uppercase #911

Description

@mzelesky

Expected behavior

Postal codes from the OIT person feed get added to the Alma person.

Actual behavior

Since the code is looking for DORM_postal instead of DORM_POSTAL, for example, postal codes are empty. See, for example,

line4: person["DORM_ADDRESS4"], city: person["DORM_CITY"], state: person["DORM_STATE"], country: person["DORM_COUNTRY"], postal: person["DORM_postal"])

Impact of this bug

Postal codes are not being added to users in Alma

Acceptance criteria

  • If this change touches any of the files referenced in .rubocop_todo.yml create a new ticket to address the rubocop todo.
  • Postal codes are properly transformed

Honeybadger link and code snippet, if applicable

Implementation notes, if any

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions