Implicitly opting out of caching when a plugin's version can't be determined

Author: fabiospampinato

src/index.ts

@@ -12,7 +12,7 @@ import Known from "./known.js";
 import Logger from "./logger.js";
 import { makePrettier } from "./prettier.js";
 import { castArray, getExpandedFoldersPaths, getFoldersChildrenPaths, getPluginsVersions, getProjectPath, getStdin, getTargetsPaths } from "./utils.js";
-import { fastRelativePath, isString, isUndefined, negate, pluralize, trimFinalNewline, uniq } from "./utils.js";
+import { fastRelativePath, isNull, isString, isUndefined, negate, pluralize, trimFinalNewline, uniq } from "./utils.js";
 import type { FormatOptions, Options, PluginsOptions } from "./types.js";
 
 async function run(options: Options, pluginsDefaultOptions: PluginsOptions, pluginsCustomOptions: PluginsOptions): Promise<void> {
@@ -72,6 +72,7 @@ async function runGlobs(options: Options, pluginsDefaultOptions: PluginsOptions,
   const cliVersion = CLI_VERSION;
   const pluginsNames = options.formatOptions.plugins || [];
   const pluginsVersions = getPluginsVersions(pluginsNames);
+  const pluginsVersionsMissing = pluginsVersions.filter(isNull);
 
   const editorConfigNames = options.editorConfig ? [".editorconfig"].filter(Known.hasFileName) : [];
   const ignoreNames = options.ignore ? [".gitignore", ".prettierignore"].filter(Known.hasFileName) : [];
@@ -102,7 +103,7 @@ async function runGlobs(options: Options, pluginsDefaultOptions: PluginsOptions,
   const cliFormatConfig = options.formatOptions;
   const cacheVersion = stringify({ prettierVersion, cliVersion, pluginsNames, pluginsVersions, editorConfigs, ignoreContents, prettierConfigs, ignoreManualFilesPaths, ignoreManualFilesContents, prettierManualFilesPaths, prettierManualFilesContents, cliContextConfig, cliFormatConfig, pluginsDefaultOptions, pluginsCustomOptions }); // prettier-ignore
 
-  const shouldCache = options.cache && isUndefined(cliContextConfig.cursorOffset);
+  const shouldCache = options.cache && !pluginsVersionsMissing.length && isUndefined(cliContextConfig.cursorOffset);
   const cache = shouldCache ? new Cache(cacheVersion, projectPath, options, stdout) : undefined;
   const prettier = await makePrettier(options, cache);
 

src/utils.ts

@@ -120,12 +120,15 @@ function getPluginPath(name: string): string {
   return pluginPath;
 }
 
-function getPluginVersion(name: string): string {
+function getPluginVersion(name: string): string | null {
   const pluginPath = getPluginPath(name);
   const parentPath = path.dirname(pluginPath);
   const pkg = findUp("package.json", parentPath);
-  if (!pkg || !pkg.content.version) throw new Error(`Version not found for plugin: "${name}"`);
-  return pkg.content.version;
+  if (!pkg || !pkg.content.version) {
+    return null;
+  } else {
+    return pkg.content.version;
+  }
 }
 
 function getPlugins(names: string[]): PromiseMaybe<PrettierPlugin[]> {
@@ -142,7 +145,7 @@ function getPluginsPaths(names: string[]): string[] {
   return pluginsPaths;
 }
 
-function getPluginsVersions(names: string[]): string[] {
+function getPluginsVersions(names: string[]): (string | null)[] {
   const pluginsVersions = names.map(getPluginVersion);
   return pluginsVersions;
 }
@@ -256,6 +259,10 @@ function isIntegerInRange(value: unknown, min: number = -Infinity, max: number =
   return isInteger(value) && value >= min && value <= max && value % step === 0;
 }
 
+function isNull(value: unknown): value is null {
+  return value === null;
+}
+
 function isNumber(value: unknown): value is number {
   return typeof value === "number";
 }
@@ -688,6 +695,7 @@ export {
   isFunction,
   isInteger,
   isIntegerInRange,
+  isNull,
   isNumber,
   isObject,
   isString,