Ported test suite: patterns

pralkarz · fabiospampinato · commit ada654968dfa · 2025-02-10T01:33:04.000Z
- Single patterns not matching anything no longer cause an error to be printed if there are other pattenrs that match something, as we are executing these patterns kinda together for performance, implementing that back would mean searching for files less efficiently in general.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
     "specialist": "^1.4.5",
     "tiny-editorconfig": "^1.0.0",
     "tiny-jsonc": "^1.0.1",
-    "tiny-readdir-glob": "^1.22.24",
+    "tiny-readdir-glob": "^1.23.1",
     "tiny-spinner": "^2.0.4",
     "worktank": "^2.7.3",
     "zeptomatch": "^2.0.0",
diff --git a/src/index.ts b/src/index.ts
@@ -200,7 +200,7 @@ async function runGlobs(options: Options, pluginsDefaultOptions: PluginsOptions,
 
   if (!totalMatched && !totalIgnored) {
     if (options.errorOnUnmatchedPattern) {
-      stderr.prefixed.error(`No files matching the given patterns were found`);
+      stderr.prefixed.error(`No files matching the given patterns were found.`);
     }
   }
 
diff --git a/test/__fixtures__/patterns-special-characters/dots/[...with-square-brackets-and-dots].js b/test/__fixtures__/patterns-special-characters/dots/[...with-square-brackets-and-dots].js
@@ -0,0 +1,4 @@
+foo(
+
+
+)
diff --git a/test/__fixtures__/patterns-special-characters/square-brackets/[with-square-brackets].js b/test/__fixtures__/patterns-special-characters/square-brackets/[with-square-brackets].js
@@ -0,0 +1,4 @@
+foo(
+
+
+)
diff --git a/test/__fixtures__/patterns/directory/file.js b/test/__fixtures__/patterns/directory/file.js
@@ -0,0 +1 @@
+'use strict';
diff --git a/test/__fixtures__/patterns/directory/nested-directory/nested-directory-file.js b/test/__fixtures__/patterns/directory/nested-directory/nested-directory-file.js
@@ -0,0 +1 @@
+'use strict';
diff --git a/test/__fixtures__/patterns/file.will-never-support b/test/__fixtures__/patterns/file.will-never-support
diff --git a/test/__fixtures__/patterns/node_modules/node-module.js b/test/__fixtures__/patterns/node_modules/node-module.js
diff --git a/test/__fixtures__/patterns/other-directory/file.js b/test/__fixtures__/patterns/other-directory/file.js
@@ -0,0 +1 @@
+'use strict';
diff --git a/test/__fixtures__/patterns/other-directory/nested-directory/nested-directory-file.js b/test/__fixtures__/patterns/other-directory/nested-directory/nested-directory-file.js
@@ -0,0 +1 @@
+'use strict';
diff --git a/test/__fixtures__/patterns/other-regular-modules.js b/test/__fixtures__/patterns/other-regular-modules.js
@@ -0,0 +1 @@
+'use strict';
diff --git a/test/__fixtures__/patterns/regular-module.js b/test/__fixtures__/patterns/regular-module.js
@@ -0,0 +1 @@
+'use strict';
diff --git a/test/__tests__/__snapshots__/error-on-unmatched-pattern.js.snap b/test/__tests__/__snapshots__/error-on-unmatched-pattern.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`error on unmatched pattern (stderr) 1`] = `"[error] No files matching the given patterns were found"`;
+exports[`error on unmatched pattern (stderr) 1`] = `"[error] No files matching the given patterns were found."`;
 
 exports[`error on unmatched pattern (stdout) 1`] = `""`;
 
diff --git a/test/__tests__/__snapshots__/ignore-unknown.js.snap b/test/__tests__/__snapshots__/ignore-unknown.js.snap
@@ -6,13 +6,13 @@ exports[`Ignored file (stdout) 1`] = `""`;
 
 exports[`Ignored file (write) 1`] = `[]`;
 
-exports[`None exist file (stderr) 1`] = `"[error] No files matching the given patterns were found"`;
+exports[`None exist file (stderr) 1`] = `"[error] No files matching the given patterns were found."`;
 
 exports[`None exist file (stdout) 1`] = `""`;
 
 exports[`None exist file (write) 1`] = `[]`;
 
-exports[`Not matching pattern (stderr) 1`] = `"[error] No files matching the given patterns were found"`;
+exports[`Not matching pattern (stderr) 1`] = `"[error] No files matching the given patterns were found."`;
 
 exports[`Not matching pattern (stdout) 1`] = `""`;
 
diff --git a/test/__tests__/__snapshots__/patterns.js.snap b/test/__tests__/__snapshots__/patterns.js.snap
@@ -0,0 +1,82 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`exits with an informative message when there are no patterns provided (stderr) 1`] = `
+"
+  Expected at least one target file/dir/glob
+"
+`;
+
+exports[`exits with an informative message when there are no patterns provided (stdout) 1`] = `""`;
+
+exports[`exits with an informative message when there are no patterns provided (write) 1`] = `[]`;
+
+exports[`multiple patterns (stderr) 1`] = `""`;
+
+exports[`multiple patterns (stdout) 1`] = `
+"directory/file.js
+directory/nested-directory/nested-directory-file.js
+other-directory/file.js
+other-directory/nested-directory/nested-directory-file.js"
+`;
+
+exports[`multiple patterns (write) 1`] = `[]`;
+
+exports[`multiple patterns with a negated pattern (stderr) 1`] = `""`;
+
+exports[`multiple patterns with a negated pattern (stdout) 1`] = `
+"directory/file.js
+other-directory/file.js
+other-regular-modules.js
+regular-module.js"
+`;
+
+exports[`multiple patterns with a negated pattern (write) 1`] = `[]`;
+
+exports[`multiple patterns with a negated pattern and leading \`./\`, ignores node_modules by default (stderr) 1`] = `""`;
+
+exports[`multiple patterns with a negated pattern and leading \`./\`, ignores node_modules by default (stdout) 1`] = `
+"other-directory/file.js
+other-directory/nested-directory/nested-directory-file.js
+other-regular-modules.js
+regular-module.js"
+`;
+
+exports[`multiple patterns with a negated pattern and leading \`./\`, ignores node_modules by default (write) 1`] = `[]`;
+
+exports[`multiple patterns with a negated pattern, doesn't ignore node_modules with the --with-node-modules flag (stderr) 1`] = `""`;
+
+exports[`multiple patterns with a negated pattern, doesn't ignore node_modules with the --with-node-modules flag (stdout) 1`] = `
+"node_modules/node-module.js
+other-directory/file.js
+other-directory/nested-directory/nested-directory-file.js
+other-regular-modules.js
+regular-module.js"
+`;
+
+exports[`multiple patterns with a negated pattern, doesn't ignore node_modules with the --with-node-modules flag (write) 1`] = `[]`;
+
+exports[`multiple patterns with a negated pattern, ignores node_modules by default (stderr) 1`] = `""`;
+
+exports[`multiple patterns with a negated pattern, ignores node_modules by default (stdout) 1`] = `
+"other-directory/file.js
+other-directory/nested-directory/nested-directory-file.js
+other-regular-modules.js
+regular-module.js"
+`;
+
+exports[`multiple patterns with a negated pattern, ignores node_modules by default (write) 1`] = `[]`;
+
+exports[`multiple patterns with an extra non-existent pattern (stderr) 1`] = `""`;
+
+exports[`multiple patterns with an extra non-existent pattern (stdout) 1`] = `
+"directory/file.js
+directory/nested-directory/nested-directory-file.js"
+`;
+
+exports[`multiple patterns with an extra non-existent pattern (write) 1`] = `[]`;
+
+exports[`multiple patterns, throws an error and exits with a non-zero code when there are no matches (stderr) 1`] = `"[error] No files matching the given patterns were found."`;
+
+exports[`multiple patterns, throws an error and exits with a non-zero code when there are no matches (stdout) 1`] = `""`;
+
+exports[`multiple patterns, throws an error and exits with a non-zero code when there are no matches (write) 1`] = `[]`;
diff --git a/test/__tests__/patterns.js b/test/__tests__/patterns.js
@@ -0,0 +1,101 @@
+import { runCli } from "../utils";
+
+describe("multiple patterns", () => {
+  runCli("patterns", [
+    "directory/**/*.js",
+    "other-directory/**/*.js",
+    "-l",
+  ]).test({
+    status: 1,
+  });
+});
+
+describe("multiple patterns with an extra non-existent pattern", () => {
+  runCli("patterns", [
+    "directory/**/*.js",
+    "non-existent.js",
+    "-l",
+  ]).test({
+    status: 1,
+  });
+});
+
+describe("multiple patterns with a negated pattern", () => {
+  runCli("patterns", [
+    "**/*.js",
+    "!**/nested-directory/**",
+    "-l",
+  ]).test({
+    status: 1,
+  });
+});
+
+describe("multiple patterns with a negated pattern, ignores node_modules by default", () => {
+  runCli("patterns", [
+    "**/*.js",
+    "!directory/**",
+    "-l",
+  ]).test({
+    status: 1,
+  });
+});
+
+// TODO: Handle leading `./` and `../` in patterns.
+describe.skip("multiple patterns with a negated pattern and leading `./`, ignores node_modules by default", () => {
+  runCli("patterns", [
+    "./**/*.js",
+    "!./directory/**",
+    "-l",
+  ]).test({
+    status: 1,
+  });
+});
+
+describe("multiple patterns with a negated pattern, doesn't ignore node_modules with the --with-node-modules flag", () => {
+  runCli("patterns", [
+    "**/*.js",
+    "!directory/**",
+    "-l",
+    "--with-node-modules",
+  ]).test({
+    status: 1,
+  });
+});
+
+describe("exits with an informative message when there are no patterns provided", () => {
+  runCli("patterns").test({
+    status: 1,
+  });
+});
+
+describe("multiple patterns, throws an error and exits with a non-zero code when there are no matches", () => {
+  runCli("patterns", [
+    "non-existent.js",
+    "other-non-existent.js",
+    "-l",
+  ]).test({
+    status: 1,
+  });
+});
+
+describe("file names with special characters", () => {
+  runCli("patterns-special-characters/square-brackets", [
+    "[with-square-brackets].js",
+    "-l",
+  ]).test({
+    status: 1,
+    write: [],
+    stderr: "",
+    stdout: "[with-square-brackets].js",
+  });
+
+  runCli("patterns-special-characters/dots", [
+    "[...with-square-brackets-and-dots].js",
+    "-l",
+  ]).test({
+    status: 1,
+    write: [],
+    stderr: "",
+    stdout: "[...with-square-brackets-and-dots].js",
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ async function runGlobs(options: Options, pluginsDefaultOptions: PluginsOptions,`
`200`	`200`
`201`	`201`	`if (!totalMatched && !totalIgnored) {`
`202`	`202`	`if (options.errorOnUnmatchedPattern) {`
`203`		- stderr.prefixed.error(`No files matching the given patterns were found`);
	`203`	+ stderr.prefixed.error(`No files matching the given patterns were found.`);
`204`	`204`	`}`
`205`	`205`	`}`
`206`	`206`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +foo(
++
++
 +)