Refactored "normalizeToPosix" utility to fit with the rest of the utilities

Author: fabiospampinato

src/index.ts

@@ -12,7 +12,18 @@ import Known from "./known.js";
 import Logger from "./logger.js";
 import { makePrettier } from "./prettier.js";
 import { castArray, getExpandedFoldersPaths, getFoldersChildrenPaths, getPluginsVersions, getProjectPath, getStdin, getTargetsPaths } from "./utils.js";
-import { fastRelativePath, isNull, isString, isUndefined, negate, pluralize, trimFinalNewline, uniq, without, normalizeToPosix } from "./utils.js";
+import {
+  fastRelativePath,
+  isNull,
+  isString,
+  isUndefined,
+  negate,
+  normalizePathSeparatorsToPosix,
+  pluralize,
+  trimFinalNewline,
+  uniq,
+  without,
+} from "./utils.js";
 import type { FormatOptions, Options, PluginsOptions } from "./types.js";
 
 async function run(options: Options, pluginsDefaultOptions: PluginsOptions, pluginsCustomOptions: PluginsOptions): Promise<void> {
@@ -162,7 +173,7 @@ async function runGlobs(options: Options, pluginsDefaultOptions: PluginsOptions,
         } else {
           totalUnformatted += 1;
           const filePath = filesPathsTargets[i];
-          const fileNameToDisplay = normalizeToPosix(fastRelativePath(rootPath, filePath));
+          const fileNameToDisplay = normalizePathSeparatorsToPosix(fastRelativePath(rootPath, filePath));
           if (options.check) {
             stderr.prefixed.warn(fileNameToDisplay);
           } else if (options.list || options.write) {
@@ -180,7 +191,7 @@ async function runGlobs(options: Options, pluginsDefaultOptions: PluginsOptions,
         totalErrored += 1;
         pathsErrored.push(filesPathsTargets[i]);
         const filePath = filesPathsTargets[i];
-        const fileNameToDisplay = normalizeToPosix(fastRelativePath(rootPath, filePath));
+        const fileNameToDisplay = normalizePathSeparatorsToPosix(fastRelativePath(rootPath, filePath));
         //TODO: Make sure the error is syntax-highlighted when possible
         if (options.check || options.write || options.dump) {
           stderr.prefixed.error(`${fileNameToDisplay}: ${error}`);
@@ -197,9 +208,9 @@ async function runGlobs(options: Options, pluginsDefaultOptions: PluginsOptions,
   stdout.prefixed.debug(`Files formatted: ${totalFormatted}`);
   stdout.prefixed.debug(`Files unformatted: ${totalUnformatted}`);
   stdout.prefixed.debug(`Files unknown: ${totalUnknown}`);
-  stdout.prefixed.debug(() => pathsUnknown.map((filePath) => normalizeToPosix(fastRelativePath(rootPath, filePath))).join("\n"));
+  stdout.prefixed.debug(() => pathsUnknown.map((filePath) => normalizePathSeparatorsToPosix(fastRelativePath(rootPath, filePath))).join("\n"));
   stdout.prefixed.debug(`Files errored: ${totalErrored}`);
-  stdout.prefixed.debug(() => pathsErrored.map((filePath) => normalizeToPosix(fastRelativePath(rootPath, filePath))).join("\n"));
+  stdout.prefixed.debug(() => pathsErrored.map((filePath) => normalizePathSeparatorsToPosix(fastRelativePath(rootPath, filePath))).join("\n"));
 
   if (!totalMatched && !totalIgnored) {
     if (options.errorOnUnmatchedPattern) {

src/utils.ts

@@ -123,6 +123,10 @@ function getModulePath(name: string, rootPath: string): string {
   return modulePath;
 }
 
+function identity<T>(value: T): T {
+  return value;
+}
+
 const getPlugin = memoize((name: string): Promise<PrettierPlugin> => {
   const pluginPath = getPluginPath(name);
   const plugin = getModule<PrettierPlugin>(pluginPath);
@@ -661,6 +665,16 @@ function normalizePrettierOptions(options: unknown, folderPath: string): Prettie
   return config;
 }
 
+const normalizePathSeparatorsToPosix = (() => {
+  if (path.sep === "\\") {
+    return (filePath: string): string => {
+      return filePath.replaceAll("\\", "/");
+    };
+  } else {
+    return identity;
+  }
+})();
+
 function omit<T extends object, K extends keyof T>(object: T, keys: K[]): Omit<T, K> {
   const clone = { ...object };
 
@@ -733,11 +747,6 @@ function zipObjectUnless<T extends Key, U>(keys: T[], values: U[], unless: (valu
   return map;
 }
 
-/**
- * Replace `\` with `/` on Windows
- */
-const normalizeToPosix = path.sep === "\\" ? (filepath: string): string => filepath.replaceAll("\\", "/") : (filepath: string): string => filepath;
-
 export {
   castArray,
   fastJoinedPath,
@@ -781,7 +790,7 @@ export {
   normalizeFormatOptions,
   normalizePluginOptions,
   normalizePrettierOptions,
-  normalizeToPosix,
+  normalizePathSeparatorsToPosix,
   omit,
   once,
   pluralize,