element with `contentEditable=undefined` crashes in Preact but not React

[davidruisinger]

Reproduction

This works in React:

<p contentEditable={undefined}><p>

codesandbox

But throws an error in Preact:

Failed to set the 'contentEditable' property on 'HTMLElement': The value provided ('') is not one of 'true', 'false', 'plaintext-only', or 'inherit'

codesandbox

[marvinhagemeister]

FYI: Just released the fix as part of Preact 10.5.10 👍

[davidruisinger]

@marvinhagemeister THX for the very quick fix. Unfortunately your fix leads to another diff compared to React.
If a parent element has the contentEditable prop set to true, I can explicitly set it to false on any child element to disable editing on this child element:
See codesandbox

With your fix, the contentEditable prop will be removed completely if it is set to false which causes the child element to be still editable:
See codesandbox

[marvinhagemeister]

@davidruisinger You're completely right! I should've been more thorough. Thanks for the reminder, I've filed #2938 to address this 👍