Add editorconfig and fixed var.

Author: gfraiteur

.editorconfig

@@ -0,0 +1,146 @@
+# Remove the line below if you want to inherit .editorconfig settings from higher directories
+root = true
+
+# C# files
+[*.cs]
+
+#### Core EditorConfig Options ####
+
+# Indentation and spacing
+indent_size = 2
+indent_style = space
+tab_width = 2
+
+# New line preferences
+end_of_line = crlf
+insert_final_newline = false
+
+#### .NET Coding Conventions ####
+
+# this. and Me. preferences
+dotnet_style_qualification_for_event = true:suggestion
+dotnet_style_qualification_for_field = true:suggestion
+dotnet_style_qualification_for_method = true:suggestion
+dotnet_style_qualification_for_property = true:suggestion
+
+# Language keywords vs BCL types preferences
+dotnet_style_predefined_type_for_locals_parameters_members = true:warning
+dotnet_style_predefined_type_for_member_access = true:silent
+
+# Parentheses preferences
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:suggestion
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:suggestion
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:suggestion
+
+# Modifier preferences
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:silent
+
+# Expression-level preferences
+csharp_style_deconstructed_variable_declaration = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_throw_expression = true:suggestion
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_prefer_auto_properties = true:suggestion
+dotnet_style_prefer_compound_assignment = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
+dotnet_style_prefer_conditional_expression_over_return = true:silent
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = false:suggestion
+
+# Field preferences
+dotnet_style_readonly_field = true:suggestion
+
+# Parameter preferences
+dotnet_code_quality_unused_parameters = all:suggestion
+
+#### C# Coding Conventions ####
+
+# var preferences
+csharp_style_var_elsewhere = true:warning
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+
+# Expression-bodied members
+csharp_style_expression_bodied_accessors = when_on_single_line:suggestion
+csharp_style_expression_bodied_constructors = false:silent
+csharp_style_expression_bodied_indexers = when_on_single_line:suggestion
+csharp_style_expression_bodied_lambdas = true:silent
+csharp_style_expression_bodied_local_functions = false:silent
+csharp_style_expression_bodied_methods = when_on_single_line:silent
+csharp_style_expression_bodied_operators = when_on_single_line:suggestion
+csharp_style_expression_bodied_properties = when_on_single_line:suggestion
+
+# Pattern matching preferences
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+
+# Null-checking preferences
+csharp_style_conditional_delegate_call = true:suggestion
+
+# Modifier preferences
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async
+
+# Code-block preferences
+csharp_prefer_braces = true:suggestion
+
+# Expression-level preferences
+csharp_prefer_simple_default_expression = true:suggestion
+csharp_style_pattern_local_over_anonymous_function = true:suggestion
+csharp_style_prefer_index_operator = true:suggestion
+csharp_style_prefer_range_operator = true:suggestion
+csharp_style_unused_value_assignment_preference = discard_variable:suggestion
+csharp_style_unused_value_expression_statement_preference = discard_variable:silent
+
+#### C# Formatting Rules ####
+
+# New line preferences
+csharp_new_line_before_catch = true
+csharp_new_line_before_else = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_open_brace = all
+csharp_new_line_between_query_expression_clauses = true
+
+# Indentation preferences
+csharp_indent_block_contents = true
+csharp_indent_braces = false
+csharp_indent_case_contents = true
+csharp_indent_case_contents_when_block = true
+csharp_indent_labels = one_less_than_current
+csharp_indent_switch_labels = true
+
+# Space preferences
+csharp_space_after_cast = false
+csharp_space_after_colon_in_inheritance_clause = true
+csharp_space_after_comma = true
+csharp_space_after_dot = false
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_after_semicolon_in_for_statement = true
+csharp_space_around_binary_operators = before_and_after
+csharp_space_around_declaration_statements = false
+csharp_space_before_colon_in_inheritance_clause = true
+csharp_space_before_comma = false
+csharp_space_before_dot = false
+csharp_space_before_open_square_brackets = false
+csharp_space_before_semicolon_in_for_statement = false
+csharp_space_between_empty_square_brackets = false
+csharp_space_between_method_call_empty_parameter_list_parentheses = false
+csharp_space_between_method_call_name_and_opening_parenthesis = false
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
+csharp_space_between_method_declaration_name_and_open_parenthesis = false
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_space_between_square_brackets = false
+
+# Wrapping preferences
+csharp_preserve_single_line_blocks = true
+csharp_preserve_single_line_statements = true
+

Diagnostics/PostSharp.Samples.Logging.ElasticStack/.editorconfig

@@ -46,12 +46,12 @@ internal void Stop()
 
         internal void Pause()
         {
-            Win32.GetThreadTimes(Win32.GetCurrentThread(), out _, out _, out long kernelTime, out long userTime);
+            Win32.GetThreadTimes(Win32.GetCurrentThread(), out _, out _, out var kernelTime, out var userTime);
 
 
-            long cpuTime = (kernelTime - this._kernelTimestamp) + (userTime - this._userTimestamp);
+            var cpuTime = (kernelTime - this._kernelTimestamp) + (userTime - this._userTimestamp);
 
-            long threadTime = ProfilingServices.GetTimestamp() - this._threadTimestamp;
+            var threadTime = ProfilingServices.GetTimestamp() - this._threadTimestamp;
 
             this.MetricData.CpuTime += cpuTime;
             this.MetricData.ThreadTime += threadTime;

Framework/PostSharp.Samples.Profiling/MethodCallData.cs

@@ -37,7 +37,7 @@ public void AddData(in MetricData data)
             if (this.IsWriting)
                 throw new InvalidOperationException();
 #endif
-            int localVersion = this._version;
+            var localVersion = this._version;
             this._version = localVersion + 1;
             Thread.MemoryBarrier();
 
@@ -54,7 +54,7 @@ public void AddExclusion(in ExcludedTimeData data)
             if (this.IsWriting)
                 throw new InvalidOperationException();
 #endif
-            int localVersion = this._version;
+            var localVersion = this._version;
             this._version = localVersion + 1;
             Thread.MemoryBarrier();
 
@@ -67,11 +67,11 @@ public void AddExclusion(in ExcludedTimeData data)
 
         public void GetData( out MetricData data )
         {
-            SpinWait spinWait = new SpinWait();
+            var spinWait = new SpinWait();
 
             while (true)
             {
-                int versionBefore = this._version;
+                var versionBefore = this._version;
 
                 while (this.IsWriting)
                 {

Framework/PostSharp.Samples.Profiling/MetricAccessor.cs

@@ -17,22 +17,22 @@ private static void Main(string[] args)
             // TODO: Add your own instrumentation key.
             const string instrumentationKey = "4fe9fc01-23cc-40ee-94e1-6dc532d861b9";
 
-            TelemetryConfiguration telemetryConfiguration = new TelemetryConfiguration(instrumentationKey);
-            TelemetryClient telemetryClient = new TelemetryClient(telemetryConfiguration);
+            var telemetryConfiguration = new TelemetryConfiguration(instrumentationKey);
+            var telemetryClient = new TelemetryClient(telemetryConfiguration);
             if ( ! telemetryClient.IsEnabled() )
             {
                 Console.Write("TelemetryClient is not enabled.");
                 return;
             }
-            TimeSpan period = TimeSpan.FromSeconds(10);
+            var period = TimeSpan.FromSeconds(10);
             ProfilingServices.Initialize(telemetryClient, period);
 
             Console.WriteLine($"Sampling every {period.TotalSeconds} seconds. Press Ctrl-C to stop, then wait a few seconds for completion.");
 
             Console.CancelKeyPress += OnCancel;
 
-            Thread[] threads = new Thread[16];
-            for ( int i = 0; i < threads.Length; i++ )
+            var threads = new Thread[16];
+            for ( var i = 0; i < threads.Length; i++ )
             {
                 threads[i] = new Thread(ThreadMain);
                 threads[i].Start();

Framework/PostSharp.Samples.Profiling/Program.cs

@@ -30,7 +30,7 @@ public MetricMetadata RegisterMethod( MethodBase method )
         {
             lock (this.registrationLock )
             {
-                MetricMetadata profiledMethod = new MetricMetadata(method, this.ProfiledMethodCount );
+                var profiledMethod = new MetricMetadata(method, this.ProfiledMethodCount );
 
                 if ( this.MetricsMetadata.Length <= this.ProfiledMethodCount)
                 {
@@ -61,13 +61,13 @@ public MetricData[] GetMetrics()
 
             var treadLocalCollectorsCopy = this._threadLocalCollectors.Values;
 
-            long timestamp = ProfilingServices.GetTimestamp();
+            var timestamp = ProfilingServices.GetTimestamp();
 
-            for (int i = 0; i < metrics.Length; i++)
+            for (var i = 0; i < metrics.Length; i++)
             {
-                MetricMetadata method = profiledMethodsCopy[i];
+                var method = profiledMethodsCopy[i];
 
-                int attempts = 0;
+                var attempts = 0;
                 while ( true )
                 {
                     metrics[i].Timestamp = timestamp;
@@ -76,7 +76,7 @@ public MetricData[] GetMetrics()
                     {
 
 
-                        if (threadLocalCollector.GetSample(method, out MetricData threadLocalData))
+                        if (threadLocalCollector.GetSample(method, out var threadLocalData))
                         {
                             metrics[i].AddData(threadLocalData);
                         }

Framework/PostSharp.Samples.Profiling/SampleCollector.cs

@@ -52,7 +52,7 @@ private void OnTime(object state)
 
         private void PublishMetrics(IReadOnlyList<MetricMetadata> methods, MetricData[] metrics)
         {
-            for ( int i = 0; i < metrics.Length; i++)
+            for ( var i = 0; i < metrics.Length; i++)
             {
                 MetricData lastSample;
                 if ( i < this.lastSamples.Length )
@@ -81,7 +81,7 @@ private void PublishMetric( MetricMetadata method, in MetricData metric )
             if (metric.ExecutionCount > 0)
             {
 
-                Dictionary<string, double> metrics = new Dictionary<string, double>
+                var metrics = new Dictionary<string, double>
                 {
                     ["ExceptionCount"] = metric.ExceptionCount,
                     ["ExecutionCount"] = metric.ExecutionCount,

Framework/PostSharp.Samples.Profiling/SamplePublisher.cs

@@ -30,7 +30,7 @@ public void ExitMethod(MetricMetadata method, in ExcludedTimeData excludedData )
 
             if (_contextStack.Count > 0)
             {
-                MetricAccessor parentContext = _contextStack.Peek();
+                var parentContext = _contextStack.Peek();
                 parentContext.AddExclusion(excludedData);
             }
 
@@ -56,7 +56,7 @@ public void AddSample(MetricMetadata method, in MetricData data)
 
 
 
-            MetricAccessor sampleAccessor = GetAccessor(method);
+            var sampleAccessor = GetAccessor(method);
 
             sampleAccessor.AddData(data);