From 9c0904be9fbc904c3a2503b9edf18887a0dfbfda Mon Sep 17 00:00:00 2001 From: Helen Powley <78801223+hpowley@users.noreply.github.com> Date: Mon, 27 Jul 2026 12:26:51 +0100 Subject: [PATCH 1/2] Remove unused variable and parameter call for iswBlimX Removed unused variable 'iswBlimX' and its parameter call. --- src/bacteria_docdyn.F90 | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/bacteria_docdyn.F90 b/src/bacteria_docdyn.F90 index 9d5807d2..d031ec07 100644 --- a/src/bacteria_docdyn.F90 +++ b/src/bacteria_docdyn.F90 @@ -30,7 +30,6 @@ module ersem_bacteria_docdyn type (type_diagnostic_variable_id) :: id_minn,id_minp ! Parameters integer :: nRP - integer :: iswBlimX real(rk) :: q10B1X,chdB1oX real(rk) :: chB1nX,chB1pX real(rk) :: sdB1X @@ -74,7 +73,6 @@ subroutine initialize(self,configunit) !EOP !----------------------------------------------------------------------- !BOC - call self%get_parameter(self%iswBlimX,'iswBlim', '', 'nutrient limitation (1: minimum of inorganic and organic availability, 2: additive availability)', minimum=1, maximum=2) call self%get_parameter(self%q10B1X, 'q10', '-', 'Q_10 temperature coefficient') call self%get_parameter(self%chdB1oX, 'chdo', '-', 'Michaelis-Menten constant for oxygen limitation') call self%get_parameter(self%chB1nX, 'chn', 'mmol N/m^3', 'Michaelis-Menten constant for nitrate limitation') From eb678ebdb0a2f50378e04beb4baf19e425c1d3c8 Mon Sep 17 00:00:00 2001 From: Helen Powley Date: Mon, 27 Jul 2026 13:29:08 +0100 Subject: [PATCH 2/2] Remove iswBlim from yaml files --- .../ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-denit.yaml | 1 - .../ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-n2o.yaml | 1 - testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop.yaml | 1 - testcases/ersem-15.06/fabm-ersem-15.06-L4-noben-docdyn-iop.yaml | 1 - testcases/fabm-ersem-26.02-dvm-n2o.yaml | 1 - testcases/fabm-ersem-26.02-dvm.yaml | 1 - testcases/fabm-ersem.yaml.template | 1 - 7 files changed, 7 deletions(-) diff --git a/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-denit.yaml b/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-denit.yaml index 57763209..f0badd82 100644 --- a/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-denit.yaml +++ b/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-denit.yaml @@ -215,7 +215,6 @@ instances: long_name: bacteria model: ersem/bacteria_docdyn parameters: - iswBlim: 2 # nutrient limitation (1: minimum of inorganic and organic availability, 2: additive availability) q10: 2.0 # Q_10 temperature coefficient (-) chdo: 0.31 # Michaelis-Menten constant for oxygen limitation (-) chn: 0.5 # Michaelis-Menten constant for nitrate limitation (mmol N/m^3) diff --git a/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-n2o.yaml b/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-n2o.yaml index 8d39a258..c116ec56 100644 --- a/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-n2o.yaml +++ b/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop-n2o.yaml @@ -213,7 +213,6 @@ instances: long_name: bacteria model: ersem/bacteria_docdyn parameters: - iswBlim: 2 # nutrient limitation (1: minimum of inorganic and organic availability, 2: additive availability) q10: 2.0 # Q_10 temperature coefficient (-) chdo: 0.31 # Michaelis-Menten constant for oxygen limitation (-) chn: 0.5 # Michaelis-Menten constant for nitrate limitation (mmol N/m^3) diff --git a/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop.yaml b/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop.yaml index 652033d7..199fc4d3 100644 --- a/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop.yaml +++ b/testcases/ersem-15.06/fabm-ersem-15.06-L4-ben-docdyn-iop.yaml @@ -206,7 +206,6 @@ instances: long_name: bacteria model: ersem/bacteria_docdyn parameters: - iswBlim: 2 # nutrient limitation (1: minimum of inorganic and organic availability, 2: additive availability) q10: 2.0 # Q_10 temperature coefficient (-) chdo: 0.31 # Michaelis-Menten constant for oxygen limitation (-) chn: 0.5 # Michaelis-Menten constant for nitrate limitation (mmol N/m^3) diff --git a/testcases/ersem-15.06/fabm-ersem-15.06-L4-noben-docdyn-iop.yaml b/testcases/ersem-15.06/fabm-ersem-15.06-L4-noben-docdyn-iop.yaml index 39efe578..fd49875a 100644 --- a/testcases/ersem-15.06/fabm-ersem-15.06-L4-noben-docdyn-iop.yaml +++ b/testcases/ersem-15.06/fabm-ersem-15.06-L4-noben-docdyn-iop.yaml @@ -210,7 +210,6 @@ instances: long_name: bacteria model: ersem/bacteria_docdyn parameters: - iswBlim: 2 # nutrient limitation (1: minimum of inorganic and organic availability, 2: additive availability) q10: 2.0 # Q_10 temperature coefficient (-) chdo: 0.31 # Michaelis-Menten constant for oxygen limitation (-) chn: 0.5 # Michaelis-Menten constant for nitrate limitation (mmol N/m^3) diff --git a/testcases/fabm-ersem-26.02-dvm-n2o.yaml b/testcases/fabm-ersem-26.02-dvm-n2o.yaml index 95749003..e89a8af4 100755 --- a/testcases/fabm-ersem-26.02-dvm-n2o.yaml +++ b/testcases/fabm-ersem-26.02-dvm-n2o.yaml @@ -207,7 +207,6 @@ instances: long_name: bacteria model: ersem/bacteria_docdyn parameters: - iswBlim: 2 # nutrient limitation (1: minimum of inorganic and organic availability, 2: additive availability) q10: 2.0 # Q_10 temperature coefficient (-) chdo: 0.31 # Michaelis-Menten constant for oxygen limitation (-) chn: 0.5 # Michaelis-Menten constant for nitrate limitation (mmol N/m^3) diff --git a/testcases/fabm-ersem-26.02-dvm.yaml b/testcases/fabm-ersem-26.02-dvm.yaml index 2f95da67..eecabd0c 100755 --- a/testcases/fabm-ersem-26.02-dvm.yaml +++ b/testcases/fabm-ersem-26.02-dvm.yaml @@ -200,7 +200,6 @@ instances: long_name: bacteria model: ersem/bacteria_docdyn parameters: - iswBlim: 2 # nutrient limitation (1: minimum of inorganic and organic availability, 2: additive availability) q10: 2.0 # Q_10 temperature coefficient (-) chdo: 0.31 # Michaelis-Menten constant for oxygen limitation (-) chn: 0.5 # Michaelis-Menten constant for nitrate limitation (mmol N/m^3) diff --git a/testcases/fabm-ersem.yaml.template b/testcases/fabm-ersem.yaml.template index 5c7ff2fa..280378d2 100644 --- a/testcases/fabm-ersem.yaml.template +++ b/testcases/fabm-ersem.yaml.template @@ -243,7 +243,6 @@ instances: long_name: bacteria model: ersem/bacteria parameters: - iswBlim: $iswBlimX q10: $q10B1X chdo: $chdB1oX chn: $chB1nX