refactor(question): useless instanciation

btry · btry · commit 144fc49df28d · 2023-06-23T14:10:32.000+02:00
diff --git a/inc/question.class.php b/inc/question.class.php
@@ -352,7 +352,6 @@ private function checkBeforeSave($input) : array {
          return [];
       }
       // - field type is compatible with accessibility of the form
-      $form = PluginFormcreatorCommon::getForm();
       $section = PluginFormcreatorSection::getById($input[PluginFormcreatorSection::getForeignKeyField()]);
       $form = PluginFormcreatorForm::getByItem($section);
       if ($form->isPublicAccess() && !$this->field->isPublicFormCompatible()) {

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,6 @@ private function checkBeforeSave($input) : array {`
`352`	`352`	`return [];`
`353`	`353`	`}`
`354`	`354`	`// - field type is compatible with accessibility of the form`
`355`		`- $form = PluginFormcreatorCommon::getForm();`
`356`	`355`	`$section = PluginFormcreatorSection::getById($input[PluginFormcreatorSection::getForeignKeyField()]);`
`357`	`356`	`$form = PluginFormcreatorForm::getByItem($section);`
`358`	`357`	`if ($form->isPublicAccess() && !$this->field->isPublicFormCompatible()) {`