fix: resolve workspace compilation for plotly_static (#400)

When checking out the repository fresh and running `cargo check` at the workspace root, compilation fails because `plotly_static` has no driver features enabled by default.

This commit resolves the compilation error by:
1. Adding `default = ["chromedriver"]` to `plotly_static/Cargo.toml` features.
2. Making Chrome configurations conditional on `not(feature = "geckodriver")` to allow Firefox (`geckodriver`) to take priority when both features are active simultaneously (e.g. in CI pipelines).
3. Replacing the mutual exclusion compile error in `build.rs` with a compiler warning.

Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>

Author: RedZapdos123

plotly_static/Cargo.toml

@@ -1,49 +1,50 @@
-[package]
-name = "plotly_static"
-version = "0.1.0"
-description = "Export Plotly graphs to static images using WebDriver"
-authors = ["Andrei Gherghescu andrei-ng@protonmail.com"]
-license = "MIT"
-workspace = ".."
-homepage = "https://github.com/plotly/plotly.rs"
-repository = "https://github.com/plotly/plotly.rs"
-edition = "2021"
-keywords = ["plotly", "static", "image", "export", "webdriver"]
-
-exclude = ["target/*"]
-
-[features]
-webdriver_download = []
-geckodriver = []
-chromedriver = []
-# This is used for enabling extra debugging messages and debugging functionality
-debug = []
-
-[dependencies]
-log = "0.4"
-serde = { version = "1.0", features = ["derive"] }
-rand = "0.10"
-serde_json = "1.0"
-base64 = "0.22"
-fantoccini = "0.22"
-tokio = { version = "1", features = ["full"] }
-anyhow = "1.0"
-urlencoding = "2"
-reqwest = { version = "0.13", features = ["blocking"] }
-
-[dev-dependencies]
-plotly_static = { path = "." }
-ndarray = { version = "0.17" }
-env_logger = "0.11"
-clap = { version = "4.0", features = ["derive"] }
-
-[build-dependencies]
-tokio = { version = "1", features = ["full"] }
-anyhow = "1.0"
-dirs = "6.0"
-zip = "8.0"
-webdriver-downloader = "0.16"
-
-# Needed for docs.rs to build the documentation
-[package.metadata.docs.rs]
-features = ["chromedriver"]
+[package]
+name = "plotly_static"
+version = "0.1.0"
+description = "Export Plotly graphs to static images using WebDriver"
+authors = ["Andrei Gherghescu andrei-ng@protonmail.com"]
+license = "MIT"
+workspace = ".."
+homepage = "https://github.com/plotly/plotly.rs"
+repository = "https://github.com/plotly/plotly.rs"
+edition = "2021"
+keywords = ["plotly", "static", "image", "export", "webdriver"]
+
+exclude = ["target/*"]
+
+[features]
+default = ["chromedriver"]
+webdriver_download = []
+geckodriver = []
+chromedriver = []
+# This is used for enabling extra debugging messages and debugging functionality
+debug = []
+
+[dependencies]
+log = "0.4"
+serde = { version = "1.0", features = ["derive"] }
+rand = "0.10"
+serde_json = "1.0"
+base64 = "0.22"
+fantoccini = "0.22"
+tokio = { version = "1", features = ["full"] }
+anyhow = "1.0"
+urlencoding = "2"
+reqwest = { version = "0.13", features = ["blocking"] }
+
+[dev-dependencies]
+plotly_static = { path = "." }
+ndarray = { version = "0.17" }
+env_logger = "0.11"
+clap = { version = "4.0", features = ["derive"] }
+
+[build-dependencies]
+tokio = { version = "1", features = ["full"] }
+anyhow = "1.0"
+dirs = "6.0"
+zip = "8.0"
+webdriver-downloader = "0.16"
+
+# Needed for docs.rs to build the documentation
+[package.metadata.docs.rs]
+features = ["chromedriver"]

plotly_static/build.rs

@@ -8,10 +8,6 @@ use anyhow::{anyhow, Context, Result};
 use tokio::time::sleep;
 use webdriver_downloader::prelude::*;
 
-// Enforce that only one driver feature is enabled
-#[cfg(all(feature = "geckodriver", feature = "chromedriver"))]
-compile_error!("Only one of 'geckodriver' or 'chromedriver' features can be enabled at a time.");
-
 // Enforce that at least one driver feature is enabled
 #[cfg(not(any(feature = "geckodriver", feature = "chromedriver")))]
 compile_error!("At least one of 'geckodriver' or 'chromedriver' features must be enabled.");
@@ -199,7 +195,7 @@ fn setup_driver(config: &WebdriverDownloadConfig) -> Result<()> {
     Ok(())
 }
 
-#[cfg(feature = "chromedriver")]
+#[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
 fn get_chrome_path() -> Result<PathBuf> {
     if let Ok(chrome_path) = env::var(BROWSER_BIN_PATH_ENV) {
         let path = PathBuf::from(&chrome_path);
@@ -292,6 +288,9 @@ async fn download(
 }
 
 fn main() -> Result<()> {
+    #[cfg(all(feature = "geckodriver", feature = "chromedriver"))]
+    println!("cargo::warning=Both 'geckodriver' and 'chromedriver' features are enabled. 'geckodriver' will take priority.");
+
     if cfg!(feature = "webdriver_download") {
         println!("cargo:rerun-if-changed=src/lib.rs");
         let webdriver_bin_dir = user_bin_dir();
@@ -300,7 +299,7 @@ fn main() -> Result<()> {
             webdriver_bin_dir.to_string_lossy()
         );
 
-        #[cfg(feature = "chromedriver")]
+        #[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
         {
             let config = WebdriverDownloadConfig {
                 driver_name: CHROMEDRIVER_NAME,
@@ -323,7 +322,7 @@ fn main() -> Result<()> {
             println!("cargo::warning=No specific driver feature enabled, skipping driver setup");
         }
     } else {
-        #[cfg(feature = "chromedriver")]
+        #[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
         {
             let msg = format!("'webdriver_download' feature disabled. Please install a '{CHROMEDRIVER_NAME}' version manually and make the environment variable 'WEBDRIVER_PATH' point to it.");
             println!("cargo::warning={msg}");

plotly_static/src/lib.rs

@@ -461,24 +461,20 @@ impl Default for StaticExporterBuilder {
             offline_mode: false,
             pdf_export_timeout: 150,
             webdriver_browser_caps: {
-                #[cfg(feature = "chromedriver")]
+                #[cfg(feature = "geckodriver")]
                 {
-                    crate::webdriver::chrome_default_caps()
+                    crate::webdriver::firefox_default_caps()
                         .into_iter()
                         .map(|s| s.to_string())
                         .collect()
                 }
-                #[cfg(feature = "geckodriver")]
+                #[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
                 {
-                    crate::webdriver::firefox_default_caps()
+                    crate::webdriver::chrome_default_caps()
                         .into_iter()
                         .map(|s| s.to_string())
                         .collect()
                 }
-                #[cfg(not(any(feature = "chromedriver", feature = "geckodriver")))]
-                {
-                    Vec::new()
-                }
             },
         }
     }
@@ -1129,7 +1125,7 @@ impl AsyncStaticExporter {
         browser_opts.insert("args".to_string(), serde_json::json!(browser_args));
 
         // Add Chrome binary capability if BROWSER_PATH is set
-        #[cfg(feature = "chromedriver")]
+        #[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
         if let Ok(chrome_path) = std::env::var("BROWSER_PATH") {
             browser_opts.insert("binary".to_string(), serde_json::json!(chrome_path));
             debug!("Added Chrome binary capability: {chrome_path}");
@@ -1610,7 +1606,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(feature = "chromedriver")]
+    #[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
     // Skip this test for geckodriver as it doesn't support multiple concurrent
     // sessions on the same process as gracefully as chromedriver
     fn test_webdriver_process_reuse() {
@@ -1675,7 +1671,7 @@ mod tests {
     }
 }
 
-#[cfg(feature = "chromedriver")]
+#[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
 mod chrome {
     /// Returns the browser name for Chrome WebDriver.
     ///
@@ -1713,7 +1709,8 @@ mod firefox {
     }
 }
 
-#[cfg(feature = "chromedriver")]
+#[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
 use chrome::{get_browser_name, get_options_key};
 #[cfg(feature = "geckodriver")]
 use firefox::{get_browser_name, get_options_key};
+

plotly_static/src/template.rs

@@ -39,7 +39,7 @@ pub(crate) fn image_export_js_script() -> String {
 }
 
 pub(crate) fn pdf_export_js_script(timeout_ms: u32) -> String {
-    let foreign_object_rendering = if cfg!(feature = "chromedriver") {
+    let foreign_object_rendering = if cfg!(all(feature = "chromedriver", not(feature = "geckodriver"))) {
         "true"
     } else {
         "false"

plotly_static/src/webdriver.rs

@@ -26,15 +26,16 @@ const WEBDRIVER_PATH_ENV: &str = "WEBDRIVER_PATH";
 #[cfg(feature = "geckodriver")]
 const WEBDRIVER_BIN: &str = "geckodriver";
 
-#[cfg(feature = "chromedriver")]
+#[cfg(all(feature = "chromedriver", not(feature = "geckodriver")))]
 const WEBDRIVER_BIN: &str = "chromedriver";
 
+
 /// Default WebDriver port
 pub(crate) const WEBDRIVER_PORT: u32 = 4444;
 /// Default WebDriver URL
 pub(crate) const WEBDRIVER_URL: &str = "http://127.0.0.1";
 
-#[cfg(all(feature = "chromedriver", not(target_os = "windows")))]
+#[cfg(all(feature = "chromedriver", not(feature = "geckodriver"), not(target_os = "windows")))]
 pub(crate) fn chrome_default_caps() -> Vec<&'static str> {
     vec![
         "--headless",
@@ -65,7 +66,7 @@ pub(crate) fn chrome_default_caps() -> Vec<&'static str> {
     ]
 }
 
-#[cfg(all(feature = "chromedriver", target_os = "windows"))]
+#[cfg(all(feature = "chromedriver", not(feature = "geckodriver"), target_os = "windows"))]
 pub(crate) fn chrome_default_caps() -> Vec<&'static str> {
     vec![
         "--headless=new",
@@ -555,7 +556,7 @@ impl WebDriver {
             }
 
             // Check if chromedriver is in PATH (Windows-specific)
-            #[cfg(all(target_os = "windows", feature = "chromedriver"))]
+            #[cfg(all(target_os = "windows", feature = "chromedriver", not(feature = "geckodriver")))]
             {
                 if let Ok(output) = std::process::Command::new("where")
                     .arg("chromedriver")