Skip to content

Commit 88a6c0d

Browse files
committed
Fix bug where groupclick: toggleitem doesn't work when there are multiple legends
1 parent 4a6c511 commit 88a6c0d

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

src/components/legend/handle_click.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,16 @@ module.exports = function handleClick(g, gd, numClicks) {
1111

1212
if(gd._dragged || gd._editing) return;
1313

14-
var itemClick = fullLayout.legend.itemclick;
15-
var itemDoubleClick = fullLayout.legend.itemdoubleclick;
16-
var groupClick = fullLayout.legend.groupclick;
14+
15+
var legendItem = g.data()[0][0];
16+
if(legendItem.groupTitle && legendItem.noClick) return;
17+
18+
var legendId = legendItem.trace.legend || 'legend';
19+
var legendObj = fullLayout[legendId];
20+
21+
var itemClick = legendObj.itemclick;
22+
var itemDoubleClick = legendObj.itemdoubleclick;
23+
var groupClick = legendObj.groupclick;
1724

1825
if(numClicks === 1 && itemClick === 'toggle' && itemDoubleClick === 'toggleothers' &&
1926
SHOWISOLATETIP && gd.data && gd._context.showTips
@@ -35,9 +42,6 @@ module.exports = function handleClick(g, gd, numClicks) {
3542
fullLayout.hiddenlabels.slice() :
3643
[];
3744

38-
var legendItem = g.data()[0][0];
39-
if(legendItem.groupTitle && legendItem.noClick) return;
40-
4145
var fullData = gd._fullData;
4246
var shapesWithLegend = (fullLayout.shapes || []).filter(function(d) { return d.showlegend; });
4347
var allLegendItems = fullData.concat(shapesWithLegend);

0 commit comments

Comments
 (0)