You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Show the pull request in PR-watch monitor rows
#21359
When a thread watches pull requests, each watch shows up as background work labelled only "Watching pull request #20051". To see which PR it is, or whether its checks are passing, you have to leave the thread and look it up.
The thread already has everything needed. PR-watch monitors are built from the thread's linked pull requests (pullRequestWatchTasks in packages/shared/src/orchestrationV2PendingBackgroundWork.ts). Clients already render linked PRs with title, state, checks and review (LinkedPullRequestList on mobile). The monitor just drops that link and keeps a text label.
Proposal
Keep a reference to the linked PR on PR-watch monitor tasks: an optional pullRequest key on the monitor variant in contracts, filled in by pullRequestWatchTasks.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
When a thread watches pull requests, each watch shows up as background work labelled only "Watching pull request #20051". To see which PR it is, or whether its checks are passing, you have to leave the thread and look it up.
The thread already has everything needed. PR-watch monitors are built from the thread's linked pull requests (
pullRequestWatchTasksinpackages/shared/src/orchestrationV2PendingBackgroundWork.ts). Clients already render linked PRs with title, state, checks and review (LinkedPullRequestListon mobile). The monitor just drops that link and keeps a text label.Proposal
pullRequestkey on the monitor variant in contracts, filled in bypullRequestWatchTasks.Out of scope: other monitor types, per-monitor stop or unwatch, and "last woke" timing. Those can be separate discussions.
Would this direction be welcome? If so, I'll build it on top of #21346 once that lands.
All reactions