Review search: include file names and paths in the PR Code tab and Diff panel

[AndreiShenets]

ℹ️ Written by GPT-6.1 Sol on behalf of Andrei Shenets

Problem

The find bar in a pull request's Code tab and the thread Diff panel searches changed-file contents, but not file names or paths. During review, I often know which file I want rather than a particular line inside it. Searching for that file's name can return no results even though its header is in the diff.

I would like the existing search box to find both files and their contents, without switching to a separate file-navigation workflow.

Proposal

• Include file names and directory paths in the existing find bar in both the PR Code tab and Diff panel on web and desktop.
• Keep content search available in the same query. Include path matches in the existing result count and next/previous navigation, in file display order, and highlight the matching header text.
• Apply the existing match-case, whole-word, and regex options to paths too.
• Find folded files and files outside the currently rendered viewport. Navigating to a matching file header should reveal it without unfolding the file; navigating to a content match should retain the existing unfold behavior.
• For renamed files, search both the old and new paths. Include files with no textual hunks, such as rename-only changes.

This is an extension of find, not a new filename filter: nonmatching files stay visible. It does not add repository-wide search or change which diff files are loaded. Native mobile uses a separate review renderer and is outside this first scope.

Existing work

Merged PR #14623 introduced the current diff find bar through the existing @pierre/diffs patch. Its description references Pierre PR #833, currently an open draft for native CodeView search. I did not find an existing T3 Code issue or discussion specifically requesting filename matching in this find bar, and am not treating the earlier search work as approval for this extension.

I have a reference implementation in my fork, extending that existing patch rather than introducing a second search UI. Focused tests cover path matching, search options, mixed path/content result ordering, both rename paths, and revealing a folded file's matching header without unfolding it. The search and diff-rendering suites pass (32 tests), as do the scoped web typecheck and targeted lint. Browser/Electron visual verification and before/after captures have not been done; those would be needed for an upstream PR.

Decision requested

Would you accept extending the existing find bar to search file names and paths in both the PR Code tab and Diff panel with this scope? If so, is extending the current Pierre patch acceptable while native upstream search is pending, or would you prefer this to wait for an upstream extension point?

I can prepare a focused PR with the observed test commands/results and required UI evidence once the direction and scope are approved, per CONTRIBUTING.md.