Repository navigation
Replies: 1 comment
|
I reproduced this on current Reproduction. iOS 26.5 Simulator Mobile Safari on an iPad Pro 11-inch, touch only, against an isolated dev server.
#15536 fixed iPads with a trackpad by moving these reveals to Ready branch:
After screenshots (same client):
Checks. Typecheck, format and scoped lint (0 errors) pass. A GPT-6.1 Sol review approved it with one nit ( Not verified:
The decision is still yours. Is a touch-only row button the right direction, or should the header menu remain the touch path? If you approve, I'll open it as one focused PR that links this thread. |
Uh oh!
There was an error while loading. Please reload this page.
Problem. In the web and desktop sidebar, a thread row's actions (Settle, Un-settle, Wake, Snooze) appear only on hover or keyboard focus. Until then they are
opacity-0 pointer-events-none(Sidebar.tsx#L1705, #L1890). On a touch or pen device a tap opens the thread, so a touch user can't settle, snooze, wake or pin a thread from the list itself.What already works. After opening a thread, the chat header title menu and More header actions (ChatHeader.tsx#L460, #L509) offer Pin, Settle, Snooze and Wake. They come from the same
buildThreadActionMenuItemsas the row's right-click menu (threadActionMenu.logic.ts#L69). So every action is reachable on touch, one thread at a time and only after navigating to it. Hover users, and the native mobile app with its row swipe actions, can triage the list in place. A long-press reaches the row menu only in browsers that firecontextmenufor touch (Sidebar.tsx#L1626). I haven't tested which browsers do.Proposed narrow outcome. On coarse pointers only (
pointer-coarse:), each sidebar row gets one small "More actions" button. It opens the existing row action menu, anchored to the button.Background. #11668 built a full swipe workflow: reveal, full-swipe commit, and Pin on a right swipe. It was closed for missing prior approval and missing current media. The closure noted that the touch-access need is worth preserving. This proposal deliberately drops that gesture machinery.
Precedent, not approval. #11020 and #12370 made existing hover-only controls visible on touch with
pointer-coarse:. This proposal reuses that pattern, but those PRs don't approve it, because it adds a new control rather than revealing an existing one.Acceptance criteria, if approved
Evidence the PR would include
Decision requested
LegacySidebarout of scope, and should this wait for fix(web): screen readers can reach sidebar row actions #13962?If the header menu is the intended touch path, I'm happy to drop this.
All reactions