Add integration tests for Expressions, and fail

As part of checking whether everything works as expected I am adding
integration tests, and find out that the pretty printer can be a bit
greedy. This is exemplified in the ConstructorPromotionTest where I want
to pass a reference to a local class constant, but the ExpressionPrinter
picks up on the class reference and does not resolve it.

This is a major issue, and more work is needed to

a) parse the whole FQSEN and use that
b) find out how to resolve references, such as self

Another test is needed to see if it resolves relative references as
well, as the Standard PrettyPrinter code gives me the idea it does not.

Author: mvriel

tests/integration/FileDocblockTest.php

@@ -11,6 +11,8 @@
 
 /**
  * Integration tests to check the correct working of processing a namespace into a project.
+ *
+ * @coversNothing
  */
 #[CoversNothing]
 final class FileDocblockTest extends TestCase

tests/integration/PHP8/ConstructorPromotionTest.php

@@ -46,7 +46,7 @@ protected function setUp() : void
         );
     }
 
-    public function testPropertiesAreCreated() : void
+    public function testArgumentsAreReadCorrectly() : void
     {
         $file = $this->project->getFiles()[self::FILE];
         $class = $file->getClasses()['\\PHP8\\ConstructorPromotion'];
@@ -55,13 +55,45 @@ public function testPropertiesAreCreated() : void
         $constructor->addArgument(new Argument('name', new String_(), "'default name'"));
         $constructor->addArgument(new Argument('email', new Object_(new Fqsen('\\PHP8\\Email'))));
         $constructor->addArgument(new Argument('birth_date', new Object_(new Fqsen('\\' . DateTimeImmutable::class))));
+        $constructor->addArgument(
+            new Argument(
+                'created_at',
+                new Object_(new Fqsen('\\' . DateTimeImmutable::class)),
+                new Expression(
+                    'new {{ PHPDOC6ffacd918e2f70478d2fd33dcb58c4d4 }}(\'now\')',
+                    [
+                        '{{ PHPDOC6ffacd918e2f70478d2fd33dcb58c4d4 }}' => new Fqsen('\\DateTimeImmutable')
+                    ]
+                )
+            )
+        );
+        $constructor->addArgument(
+            new Argument(
+                'uses_constants',
+                new Array_(),
+                new Expression(
+                    '[{{ PHPDOC590f53e8699817c6fa498cc11a4cbe63 }}]',
+                    [
+                        '{{ PHPDOC590f53e8699817c6fa498cc11a4cbe63 }}' => new Fqsen('\PHP8\ConstructorPromotion::DEFAULT_VALUE')
+                    ]
+                )
+            )
+        );
 
         self::assertEquals($constructor, $class->getMethods()['\PHP8\ConstructorPromotion::__construct()']);
+    }
+
+    public function testPropertiesAreCreated() : void
+    {
+        $file = $this->project->getFiles()[self::FILE];
+        $class = $file->getClasses()['\\PHP8\\ConstructorPromotion'];
+
         self::assertEquals(
             [
                 '\PHP8\ConstructorPromotion::$name' => $this->expectedNameProperty(),
                 '\PHP8\ConstructorPromotion::$email' => $this->expectedEmailProperty(),
                 '\PHP8\ConstructorPromotion::$birth_date' => $this->expectedBirthDateProperty(),
+                '\PHP8\ConstructorPromotion::$created_at' => $this->expectedCreatedAtProperty(),
             ],
             $class->getProperties()
         );
@@ -89,7 +121,7 @@ private function expectedConstructorMethod(): Method
             false,
             false,
             new Location(18, 264),
-            new Location(29, 568)
+            new Location(31, 709)
         );
     }
 
@@ -141,4 +173,23 @@ private function expectedBirthDateProperty(): Property
             new Object_(new Fqsen('\\' . DateTimeImmutable::class))
         );
     }
+
+    private function expectedCreatedAtProperty(): Property
+    {
+        return new Property(
+            new Fqsen('\PHP8\ConstructorPromotion::$created_at'),
+            new Visibility(Visibility::PRIVATE_),
+            null,
+            new Expression(
+                'new {{ PHPDOC6ffacd918e2f70478d2fd33dcb58c4d4 }}(\'now\')',
+                [
+                    '{{ PHPDOC6ffacd918e2f70478d2fd33dcb58c4d4 }}' => new Fqsen('\\DateTimeImmutable')
+                ]
+            ),
+            false,
+            new Location(29),
+            new Location(29),
+            new Object_(new Fqsen('\\' . DateTimeImmutable::class))
+        );
+    }
 }

tests/integration/data/PHP8/ConstructorPromotion.php

@@ -26,5 +26,7 @@ public function __construct(
         public string $name = 'default name',
         protected Email $email,
         private DateTimeImmutable $birth_date,
+        private DateTimeImmutable $created_at = new DateTimeImmutable('now'),
+        private array $uses_constants = [self::DEFAULT_VALUE],
     ) {}
 }