Improve parsing extension name from config.w32

Author: shivammathur

extension/BuildPhpExtension/BuildPhpExtension.psd1

@@ -83,6 +83,7 @@
         'Get-BuildDirectory',
         'Get-Extension',
         'Get-ExtensionConfig',
+        'Get-ExtensionName',
         'Get-ExtensionSource',
         'Get-File',
         'Get-LibrariesFromConfig',

extension/BuildPhpExtension/private/Get-Extension.ps1

@@ -114,19 +114,7 @@ function Get-Extension {
             Copy-Item -Path "${subDirectory}\*" -Destination $BuildDirectory -Recurse -Force
             Remove-Item -Path $subDirectory -Recurse -Force
         }
-        $configW32Content = Get-Content -Path "config.w32"
-        $extensionLine =  $configW32Content | Select-String -Pattern '\s+(ZEND_)?EXTENSION\(' | Select-Object -Last 1
-        if($null -eq $extensionLine) {
-            throw "No extension found in config.w32"
-        }
-        $name = ($extensionLine -replace '.*EXTENSION\(([^,]+),.*', '$1') -replace '["'']', ''
-        if($name.Contains('oci8')) {
-            $name = 'oci8_19'
-        } elseif ([string]$configW32Content -match ($([regex]::Escape($name)) + '\s*=\s*["''](.+?)["'']')) {
-            if($matches[1] -ne 'no') {
-                $name = $matches[1]
-            }
-        }
+        $name = Get-ExtensionName
 
         if(!$patches) {
             Add-Patches "${name}.ps1"

extension/BuildPhpExtension/private/Get-ExtensionName.ps1

@@ -0,0 +1,58 @@
+function Get-ExtensionName {
+  <#
+    .SYNOPSIS
+        Get the PHP extension name.
+    #>
+  [OutputType()]
+  param (
+  )
+  begin {
+  }
+  process {
+    $configW32Content = Get-Content -Path "config.w32"
+    $extMatch = [regex]::Matches(
+        $configW32Content,
+        '(?is)\b(?:ZEND_)?EXTENSION\s*\(\s*(?<arg>.*?)\s*,'
+    ) | Select-Object -Last 1
+
+    if (-not $extMatch) {
+      throw "No extension found in config.w32 ($Path)"
+    }
+
+    $token = $extMatch.Groups['arg'].Value.Trim()
+
+    if ($token.Length -ge 2 -and (
+    ($token[0] -eq "'" -and $token[-1] -eq "'") -or
+        ($token[0] -eq '"' -and $token[-1] -eq '"')
+    )) {
+      $name = $token.Trim('"', "'").Trim()
+    }
+    else {
+      $varNameEsc = [regex]::Escape($token)
+
+      $assignPattern =
+      '(?is)(?:^|[;{\s])' +
+          '(?:(?:var|let|const)\s+)?' +
+          $varNameEsc +
+          '\s*=\s*(?<q>["\x27])(?<val>[^"\x27]+)\k<q>'
+
+      $m = [regex]::Match($configW32Content, $assignPattern)
+      if ($m.Success) {
+        $val = $m.Groups['val'].Value
+        if ($val -and $val -ne 'no') {
+          $name = $val
+        } else {
+          $name = $token
+        }
+      } else {
+        $name = $token
+      }
+    }
+    if ($name -like '*oci8*') {
+      $name = 'oci8_19'
+    }
+    return $name.Trim()
+  }
+  end {
+  }
+}