refactor(graphviz): rename node content manager to category manager #438

Rename GraphvizNodeContentManager to GraphvizNodeCategoryManager and update icon usage for attribute items. Adjust toolbar ID for consistency.

Author: phodal

exts/ext-diagram/src/main/kotlin/cc/unitmesh/diagram/graphviz/GraphvizDiagramPanel.kt

@@ -52,7 +52,7 @@ class GraphvizDiagramPanel(private val fileEditor: GraphvizPreviewFileEditor) :
 
             val actionsProvider = builder!!.provider.getExtras().toolbarActionsProvider
             val actionGroup = actionsProvider.createToolbarActions(builder!!)
-            val actionToolbar = ActionManager.getInstance().createActionToolbar("AUTODEV.DOT", actionGroup, true)
+            val actionToolbar = ActionManager.getInstance().createActionToolbar("JDL.UML", actionGroup, true)
             actionToolbar.targetComponent = graphView
             actionToolbar.component.setBorder(JBUI.Borders.customLine(JBColor.border(), 0, 0, 1, 0))
 

exts/ext-diagram/src/main/kotlin/cc/unitmesh/diagram/graphviz/GraphvizElementManager.kt

@@ -24,26 +24,10 @@ import javax.swing.Icon
  * Similar to JdlUmlElementManager in JHipster UML implementation
  */
 class GraphvizElementManager : AbstractDiagramElementManager<GraphvizNodeData>() {
-    
-    private var umlProvider: GraphvizUmlProvider? = null
-    
-    /**
-     * Set the UML provider
-     */
-    fun setUmlProvider(provider: GraphvizUmlProvider) {
-        this.umlProvider = provider
-    }
-    
     override fun findInDataContext(dataContext: DataContext): GraphvizNodeData? {
-        val psiFile = CommonDataKeys.PSI_FILE.getData(dataContext)
-        if (psiFile == null) return null
-        
-        val virtualFile = psiFile.virtualFile
-        if (virtualFile == null) return null
-        
-        // Check if this is a DOT file
+        val psiFile = CommonDataKeys.PSI_FILE.getData(dataContext) ?: return null
+        val virtualFile = psiFile.virtualFile ?: return null
         if (!isDotFile(virtualFile)) return null
-        
         return getRootData(psiFile.project, virtualFile)
     }
 
@@ -145,7 +129,7 @@ class GraphvizElementManager : AbstractDiagramElementManager<GraphvizNodeData>()
                     com.intellij.util.PlatformIcons.FIELD_ICON
                 }
             }
-            is GraphvizAttributeItem -> com.intellij.util.PlatformIcons.PROPERTY_ICON
+            is GraphvizAttributeItem -> com.intellij.util.PlatformIcons.METHOD_ICON
             else -> null
         }
     }

…m/graphviz/GraphvizNodeContentManager.kt …/graphviz/GraphvizNodeCategoryManager.ktexts/ext-diagram/src/main/kotlin/cc/unitmesh/diagram/graphviz/GraphvizNodeContentManager.kt renamed to exts/ext-diagram/src/main/kotlin/cc/unitmesh/diagram/graphviz/GraphvizNodeCategoryManager.kt exts/ext-diagram/src/main/kotlin/cc/unitmesh/diagram/graphviz/GraphvizNodeContentManager.kt renamed to exts/ext-diagram/src/main/kotlin/cc/unitmesh/diagram/graphviz/GraphvizNodeCategoryManager.kt

@@ -4,9 +4,6 @@ import com.intellij.diagram.AbstractDiagramNodeContentManager
 import com.intellij.diagram.DiagramBuilder
 import com.intellij.diagram.DiagramCategory
 import com.intellij.util.PlatformIcons
-import cc.unitmesh.diagram.graphviz.model.GraphvizNodeData
-import cc.unitmesh.diagram.graphviz.model.GraphvizSimpleNodeData
-import cc.unitmesh.diagram.graphviz.model.GraphvizEntityNodeData
 import cc.unitmesh.diagram.graphviz.model.GraphvizNodeField
 import cc.unitmesh.diagram.graphviz.model.GraphvizAttributeItem
 import com.intellij.icons.AllIcons
@@ -15,9 +12,9 @@ import com.intellij.icons.AllIcons
  * Node content manager for Graphviz diagrams
  * Similar to JdlUmlCategoryManager in JHipster UML implementation
  */
-class GraphvizNodeContentManager : AbstractDiagramNodeContentManager() {
+class GraphvizNodeCategoryManager : AbstractDiagramNodeContentManager() {
 
-    companion object {
+    companion object Companion {
         private val FIELDS_CATEGORY = DiagramCategory(
             "Fields",
             AllIcons.Nodes.Field,
@@ -27,7 +24,7 @@ class GraphvizNodeContentManager : AbstractDiagramNodeContentManager() {
 
         private val ATTRIBUTES_CATEGORY = DiagramCategory(
             "Attributes",
-            PlatformIcons.PROPERTY_ICON,
+            AllIcons.Nodes.Method,
             true,
             false
         )
@@ -43,9 +40,9 @@ class GraphvizNodeContentManager : AbstractDiagramNodeContentManager() {
         category: DiagramCategory,
         builder: DiagramBuilder?
     ): Boolean {
-        return when {
-            item is GraphvizNodeField -> category == FIELDS_CATEGORY
-            item is GraphvizAttributeItem -> category == ATTRIBUTES_CATEGORY
+        return when (item) {
+            is GraphvizNodeField -> category == FIELDS_CATEGORY
+            is GraphvizAttributeItem -> category == ATTRIBUTES_CATEGORY
             else -> super.isInCategory(nodeElement, item, category, builder)
         }
     }

exts/ext-diagram/src/main/kotlin/cc/unitmesh/diagram/graphviz/GraphvizUmlProvider.kt

@@ -12,23 +12,22 @@ import com.intellij.diagram.DiagramRelationshipManager.NO_RELATIONSHIP_MANAGER
  * Similar to JdlUmlProvider in JHipster UML implementation
  */
 class GraphvizUmlProvider : DiagramProvider<GraphvizNodeData>() {
-    
     private val vfsResolver: DiagramVfsResolver<GraphvizNodeData> = GraphvizVfsResolver()
     private val elementManager: DiagramElementManager<GraphvizNodeData> = GraphvizElementManager()
-    
+
     init {
         (elementManager as GraphvizElementManager).setUmlProvider(this)
     }
-    
+
     @Pattern("[a-zA-Z0-9_-]*")
     override fun getID(): String {
         return "GraphvizDOT"
     }
-    
+
     override fun getPresentableName(): String {
         return "Graphviz DOT Diagram"
     }
-    
+
     override fun createDataModel(
         project: Project,
         seedData: GraphvizNodeData?,
@@ -41,25 +40,25 @@ class GraphvizUmlProvider : DiagramProvider<GraphvizNodeData>() {
         }
         return model
     }
-    
+
     override fun createVisibilityManager(): DiagramVisibilityManager {
         return EmptyDiagramVisibilityManager.INSTANCE
     }
-    
+
     override fun getElementManager(): DiagramElementManager<GraphvizNodeData> {
         return elementManager
     }
-    
+
     override fun getVfsResolver(): DiagramVfsResolver<GraphvizNodeData> {
         return vfsResolver
     }
-    
+
     @Suppress("UNCHECKED_CAST")
     override fun getRelationshipManager(): DiagramRelationshipManager<GraphvizNodeData> {
         return NO_RELATIONSHIP_MANAGER as DiagramRelationshipManager<GraphvizNodeData>
     }
-    
+
     override fun createNodeContentManager(): DiagramNodeContentManager {
-        return GraphvizNodeContentManager()
+        return GraphvizNodeCategoryManager()
     }
 }